From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93762 invoked by alias); 13 Apr 2016 20:05:55 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 93751 invoked by uid 89); 13 Apr 2016 20:05:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=structured, Hx-languages-length:1571 X-HELO: smtp.gentoo.org Date: Wed, 13 Apr 2016 20:05:00 -0000 From: Mike Frysinger To: Carlos O'Donell Cc: libc-alpha@sourceware.org, keld@keldix.com Subject: Re: [PATCH] localedate: LC_IDENTIFICATION.category: set to ISO 14652 2002 standard Message-ID: <20160413200535.GM6588@vapier.lan> Mail-Followup-To: Carlos O'Donell , libc-alpha@sourceware.org, keld@keldix.com References: <20160413163945.GK6588@vapier.lan> <570E96AE.3070209@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3ppNiro4NnszjPnm" Content-Disposition: inline In-Reply-To: <570E96AE.3070209@redhat.com> X-SW-Source: 2016-04/txt/msg00332.txt.bz2 --3ppNiro4NnszjPnm Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1503 On 13 Apr 2016 14:57, Carlos O'Donell wrote: > On 04/13/2016 12:39 PM, Mike Frysinger wrote: > > The ISO 14652 standard defines the valid values for the category > > keyword as only two options: > > posix:1993 > > i18n:2002 > >=20 > > The vast majority of locales had changed the "i18n" string to the > > name of its own locale (e.g. "ak_GH:2013") as well as tweaking the > > date (presumably thinking it should be the date of submission). > >=20 > > Convert all of them to "i18n:2002" for consistency. >=20 > Any chance you can tighten the parser to reject anything but the > two valid category keywords? i figured someone would ask for that eventually :). it's not clear to me how many valid values there are because the ISO 14652 standard is difficult to obtain. i've only be able to find 1999 and 2002 copies, but i'm pretty sure there's other revisions as well. maybe we start off only accepting these two values and worry about the rest later ? the other aspect is that, while we might validate some sanity on the category fields in general, the code (afaict) is not structured for actually handling the differences. for example, if the locale says posix:1993 or i18n:1999 (which the older ISO 14652 1999 standard allows), we don't change the parsing behavior to reject features that are new to i18n:2002. i guess one thing at a time: let's update localdef to only accept these two values and reject all others. i'll look at that before merging this patch in case it's easy to do. -mike --3ppNiro4NnszjPnm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXDqadAAoJEEFjO5/oN/WB7bkQANeyK2QeSxSeyhXhQWCrC49m AWbXPnfER5caI4cjf2WH4VGp4GwErXmQJVSRTB4y7mZ6rYIbG5+y40Xr6CNUtmag DhlSVp6d1swDd0b744p5wr2Vcxx82UlWyB+3dW/blvHFjT39HZdZjIXi6MvPWCTg V9q5jgslQwnTDN2zIufgELzLQ0XIsBuYnFE7Wk/9lCm8AGxPUP6ycucMB18mZfAW LYc05P1++k0hbBHXsxU+o+5b+Klg+do9afUCFcAluynb9KR0Nt1CY2HBTSOAn8gk DHxV6BRt409lZHwgjYKAmMcA/FStFq26827StWsj9HrVgpYW575aJspuqoO0MYmo cCuUWJEibJPmX7YpkA3i7GBbFnD0e9kDzUQ81hKvFadRueihDV7b+V7yaXxOzyoi dM3Aw+eeLE+9YSVa5/DnDJ3MBA/m+HEtH8AKpxDruqWeaJQ8daLxym/5fdIKlMvz swgndMtvBERYGGYZ24XNLwwC8aYMwZ573kT0Sk/hArLBcjwNlP+YZ6vKBeyl6wU+ 2tdqSaPjS+xEk7QPuFyda5zx7X+RKkxSIU2HPcdXgARikSkLQ6fo5AJEwQ0xh2AS 8ndOH1ojTA49t+IuvsrZQ2QaYxHYe9lMhv0jBMrhxe3JQqvwUsBVSw4gfPjgkKb6 V9KEkX/s7xG9fvAVHWOA =S510 -----END PGP SIGNATURE----- --3ppNiro4NnszjPnm--