On 15 Apr 2016 18:47, Serge Hallyn wrote: > Signed-off-by: Serge Hallyn we don't use s-o-b tags > +/* > + * Return true if this is a UNIX98 pty device, as defined in > + * linux/Documentation/devices.txt > + */ GNU style is: /* Return true if this is a UNIX98 pty device, as defined in linux/Documentation/devices.txt. */ this applies to comments below too > + if (is_pty (st) && strlen (procname) < buflen - 1) > + { > + memcpy (ttyname_buf, procname, strlen (procname)); > + ttyname_buf[strlen (procname)] = '\0'; since you already verified buflen, why not use strcpy ? also, GNU style says 8 spaces -> 1 tab -mike