From: Mike Frysinger <vapier@gentoo.org>
To: Brian Norris <computersforpeace@gmail.com>
Cc: linux-mtd@lists.infradead.org,
Michael Kerrisk <mtk.manpages@gmail.com>,
linux-man@vger.kernel.org, libc-alpha@sourceware.org
Subject: Re: [PATCH mtd-utils] include sys/sysmacros.h for major/minor/makedev
Date: Mon, 18 Apr 2016 16:49:00 -0000 [thread overview]
Message-ID: <20160418164908.GR5369@vapier.lan> (raw)
In-Reply-To: <20160418163926.GB52272@google.com>
[-- Attachment #1: Type: text/plain, Size: 920 bytes --]
On 18 Apr 2016 09:39, Brian Norris wrote:
> On Sat, Apr 16, 2016 at 10:30:45PM -0400, Mike Frysinger wrote:
> > These functions have always been defined in sys/sysmacros.h under
> > Linux C libraries. For some, including sys/types.h implicitly
> > includes that as well, but glibc wants to deprecate that, and some
> > others already have. Include the header explicitly for the funcs.
> >
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>
> Patch looks fine to me, thanks. Pushed to mtd-utils.git.
>
> But I don't see this change documented anywhere. (Helpfully, I do see
> the change from your other patch -- _BSD_SOURCE -> _DEFAULT_SOURCE --
> documented though!) Should the man-pages project be updated? I see the
> latest makedev(5) still recommends #include <sys/types.h>.
glibc hasn't moved forward (yet). we should update the man pages now
though to mention sys/sysmacros.h.
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-04-18 16:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1460860245-14895-1-git-send-email-vapier@gentoo.org>
2016-04-18 16:39 ` Brian Norris
2016-04-18 16:49 ` Mike Frysinger [this message]
2016-04-19 5:52 ` [PATCH] makedev(3): point people at sys/sysmacros.h Mike Frysinger
2016-04-20 11:31 ` Michael Kerrisk (man-pages)
2016-04-20 11:48 ` Zack Weinberg
2016-04-20 12:39 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160418164908.GR5369@vapier.lan \
--to=vapier@gentoo.org \
--cc=computersforpeace@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-man@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).