From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50607 invoked by alias); 18 Apr 2016 16:49:12 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 50592 invoked by uid 89); 18 Apr 2016 16:49:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=norris, Norris, Brian X-HELO: smtp.gentoo.org Date: Mon, 18 Apr 2016 16:49:00 -0000 From: Mike Frysinger To: Brian Norris Cc: linux-mtd@lists.infradead.org, Michael Kerrisk , linux-man@vger.kernel.org, libc-alpha@sourceware.org Subject: Re: [PATCH mtd-utils] include sys/sysmacros.h for major/minor/makedev Message-ID: <20160418164908.GR5369@vapier.lan> Mail-Followup-To: Brian Norris , linux-mtd@lists.infradead.org, Michael Kerrisk , linux-man@vger.kernel.org, libc-alpha@sourceware.org References: <1460860245-14895-1-git-send-email-vapier@gentoo.org> <20160418163926.GB52272@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7a4X6VOqfbl9xMrG" Content-Disposition: inline In-Reply-To: <20160418163926.GB52272@google.com> X-SW-Source: 2016-04/txt/msg00438.txt.bz2 --7a4X6VOqfbl9xMrG Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 907 On 18 Apr 2016 09:39, Brian Norris wrote: > On Sat, Apr 16, 2016 at 10:30:45PM -0400, Mike Frysinger wrote: > > These functions have always been defined in sys/sysmacros.h under > > Linux C libraries. For some, including sys/types.h implicitly > > includes that as well, but glibc wants to deprecate that, and some > > others already have. Include the header explicitly for the funcs. > >=20 > > Signed-off-by: Mike Frysinger >=20 > Patch looks fine to me, thanks. Pushed to mtd-utils.git. >=20 > But I don't see this change documented anywhere. (Helpfully, I do see > the change from your other patch -- _BSD_SOURCE -> _DEFAULT_SOURCE -- > documented though!) Should the man-pages project be updated? I see the > latest makedev(5) still recommends #include . glibc hasn't moved forward (yet). we should update the man pages now though to mention sys/sysmacros.h. -mike --7a4X6VOqfbl9xMrG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXFRAEAAoJEEFjO5/oN/WB0nAP/i/PVPI0n2jp5RuhguMuP0Ap vEXT2rP6IWW5xg5fLMcE8fzjII1k+OBXdQAceIgz1Qku660YhWARBMVrH2sBkGpM ThH1R2IO8V3dNFd9x4PHz5IoqLlo4vcV5lO55SQmxj3ZrR/M2xsstgqoJUxTh8X8 mjljSE/c4z/tybDdClgUR4sBbmpz09CpN8TqBN9J8UfVaXjwJ2fbTRuD79n5f6NV 1bloJz2RDtpYFCfxqr9HYij6PY153l1Ah18zftBp1kauGB2L3VXE5GAEjqjbPpDD 5s5HJURgAPdiVNuikuB9Jr4QNoAI3Vcb6SA7QoawHjfU5eyvhVrXy+MuFIVM6oJo vxmvSmHecWBYNmEAjriuPH7F8mTsVOrsQtqBMs4VclnFswm/jEVwt0NXxnah4ci9 JdGBQbW8zEdLc6nkQNfR9goWB9xnxoqS/as6if06ToXqAiIu97LjJM8QMDvqCf2Z HVNem7V/n6Br6/sWqvvO6ykrND7LfbMXI/c0zG6n38bWF2zw2hx1iFyie1tfem7+ WImpDEbXIlmOvVTD6Y9b6XVrNbEZOvAXHkbNXpx01CQvySLPeLUe1ouaVs2Unlig oEEukBJJZHmBcVqidxLU9jQw0EUvzh3yQj6gZWEI8TyWEjHyi8MrXC3orRhTemVA rzIUoPkw0K7UYOxr1MB1 =TPB4 -----END PGP SIGNATURE----- --7a4X6VOqfbl9xMrG--