From: Samuel Thibault <samuel.thibault@gnu.org>
To: Thomas Schwinge <thomas@codesourcery.com>,
Roland McGrath <roland@hack.frob.com>,
bug-hurd@gnu.org, libc-alpha@sourceware.org
Subject: Re: sysdeps/mach/hurd/profil.c (was: [PATCH] hurd: align -p and -pg behavior on Linux)
Date: Mon, 18 Apr 2016 22:56:00 -0000 [thread overview]
Message-ID: <20160418225629.GC2648@var.home> (raw)
In-Reply-To: <20160225142313.GV3460@var.bordeaux.inria.fr>
Samuel Thibault, on Thu 25 Feb 2016 15:23:13 +0100, wrote:
> > As there are accesses to variables shared between different threads,
> > should these be re-written to use GCC's atomic/sync load/store builtins
> > with appropriate semantics?
>
> The current way seems unsafe at least between update_waiter and
> fetch_samples, indeed. I'd say just go with a libc_lock.
Actually there is already a spinlock to protect all of what I mentioned
:) I have fixed the remaining initialization issue.
Samuel
prev parent reply other threads:[~2016-04-18 22:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150919120023.GA12911@var.home>
[not found] ` <87bn75ybeb.fsf@kepler.schwinge.homeip.net>
2016-02-25 14:23 ` Thomas Schwinge
2016-02-25 14:41 ` Samuel Thibault
2016-04-18 22:56 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160418225629.GC2648@var.home \
--to=samuel.thibault@gnu.org \
--cc=bug-hurd@gnu.org \
--cc=libc-alpha@sourceware.org \
--cc=roland@hack.frob.com \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).