On 20 Apr 2016 02:10, Serge Hallyn wrote: > --- a/sysdeps/unix/sysv/linux/ttyname.c > +++ b/sysdeps/unix/sysv/linux/ttyname.c > > + linux/Documentation/devices.txt */ should be a period at the end followed by two spaces > + int m = major (sb->st_rdev); you'll need to include sys/sysmacros.h in this file since you're using major now. > + /* If the link doesn't exist, then it points to a device in another > + namespace. If it is a UNIX98 pty, then return the /proc/self > + fd, as it points to a name unreachable in our namespace */ should be "namespace. */" at the end ;) > --- a/sysdeps/unix/sysv/linux/ttyname_r.c > +++ b/sysdeps/unix/sysv/linux/ttyname_r.c same comments here -mike