From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-69873-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 11039 invoked by alias); 25 May 2016 17:20:51 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 11019 invoked by uid 89); 25 May 2016 17:20:49 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: smtp.gentoo.org
Date: Wed, 25 May 2016 17:24:00 -0000
From: Mike Frysinger <vapier@gentoo.org>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Matt Turner <mattst88@gmail.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH 1/3] Optimize trunc() and truncf().
Message-ID: <20160525172044.GC26300@vapier.lan>
Mail-Followup-To: Joseph Myers <joseph@codesourcery.com>,
	Matt Turner <mattst88@gmail.com>, libc-alpha@sourceware.org
References: <1464139950-31943-1-git-send-email-mattst88@gmail.com>
 <alpine.DEB.2.20.1605251535220.2813@digraph.polyomino.org.uk>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="Wg+vt4irTszSkfR8"
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.20.1605251535220.2813@digraph.polyomino.org.uk>
X-SW-Source: 2016-05/txt/msg00589.txt.bz2


--Wg+vt4irTszSkfR8
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Content-length: 461

On 25 May 2016 15:36, Joseph Myers wrote:
> On Tue, 24 May 2016, Matt Turner wrote:
> > -  else
> > -    {
> > -      if (j0 =3D=3D 0x400)
> > -	/* x is inf or NaN.  */
> > -	return x + x;
> > -    }
>=20
> You're removing too much code here.  You need to keep this addition in th=
e=20
> NaN case to ensure that signaling NaNs raise "invalid" and get converted=
=20
> to quiet NaNs in the process.

does this mean current test coverage is insufficient ?
-mike

--Wg+vt4irTszSkfR8
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-length: 819

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXRd7rAAoJEEFjO5/oN/WBaOgQAKzw5pzskYZxRLe/0fKdX7zz
S9GY8SOLS+ivZwR+jMYZg8cFQWMpRr6F4DY5haHlrSnD+qacFw6cMwDr1xmMjZeZ
cMgreMUVxPBKk04w2UUIvQRquBDRQi0EtKhShHo6W/afqyfB4WWDlEr1GDxllUbK
gG0FFCqJ37wz/Gqf+KLxj7sisdUsPZBXK2CAf3TtstplaO/djzY3QhxkcAelPaLx
/qiP0Wlp4+32iziIUWA+kNe3R2x63WTBiKfhBAKtT2K8iSUGrYEEDC9PtDva3Cg0
bKRL4199dufkx1e4cUpWWaYOCIRMSB/at8az/DpFWTCqIp2HOKwiskwKDHKGEL54
zPnFJguLlmEypJupPCsPa9LEQZ/57c7KaIg0xec8gjieOFSl5fs0xjZfdxmu5VmD
Zf3J6Z1UmYqKteVZCvwjiFgn2GmPxoNtwLXiRqwt9UwtlKQCLsMkwrU74wS49LXX
r3zeNQWNacWZS7HVxFcr5d2vTXx2/HBnLc2p8Eb88eNoUkWo4n7KqcSYYdhz2vbY
UCPh2ovkwR4uakPLPXahlKD9HSJgNfqsd+QUXy3Kt23LhUO6bNPr/ayQ9X4r3emB
rCoVixSvnwqhWM1oXD2pUXu6wJM2ffwcvnfxuG7M9PjdBoSQgo7C9DN+vmlIim6h
aDBzm6OS2P3sMoHGD2JP
=SLsW
-----END PGP SIGNATURE-----

--Wg+vt4irTszSkfR8--