From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19384 invoked by alias); 6 Aug 2016 08:46:04 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 19372 invoked by uid 89); 6 Aug 2016 08:46:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.gentoo.org Date: Sat, 06 Aug 2016 08:46:00 -0000 From: Mike Frysinger To: "Serge E. Hallyn" Cc: Serge Hallyn , libc-alpha@sourceware.org Subject: Re: [PATCH] linux ttyname and ttyname_r: return link if appropriate Message-ID: <20160806084559.GS6702@vapier.lan> Mail-Followup-To: "Serge E. Hallyn" , Serge Hallyn , libc-alpha@sourceware.org References: <20160415184746.GA10830@ubuntumail> <20160415195938.GP6588@vapier.lan> <20160418195318.GB30476@ubuntumail> <20160418200222.GY5369@vapier.lan> <20160418202301.GA30919@ubuntumail> <20160420021012.GA19449@ubuntumail> <20160420022823.GT5369@vapier.lan> <20160420185141.GA31095@ubuntumail> <20160727165711.GA27815@altlinux.org> <20160806020855.GA19897@mail.hallyn.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cMwMn/tF35tO7kHm" Content-Disposition: inline In-Reply-To: <20160806020855.GA19897@mail.hallyn.com> X-SW-Source: 2016-08/txt/msg00250.txt.bz2 --cMwMn/tF35tO7kHm Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-length: 496 On 05 Aug 2016 21:08, Serge E. Hallyn wrote: > #ifdef _STATBUF_ST_RDEV > && S_ISCHR (st1.st_mode) > && st1.st_rdev == st.st_rdev > + && st1.st_dev == st.st_dev > + && st1.st_ino == st.st_ino > #else > && st1.st_ino == st.st_ino > && st1.st_dev == st.st_dev > #endif wouldn't it be better to shuffle the ifdef then ? #ifdef _STATBUF_ST_RDEV && S_ISCHR (st1.st_mode) && st1.st_rdev == st.st_rdev #endif && st1.st_ino == st.st_ino && st1.st_dev == st.st_dev) -mike --cMwMn/tF35tO7kHm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXpaPHAAoJEEFjO5/oN/WBVzYP/AuFvq0IeuVxReVTLtB1UV/B sw5bDC9erTG9+qbG2sRzveLTTVpB97YV3FvfOfxZwQCbf7dqHF7NycO26FHI9TFf qUgUZ4/jZv5YPrdU9hPnvovZVV4djgVdfmiqhzDXhV7tbNARcUm5AZZfQwq6FhUg ZqRRG8j6Xz05WAUjhJ2E7eMHk9b5MQzClchxr1oW/9/BUj+2dN7Dx9aXJEUiAF9I kEFGJ8TboB4BaGLd4K4WjhRF78Ll5DQACvR6+wsE9KLgKn5P8kG72qtMQ/+bQy4j 5W49f1MUdh54SlKRIWgJhHiPvHr3RCHalNCPuJJ7D8Mke2lh+y9Ctou4FKxZU4Dj KQwOSa4iwsSwmHWfV+As+fcgrKeBjRCVZbEh2ClPy/9ExJndkhzUMkUpsDkwV0bV 2U4jI4eveyhXS48PQgtFJ0mCOIQb/CitQXE3YpGxcMRgUOv56MgrHvR7RRneDp4K GSNuzmk3YKmlYCNJRF4Mze8urLmjX47j9FsgmZeDZNyrSnAP9enn14SiKRCXCXT0 QYWfZ3RZr8fD9jgDhgXBKsn11mriIeYhpxDMN3u8SpuG/dFpLA9oeLMllWbh0IPQ XLHZoQRoQ03hBUVPpkeXPfsYOY8lLc5foNBwy8ZxMUyrbB7MP2qzgjM2ndZKy4pL ovHrj04tlCGsWGW12p8G =RMpz -----END PGP SIGNATURE----- --cMwMn/tF35tO7kHm--