From: Yury Norov <ynorov@caviumnetworks.com>
To: Andreas Schwab <schwab@suse.de>
Cc: <arnd@arndb.de>, <catalin.marinas@arm.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-arch@vger.kernel.org>, <libc-alpha@sourceware.org>,
<schwidefsky@de.ibm.com>, <heiko.carstens@de.ibm.com>,
<pinskia@gmail.com>, <broonie@kernel.org>,
<joseph@codesourcery.com>,
<christoph.muellner@theobroma-systems.com>,
<bamvor.zhangjian@huawei.com>, <szabolcs.nagy@arm.com>,
<klimov.linux@gmail.com>, <Nathan_Lynch@mentor.com>,
<agraf@suse.de>, <Prasun.Kapoor@caviumnetworks.com>,
<kilobyte@angband.pl>, <geert@linux-m68k.org>,
<philipp.tomsich@theobroma-systems.com>,
<manuel.montezelo@gmail.com>, <linyongting@huawei.com>,
<maxim.kuvyrkov@linaro.org>, <davem@davemloft.net>
Subject: Re: [PATCH 01/19] compat ABI: use non-compat openat and open_by_handle_at variants
Date: Mon, 15 Aug 2016 14:31:00 -0000 [thread overview]
Message-ID: <20160815143028.GA7193@yury-N73SV> (raw)
In-Reply-To: <mvmwplbkr8l.fsf@hawking.suse.de>
On Mon, Jun 27, 2016 at 09:47:38AM +0200, Andreas Schwab wrote:
> Yury Norov <ynorov@caviumnetworks.com> writes:
>
> > The only difference is that non-compat version forces O_LARGEFILE,
> > and it should be the default behaviour for all architectures, as
> > we don't support 32-bit off_t. The only exception is tile32, that
> > continues with compat version of syscalls.
> >
> > Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
> > Acked-by: Chris Metcalf <cmetcalf@ezchip.com> [for tile]
> > ---
> > arch/tile/kernel/compat.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/tile/kernel/compat.c b/arch/tile/kernel/compat.c
> > index 4912084..489ae19 100644
> > --- a/arch/tile/kernel/compat.c
> > +++ b/arch/tile/kernel/compat.c
> > @@ -94,6 +94,9 @@ COMPAT_SYSCALL_DEFINE5(llseek, unsigned int, fd, unsigned int, offset_high,
> > #define compat_sys_readahead sys32_readahead
> > #define sys_llseek compat_sys_llseek
> >
> > +#define sys_openat compat_sys_openat
> > +#define sys_open_by_handle_at compat_sys_open_by_handle_at
> > +
> > /* Call the assembly trampolines where necessary. */
> > #define compat_sys_rt_sigreturn _compat_sys_rt_sigreturn
> > #define sys_clone _sys_clone
>
> This is a no-op. Did you mean to add this? Without that the testsuite
> of tar fails on ILP32.
The change you suggest below is what I originally sent at the end of
December, but that chunk was lost after one of numerous rebases probably.
http://lkml.iu.edu/hypermail/linux/kernel/1512.3/00510.html
IIRC, the only difference between this couple of syscalls and their
compat versions is that non-compat syscalls set O_LARGEFILE depending
on (BITS_PER_LONG != 32). Next patch of this series introduces
ARCH_32BIT_OFF_T config option to force O_LARGEFILE for 64-bit arches,
and all new 32-bit arches, as ARCH_32BIT_OFF_T is enabled for existing
32-bit arches explicitly.
O_LARGEFILE is controlled like this:
-#define force_o_largefile() (BITS_PER_LONG != 32)
+#define force_o_largefile() (!IS_ENABLED(CONFIG_ARCH_32BIT_OFF_T))
So if I restore original patch, everything will work. But my question
is: if ARCH_32BIT_OFF_T disables O_LARGEFILE for tile32 anyway, what
for we redirect native syscall handlers to compat ones? They are
looking identical...
If my understanding is correct, we can drop the change in
arch/tile/kernel/compat.c and join this patch with next one in this
series.
Chris, Arnd?
>
> diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h
> index a26415b..4dcc38d 100644
> --- a/include/uapi/asm-generic/unistd.h
> +++ b/include/uapi/asm-generic/unistd.h
> @@ -178,7 +178,7 @@ __SYSCALL(__NR_fchownat, sys_fchownat)
> #define __NR_fchown 55
> __SYSCALL(__NR_fchown, sys_fchown)
> #define __NR_openat 56
> -__SC_COMP(__NR_openat, sys_openat, compat_sys_openat)
> +__SYSCALL(__NR_openat, sys_openat)
> #define __NR_close 57
> __SYSCALL(__NR_close, sys_close)
> #define __NR_vhangup 58
> @@ -676,8 +676,7 @@ __SYSCALL(__NR_fanotify_mark, sys_fanotify_mark)
> #define __NR_name_to_handle_at 264
> __SYSCALL(__NR_name_to_handle_at, sys_name_to_handle_at)
> #define __NR_open_by_handle_at 265
> -__SC_COMP(__NR_open_by_handle_at, sys_open_by_handle_at, \
> - compat_sys_open_by_handle_at)
> +__SYSCALL(__NR_open_by_handle_at, sys_open_by_handle_at)
> #define __NR_clock_adjtime 266
> __SC_COMP(__NR_clock_adjtime, sys_clock_adjtime, compat_sys_clock_adjtime)
> #define __NR_syncfs 267
> --
> 2.9.0
>
>
> Andreas.
>
> --
> Andreas Schwab, SUSE Labs, schwab@suse.de
> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
> "And now for something completely different."
next prev parent reply other threads:[~2016-08-15 14:31 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 23:54 [RFC nowrap: PATCH v7 00/19] ILP32 for ARM64 Yury Norov
2016-06-17 23:54 ` [PATCH 01/19] compat ABI: use non-compat openat and open_by_handle_at variants Yury Norov
2016-06-27 7:47 ` Andreas Schwab
2016-08-15 14:31 ` Yury Norov [this message]
2016-08-25 15:54 ` Arnd Bergmann
2016-08-29 8:44 ` Yury Norov
2016-06-17 23:55 ` [PATCH 07/19] thread: move thread bits accessors to separated file Yury Norov
2016-06-17 23:55 ` [PATCH 12/19] arm64: ptrace: handle ptrace_request differently for aarch32 and ilp32 Yury Norov
[not found] ` <5770B041.3040509@huawei.com>
2016-06-27 5:39 ` [PATCH] ilp32: fix {GET,SET}SIGMASK request for ptrace Yury Norov
2016-08-13 14:52 ` Yury Norov
2016-06-17 23:55 ` [PATCH 10/19] arm64: introduce binfmt_elf32.c Yury Norov
2016-06-17 23:55 ` [PATCH 04/19] arm64: ensure the kernel is compiled for LP64 Yury Norov
2016-06-17 23:55 ` [PATCH 02/19] 32-bit ABI: introduce ARCH_32BIT_OFF_T config option Yury Norov
2016-06-17 23:55 ` [PATCH 05/19] arm64: rename COMPAT to AARCH32_EL0 in Kconfig Yury Norov
2016-08-11 7:36 ` Zhangjian (Bamvor)
2016-08-11 8:54 ` Arnd Bergmann
[not found] ` <20160811145000.GB18366@e104818-lin.cambridge.arm.com>
2016-08-11 15:18 ` Arnd Bergmann
[not found] ` <20160811163003.GD18366@e104818-lin.cambridge.arm.com>
2016-08-11 20:30 ` Arnd Bergmann
[not found] ` <20160812143612.GH12939@e104818-lin.cambridge.arm.com>
2016-08-13 15:17 ` Yury Norov
2016-06-17 23:55 ` [PATCH 06/19] arm64:uapi: set __BITS_PER_LONG correctly for ILP32 and LP64 Yury Norov
2016-06-17 23:56 ` [PATCH 18/19] arm64:ilp32: add vdso-ilp32 and use for signal return Yury Norov
2016-06-20 14:54 ` Andreas Schwab
2016-08-13 14:54 ` Yury Norov
2016-06-17 23:56 ` [PATCH 11/19] arm64: ilp32: introduce binfmt_ilp32.c Yury Norov
2016-06-17 23:56 ` [PATCH 19/19] arm64:ilp32: add ARM64_ILP32 to Kconfig Yury Norov
2016-06-17 23:56 ` [PATCH 14/19] arm64: ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Yury Norov
2016-06-17 23:56 ` [PATCH 03/19] arm64: ilp32: add documentation on the ILP32 ABI for ARM64 Yury Norov
2016-06-17 23:56 ` [PATCH 17/19] arm64: ilp32: introduce ilp32-specific handlers for sigframe and ucontext Yury Norov
2016-06-17 23:56 ` [PATCH 13/19] arm64: ilp32: share aarch32 syscall handlers Yury Norov
2016-06-17 23:56 ` [PATCH 09/19] arm64: ilp32: add is_ilp32_compat_{task,thread} and TIF_32BIT_AARCH64 Yury Norov
2016-06-17 23:56 ` [PATCH 16/19] arm64: signal32: move ilp32 and aarch32 common code to separated file Yury Norov
2016-06-17 23:56 ` [PATCH 08/19] arm64: introduce is_a32_task and is_a32_thread (for AArch32 compat) Yury Norov
2016-06-21 10:24 ` Zhangjian (Bamvor)
2016-06-21 11:35 ` Andreas Schwab
2016-06-21 15:48 ` Arnd Bergmann
2016-06-17 23:56 ` [PATCH 15/19] arm64: signal: share lp64 signal routines to ilp32 Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160815143028.GA7193@yury-N73SV \
--to=ynorov@caviumnetworks.com \
--cc=Nathan_Lynch@mentor.com \
--cc=Prasun.Kapoor@caviumnetworks.com \
--cc=agraf@suse.de \
--cc=arnd@arndb.de \
--cc=bamvor.zhangjian@huawei.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=christoph.muellner@theobroma-systems.com \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=heiko.carstens@de.ibm.com \
--cc=joseph@codesourcery.com \
--cc=kilobyte@angband.pl \
--cc=klimov.linux@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linyongting@huawei.com \
--cc=manuel.montezelo@gmail.com \
--cc=maxim.kuvyrkov@linaro.org \
--cc=philipp.tomsich@theobroma-systems.com \
--cc=pinskia@gmail.com \
--cc=schwab@suse.de \
--cc=schwidefsky@de.ibm.com \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).