From: Yury Norov <ynorov@caviumnetworks.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH 0/4] Linux fallocate, posix_fallocate, and posix_fadvise consolidation
Date: Mon, 22 Aug 2016 14:31:00 -0000 [thread overview]
Message-ID: <20160822143132.GA15745@yury-N73SV> (raw)
In-Reply-To: <1471617709-16267-1-git-send-email-adhemerval.zanella@linaro.org>
Hi,
I tested it on my aarch64/ilp32, and found no regressions. Thank you
for complete consolidation.
Yury.
Tested-by: Yury Norov <ynorov@caviumnetworks.com> (aarch64/ilp32)
On Fri, Aug 19, 2016 at 11:41:45AM -0300, Adhemerval Zanella wrote:
> This is a follow up patch from my previous one to consolidate Linux
> implementation over architectures. As before, the general idea is to
> remove the port proliferation of specific implementation and use a common
> one plus arch-specific define to different behaviors. It also align
> with my work on trying to remove the sysdep-cancel.h requiriment to
> simplify the long-standing cancellation issue.
>
> For x32 this patch serie requires my previous {INLINE,INTERNAL}_SYSCALL
> macro fix [1], although it is still possible to push them by still
> enabling x32 to generate such syscall through syscalls.list.
>
> [1] https://sourceware.org/ml/libc-alpha/2016-08/msg00443.html
>
> Adhemerval Zanella (4):
> Add INTERNAL_SYSCALL_CALL
> Consolidate fallocate{64} implementations
> Consolidate posix_fallocate{64} implementations
> Consolidate posix_fadvise implementations
>
> ChangeLog | 92 +++++++++++++++++
> io/Makefile | 2 +-
> io/tst-posix_fallocate-common.c | 92 +++++++++++++++++
> io/tst-posix_fallocate.c | 107 ++++---------------
> io/tst-posix_fallocate64.c | 44 ++++++++
> posix/Makefile | 3 +-
> posix/tst-posix_fadvise-common.c | 113 +++++++++++++++++++++
> posix/tst-posix_fadvise.c | 25 +++++
> posix/tst-posix_fadvise64.c | 44 ++++++++
> sysdeps/unix/sysdep.h | 42 +++++++-
> sysdeps/unix/sysv/linux/Makefile | 3 +-
> sysdeps/unix/sysv/linux/arm/kernel-features.h | 7 ++
> sysdeps/unix/sysv/linux/arm/posix_fadvise64.c | 38 -------
> sysdeps/unix/sysv/linux/fallocate.c | 11 +-
> sysdeps/unix/sysv/linux/fallocate64.c | 14 +--
> .../sysv/linux/generic/wordsize-32/posix_fadvise.c | 37 -------
> sysdeps/unix/sysv/linux/i386/posix_fadvise64.S | 92 -----------------
> .../unix/sysv/linux/mips/mips32/posix_fadvise.c | 41 --------
> .../unix/sysv/linux/mips/mips32/posix_fadvise64.c | 60 -----------
> .../unix/sysv/linux/mips/mips64/n32/fallocate.c | 33 ------
> .../unix/sysv/linux/mips/mips64/n32/fallocate64.c | 33 ------
> .../sysv/linux/mips/mips64/n32/posix_fadvise.c | 37 -------
> .../sysv/linux/mips/mips64/n32/posix_fadvise64.c | 55 ----------
> .../sysv/linux/mips/mips64/n32/posix_fallocate.c | 37 -------
> .../sysv/linux/mips/mips64/n32/posix_fallocate64.c | 38 -------
> .../unix/sysv/linux/mips/mips64/n64/fallocate.c | 1 -
> .../unix/sysv/linux/mips/mips64/n64/fallocate64.c | 1 -
> .../sysv/linux/mips/mips64/n64/posix_fadvise.c | 50 ---------
> .../sysv/linux/mips/mips64/n64/posix_fadvise64.c | 28 ++++-
> .../sysv/linux/mips/mips64/n64/posix_fallocate.c | 1 -
> .../sysv/linux/mips/mips64/n64/posix_fallocate64.c | 1 -
> sysdeps/unix/sysv/linux/posix_fadvise.c | 45 +++++---
> sysdeps/unix/sysv/linux/posix_fadvise64.c | 52 +++++++---
> sysdeps/unix/sysv/linux/posix_fallocate.c | 6 +-
> sysdeps/unix/sysv/linux/posix_fallocate64.c | 8 +-
> sysdeps/unix/sysv/linux/powerpc/kernel-features.h | 5 +
> .../sysv/linux/powerpc/powerpc32/posix_fadvise.c | 39 -------
> .../sysv/linux/powerpc/powerpc32/posix_fadvise64.c | 55 ----------
> sysdeps/unix/sysv/linux/tile/kernel-features.h | 1 +
> sysdeps/unix/sysv/linux/tst-fallocate-common.c | 88 ++++++++++++++++
> sysdeps/unix/sysv/linux/tst-fallocate.c | 25 +++++
> sysdeps/unix/sysv/linux/tst-fallocate64.c | 54 ++++++++++
> sysdeps/unix/sysv/linux/wordsize-64/fallocate.c | 34 -------
> sysdeps/unix/sysv/linux/wordsize-64/fallocate64.c | 1 -
> .../unix/sysv/linux/wordsize-64/posix_fadvise.c | 40 --------
> .../unix/sysv/linux/wordsize-64/posix_fadvise64.c | 1 -
> .../unix/sysv/linux/wordsize-64/posix_fallocate.c | 46 ---------
> .../sysv/linux/wordsize-64/posix_fallocate64.c | 1 -
> sysdeps/unix/sysv/linux/x86_64/x32/syscalls.list | 2 -
> 49 files changed, 764 insertions(+), 921 deletions(-)
> create mode 100644 io/tst-posix_fallocate-common.c
> create mode 100644 io/tst-posix_fallocate64.c
> create mode 100644 posix/tst-posix_fadvise-common.c
> create mode 100644 posix/tst-posix_fadvise.c
> create mode 100644 posix/tst-posix_fadvise64.c
> delete mode 100644 sysdeps/unix/sysv/linux/arm/posix_fadvise64.c
> delete mode 100644 sysdeps/unix/sysv/linux/generic/wordsize-32/posix_fadvise.c
> delete mode 100644 sysdeps/unix/sysv/linux/i386/posix_fadvise64.S
> delete mode 100644 sysdeps/unix/sysv/linux/mips/mips32/posix_fadvise.c
> delete mode 100644 sysdeps/unix/sysv/linux/mips/mips32/posix_fadvise64.c
> delete mode 100644 sysdeps/unix/sysv/linux/mips/mips64/n32/fallocate.c
> delete mode 100644 sysdeps/unix/sysv/linux/mips/mips64/n32/fallocate64.c
> delete mode 100644 sysdeps/unix/sysv/linux/mips/mips64/n32/posix_fadvise.c
> delete mode 100644 sysdeps/unix/sysv/linux/mips/mips64/n32/posix_fadvise64.c
> delete mode 100644 sysdeps/unix/sysv/linux/mips/mips64/n32/posix_fallocate.c
> delete mode 100644 sysdeps/unix/sysv/linux/mips/mips64/n32/posix_fallocate64.c
> delete mode 100644 sysdeps/unix/sysv/linux/mips/mips64/n64/fallocate.c
> delete mode 100644 sysdeps/unix/sysv/linux/mips/mips64/n64/fallocate64.c
> delete mode 100644 sysdeps/unix/sysv/linux/mips/mips64/n64/posix_fadvise.c
> delete mode 100644 sysdeps/unix/sysv/linux/mips/mips64/n64/posix_fallocate.c
> delete mode 100644 sysdeps/unix/sysv/linux/mips/mips64/n64/posix_fallocate64.c
> delete mode 100644 sysdeps/unix/sysv/linux/powerpc/powerpc32/posix_fadvise.c
> delete mode 100644 sysdeps/unix/sysv/linux/powerpc/powerpc32/posix_fadvise64.c
> create mode 100644 sysdeps/unix/sysv/linux/tst-fallocate-common.c
> create mode 100644 sysdeps/unix/sysv/linux/tst-fallocate.c
> create mode 100644 sysdeps/unix/sysv/linux/tst-fallocate64.c
> delete mode 100644 sysdeps/unix/sysv/linux/wordsize-64/fallocate.c
> delete mode 100644 sysdeps/unix/sysv/linux/wordsize-64/fallocate64.c
> delete mode 100644 sysdeps/unix/sysv/linux/wordsize-64/posix_fadvise.c
> delete mode 100644 sysdeps/unix/sysv/linux/wordsize-64/posix_fadvise64.c
> delete mode 100644 sysdeps/unix/sysv/linux/wordsize-64/posix_fallocate.c
> delete mode 100644 sysdeps/unix/sysv/linux/wordsize-64/posix_fallocate64.c
>
> --
> 2.7.4
prev parent reply other threads:[~2016-08-22 14:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 14:42 Adhemerval Zanella
2016-08-19 14:42 ` [PATCH 2/4] Consolidate fallocate{64} implementations Adhemerval Zanella
2016-08-22 15:14 ` Yury Norov
2016-08-23 19:21 ` Adhemerval Zanella
2016-08-19 14:42 ` [PATCH 4/4] Consolidate posix_fadvise implementations Adhemerval Zanella
2016-08-22 15:08 ` Yury Norov
2016-08-23 19:29 ` Adhemerval Zanella
2016-08-23 20:00 ` Yury Norov
2016-08-24 14:29 ` Adhemerval Zanella
2016-08-24 3:53 ` Yury Norov
2016-08-24 14:40 ` Adhemerval Zanella
2016-09-25 10:42 ` Yury Norov
2016-09-26 19:44 ` Adhemerval Zanella
2016-08-19 14:42 ` [PATCH 1/4] Add INTERNAL_SYSCALL_CALL Adhemerval Zanella
2016-08-22 15:28 ` Yury Norov
2016-08-23 19:16 ` Adhemerval Zanella
2016-08-23 19:20 ` Yury Norov
2016-08-19 14:42 ` [PATCH 3/4] Consolidate posix_fallocate{64} implementations Adhemerval Zanella
2016-08-22 14:35 ` Yury Norov
2016-08-23 19:22 ` Adhemerval Zanella
2016-08-22 14:31 ` Yury Norov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160822143132.GA15745@yury-N73SV \
--to=ynorov@caviumnetworks.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).