From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112763 invoked by alias); 23 Aug 2016 19:20:55 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 112730 invoked by uid 89); 23 Aug 2016 19:20:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*r:104.47.33, H*r:sk:mail-bn X-HELO: NAM01-BN3-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@caviumnetworks.com; Date: Tue, 23 Aug 2016 19:20:00 -0000 From: Yury Norov To: Adhemerval Zanella CC: Subject: Re: [PATCH 1/4] Add INTERNAL_SYSCALL_CALL Message-ID: <20160823192030.GB20135@yury-N73SV> References: <1471617709-16267-1-git-send-email-adhemerval.zanella@linaro.org> <1471617709-16267-2-git-send-email-adhemerval.zanella@linaro.org> <20160822152826.GE15745@yury-N73SV> <72b566be-074f-9575-46fe-df8f04fcedb7@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <72b566be-074f-9575-46fe-df8f04fcedb7@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-ClientProxiedBy: AM4PR02CA0011.eurprd02.prod.outlook.com (10.165.239.149) To SN1PR07MB2256.namprd07.prod.outlook.com (10.164.47.150) X-MS-Office365-Filtering-Correlation-Id: 369a952e-21e1-4c96-10ef-08d3cb8a91ac X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2256;2:6nmbNf3r0OpFJE6lHxwvrj3dkwIqbiAB1wyeknCgmdzWD5uYLZ2qZJ6gYTmnL5B+Mq9Q0czGWvv4/atpngtnlfCmk+de4joEnccfOPXsGWJEmoyuWytyffxxpvbLayoSFi/2S0f91i+5yOvC+GCE9NgTDHiwZ6OjFR8AjKEfp+xMxBetu5HMgWb5bryyncTo;3:OuXigv5OYfqviZyMUWoCNJjew+zVjLQ9Q5ZC2KAoX0CUYJpfnzpGUdvxWvAuHSYJOLMntARv1wlpnPgQkdmjJQM4+QkhtYbScLryTD2jdHR1a9zjw8VR+A9mNWHdudJj;25:cuhVi0teaAdkKHNnrw89jN8EynKzZJXn1/uZSHni56hvaIFekhgtncDo34qKouzozNZRiE95NycGJWw1JFHbZfgJ55AkUxh0ub/U44V3gKB/2NWXafnPO7bDvual4yAIBQlwk+DOiKDkkLLP/19Pqat/L5Fr6OT8iLukxCl/Rqe/8gEcFXDfs6m7yVb4nbm+9lwLivLXv8pCkgYrr52Ne+n25DoE23AfF5Y8QFPwXZupLEYAZGoI0HbCH75cOChGHkOvHHbb71OAe+wj4wq80HQbZqpQeSsreuCleA0l5LQaYQ4bjJ4X9vZAwuLuBwRiWmtwDQJrUIxeuRoZW6yl21hgb/IeYJdUiKKjzq6gV7PSxbKGxPQVZyWD30h9s/4SPpv0NFYdrg9a+MmyHZanypoJHlzOBG919zxBX0xglm4= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR07MB2256; X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2256;31:/q4XTM4Q4Ir/AGPTfTwt8Ong41sH7HEgQnDAR33+nJ474JbvswEbVkIY+Z1F3uzzTSrkDlaUfO1erNWy9egkefpPfFiSQYbqGPP//xw8o0zDaHPwnemh7opBpaRC+ScPzf3/bS0hNMEW/6QAA/svB8L+6mLnhhqFKszT8EwRvy5AbeKwLxBC0gYjJT2xKJkJpBktqfo3zZbVS4iPLVBCLTiU1jByGBDTxt94w3mQhY8=;20:sSPE0gnZedLFkwHErwZrnfvrFIZ4LWQf59kEWI3yLNjcfshf0hWK6HCi+8qeKsU4Ysw02Iu8sIGl/77vV+4aysSxVMbQgvT3bW0fhxlzPJcVWBfoPEl5NliYIlyRytpbCzna5muBY8mgFfpMg+ACfwBiy389O9yuhjvY8iCLobh6UbqQ1CXS9cwtWBoIRF9bGKVHK1DXuYTHIMBWc+WjRyjXNwpvgkuSXmdxamG8pfzcJnRsLmN2m1xxKtfX3a7lCpFZwGApnl/ntzAYThA7D8PgrKb/F/CivFE2qJDjeLc5kz82d3mLuSYBRXNfVdQpcE/QfrtRD507MA7+cxDZkP2MypEpkK7tP8JdwQxZJ2U2pX9kowGN3xYawotn+x4x8ZTz9bO/I/um5NTMwoeM0HtuV0ng2SdwkvkutImBpvMQGp4jBemVbW/CtjrULV7vNOxCKOX3zHd6OkmqzWmRgfcTMgPbY7nEq6IhhDATNr2ILhLnRU9tgU+33fUmBVzRU3LBThkcyaIQiRIzUbgZnl5Wuv+OrQCeeafbioxSuRxLtGawmFseD7aGJxJq3Vc8JBwfzeTRWuQvZu/tHDJP0+oFdJbdQ5lrV5cJVu3EFEA= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:SN1PR07MB2256;BCL:0;PCL:0;RULEID:;SRVR:SN1PR07MB2256; X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2256;4:4KmYDEA9alRBXq1dScg/55DoF5mFjUv7EWGGB006v6a7rz85H4OcMBn1EuSxH4S1S9r/QbsLtzhuofTrUUaOf1bDq0aZHIKRjD9XIdFOTTB/8aJhEayBcOP/9z0u6zfJN4SHH05e17jUBaGfOu0UJpGjjrqpRy9mtfU26o9ZGKe2qHhS240p0mksLkY3sXFyPXTgiftJ3SCkGGlev035iA3zg/k1QuHf9Z7U3Sz8UQH1YRJAIt87dlsPh753Pt4B0AmjAXR83mM/9zyByNgirZKPpWcZ7RgaBMBEFZ36PyKW8aHfTloABDrK3w59ClDcZjCpeeVihnEIfDrrIzADIyH93K16AapVk/gLtlEMX+7oSEcZlgjqcBBsVjVQQLOW X-Forefront-PRVS: 004395A01C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(189002)(24454002)(199003)(47776003)(586003)(3846002)(66066001)(2906002)(83506001)(4326007)(23726003)(6116002)(1076002)(68736007)(33716001)(101416001)(77096005)(2950100001)(97756001)(5660300001)(93886004)(76176999)(42186005)(33656002)(110136002)(97736004)(189998001)(54356999)(106356001)(4001350100001)(105586002)(50986999)(76506005)(46406003)(81156014)(9686002)(305945005)(81166006)(7736002)(8676002)(50466002)(92566002)(7846002)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR07MB2256;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: caviumnetworks.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN1PR07MB2256;23:8GPOniDeHQlknw9HN99wfetnIzSR5TKzt9uGsNz/D?= =?us-ascii?Q?XsEcKzE+lsm1t2GTISWo1bkC084M+Ijmgz4C1bB7dE2lh6cKYTOwKqeJMm+J?= =?us-ascii?Q?8+R0uK4ntH8wg8UNLdgmEIqlXqxXVl9qlxHWYurA6msckC0cWPlMBTMqA6d2?= =?us-ascii?Q?1THt9P2X0LtC8vJzPPNhNNXksRQZXbPkrKg6CxEosFRS97mKfHq8Wuk1aVqH?= =?us-ascii?Q?Bi6hkJDQTudFEVxbcNsAI2Gq24/w4BF93Ev+17vNjP6cx0yKntNlXXQaTkUN?= =?us-ascii?Q?iyMkGlIpMvEXNB4vJICPhL/mX+xI1paZrw4sMVyt4VUXQWp4SSGtUpJgLqVb?= =?us-ascii?Q?I5HSVB92NMWtJKKyfHRZ6UDKzaIjaKKKS+FbgE9yt1W9JALb//nljlqNk7av?= =?us-ascii?Q?jWLhZAmKX3ZtXRAkawhSpvaOrMRIWlRypXmhP/Zz//iNXNf04oSkJ5aJZrFo?= =?us-ascii?Q?mfv/GUQV6P791QT8PNKfdzpHK3ZcadJ9nceAxTtwsVvjN0BzMzIjFxagRpZJ?= =?us-ascii?Q?rERINWpdH5DD19M2zOnMxKrWJGoWWKX/57UHiabU2XlGZy95qOZtFIdNLTV4?= =?us-ascii?Q?1r83dR5w7MeeD9wc7a/uLYTGLfLJ+P14tUtNEgjxHvXedwsVO7dFnGs0biQi?= =?us-ascii?Q?MR8f/RSQUiixJB+Y0mVf6a0PV5miAbv6o+rEhugfGWMgOsMqZo5TkbvBKZVq?= =?us-ascii?Q?qhS9Cn4dQUlcOU9fUgahHuJa7WCL+kr9PnlNopk7uX1a5RrPeOn/Zu5A6+TN?= =?us-ascii?Q?Ru9a7ZxmJ5GI5EsenZuZIjjTWH3S38WVNI7yanTBjXd7wayKTAgnLi+QU8jC?= =?us-ascii?Q?PzECfyXPWu0A+nrUnvM7fAA+JwQlhaQcSkRQC6GKsWXgB+FCfj/PD7ZwGnGZ?= =?us-ascii?Q?FztpPPDIB5BNg43yWK1eSnEZCKuIUK/e1WGI9y+oW9BVhmcJKoj4MSe2wm/d?= =?us-ascii?Q?c6DgEGLkRVVZdHBoPcLdSUuVxR6A++77MHVSlX9BW4F1AAis+Sf8fnYdEFdN?= =?us-ascii?Q?tLIoSLMQF7YX3DZ5bDGrBDx5m4HNOPN0iSa00rUW4C2oEBKdOm8p2VTWBYki?= =?us-ascii?Q?zKg6kAKGJCiOHFTAAJOG7QI3AdSPIoNT91fGTZBi/QsHgjI6Vk7elymd886d?= =?us-ascii?Q?fW7JMmd0feS3jG8GaMO3ogjyyTv03R10Fyq1Fork6MXVZslT+vW+jEkksjMy?= =?us-ascii?Q?3VFp7HTspFlNmA=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2256;6:y2RTDkPrJzET7j16OSQRbd1EubjOQMwJXxQTBkwXxn5/w/9fEGLg7inuZcXVbA4AzL19KirUBDg666QvXhcmNXwv6spXj3q0oPPB9r4s4dwXlhTmmDfAM5LAi069mACaHtONPWZ3OJ5XMvk/URVWRPSTI7Z/hcn1gS4vbYUobOrKIJInG+D9Odr+iEiXpvsA/THPkLDhiMPaEHdtqd9X41zoq7IfpeRj5kgVh7PcMJdtiraicXxtkBPCfK50CZr7oEHPZQzfpjvdN1lhuKPD0wHJeeCTDgB2NanqXd4T2dU=;5:453XZyEBz54riC9icyss1RLkFRBJmgHbH79xSA9Ioi7X1Jau8dTb2cbEs7auXPhQFbtA3GsBK//E85hmOlvG3I2OY2YzjSvDr+rfYp3FL2AwGhnv4EgfUlLdiwEvkYwLPOS+BlkArRHgfvD9E/ryog==;24:sjoAM/8Eard0TtmwYqCCqPC2rSalqJE50jrFgVKY01YBawXGB3ZM/9Zhonz0/Wj0YZ0pTAeuTSvQvEA7cVRnBde8h/tCcBVLiZID7NUASFA=;7:yVyJItXuAYYUr7r36VUk4TEZI0Lx83X3thrFcciWxDVLKzVUyM7S/AuYWrerVK8xlZV3JT6kogGcXnXDDa2+7gu0vVFLbB0GuSsDZG3oBPPnjx1Keko6QtGR5Fuf5LKQaX+QU5M6egREKYQ1FAjEoDFFUmhRLzUewplMEXzRI7mgVdXdou9JBJsT9PK0MWl7CKsMR7hSFgfiQGvhaUOB/YhefVfUOTt5f9aMTXYn9IFfHfW1BvySivMFtKrIm9CE SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2016 19:20:39.5557 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR07MB2256 X-SW-Source: 2016-08/txt/msg00733.txt.bz2 On Tue, Aug 23, 2016 at 04:15:55PM -0300, Adhemerval Zanella wrote: > Thanks for review, comments below. > > On 22/08/2016 12:28, Yury Norov wrote: > >> --- > >> sysdeps/unix/sysdep.h | 42 +++++++++++++++++++++++++++++++++++++++--- > >> 2 files changed, 56 insertions(+), 3 deletions(-) > >> > >> + > >> +#define __INTERNAL_SYSCALL_NARGS_X(a,b,c,d,e,f,g,h,n,...) n > > > > Missed whitespaces after commas? > > > > Ack. > > >> +#define __INTERNAL_SYSCALL_NARGS(...) \ > >> + __INTERNAL_SYSCALL_NARGS_X (__VA_ARGS__,7,6,5,4,3,2,1,0,) > > > > Same > > > > Ack. > > >> +#define __INTERNAL_SYSCALL_CONCAT_X(a,b) a##b > > > > Same > > > > Ack. > > >> +#define __INTERNAL_SYSCALL_CONCAT(a,b) __SYSCALL_CONCAT_X (a, b) > >> +#define __INTERNAL_SYSCALL_DISP(b,err,...) \ > >> + __INTERNAL_SYSCALL_CONCAT (b,__SYSCALL_NARGS(__VA_ARGS__))(err,__VA_ARGS__) > > > > Missed whitespaces after commas and before opening braces? > > > > Ack. > > >> + > >> +/* Issue a syscall defined by syscall number plus any other argument required. > >> + It is similar to INLINE_SYSCALL macro, but without the need to pass the > > > > Did you mean INTERNAL_SYSCALL macro? > > > > Yes, I will fix it. > > >> + expected argument number as second parameter. */ > >> +#define INTERNAL_SYSCALL_CALL(nr, err, ...) \ > >> + __INTERNAL_SYSCALL_DISP (__INTERNAL_SYSCALL, nr, err, __VA_ARGS__) > >> + > >> #define __SYSCALL0(name) \ > >> INLINE_SYSCALL (name, 0) > >> #define __SYSCALL1(name, a1) \ > >> @@ -49,17 +80,22 @@ > >> #define __SYSCALL_DISP(b,...) \ > >> __SYSCALL_CONCAT (b,__SYSCALL_NARGS(__VA_ARGS__))(__VA_ARGS__) > >> > >> -#define __SYSCALL_CALL(...) __SYSCALL_DISP (__SYSCALL, __VA_ARGS__) > >> +/* Issue a syscall defined by syscall number plus any other argument required. > >> + Any error will be handled using arch defined macros and errno will be se > >> + accordingly. > >> + It is similar to INLINE_SYSCALL macro, but without the need to pass the > >> + expected argument number as second parameter. */ > >> +#define INLINE_SYSCALL_CALL(...) __SYSCALL_DISP (__SYSCALL, __VA_ARGS__) > > > > Missed whitespaces after commas and before opening braces? > > For INLINE_SYSCALL_DEFINITION you mean? I do not think so, 'indent' also > shows no change for this specific snippet. I missed. It was about __SYSCALL_DISP(), though you didn't touch it...