From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69486 invoked by alias); 3 Sep 2016 14:38:53 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 69471 invoked by uid 89); 3 Sep 2016 14:38:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: NAM01-SN1-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@caviumnetworks.com; Date: Sat, 03 Sep 2016 14:38:00 -0000 From: Yury Norov To: Joseph Myers CC: , Subject: Re: [10/12] Add femode_t functions: s390 Message-ID: <20160903143832.GB29995@yury-N73SV> References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-ClientProxiedBy: AM2PR03CA0003.eurprd03.prod.outlook.com (10.160.207.13) To CY1PR07MB2247.namprd07.prod.outlook.com (10.164.112.149) X-MS-Office365-Filtering-Correlation-Id: f77deb78-c0d1-4491-51dd-08d3d407ff49 X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2247;2:F3EqsJEB0+pZ3RGS+vfuqH5WAyEJH7cU4XGNNYwxqEJkbC2vhdIlDAW8pDCk0N6ay1WItfx2SPH9iw4dZHGRPPC8vKCKHDjdruZOtdtXMjTjckcfbav4gTROXX+Gla+gJbsWLbE/5h5TQMXoBebhHHnEEebisH3AuK2uLir7Eo0fhv3gb0k1OuAlV0RrCMYL;3:D/DwLoMBLNAXAjYRUCzYe2K4zEcJI0Gd8GefOC1GSrN7IZYm+AStF0nwLTDz/EXPD68D1mPE9oSWhbWa5V3Uk9rQ/k1NCbfCu5HNq1FhVdJgYRWiF555isNeVWy7IY3n;25:bwSoXUtdD3Ew5uo3zRfRnstHHth12l9whGlJ6N21NNq87DcPNG39uyS1dA7RCXRFyo+LcQnn+GtDG0gMRF9aPxp6E004+lArjdccLul2w6tn3ASsAF/r6w6J+pvV3SLcMDJTSoQF4wAphX8cc/8lWMLOGK7iVilxL57KdnwBdLVPPK43pj9EI8vr8YpAzwwFgxAaKvL1jzJBTtFhmuvUGZb5GTc309BmwmhySU0HbZYXoSigz+plcqPMrUZIRGt7YaGLXKh6FP4q9Eh96QzjlcaCCH3hTG67OytVBizOvkC4dgvTW/Ys8W4mvqvAgWtpcHYsggGOuwGQvjK6u+Q00Z+u9P+Q1/BVRXXxlLc/+P3rsJlrmram5PsBlXlp32C842WS9gBRXCN51ffH1NURdJxz3YKGdoGircwGooNyMDM= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2247; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2247;31:57lq+f+Omgxmi+VqLrh+MBE1aI1Qa6WdIE+8x+6Q9eITk/jBYuEg/W3vF7zwHip02GN7DXM1RQxzK+XCT5WD6xIQSKutMgtWHUZm55tQHQLBYe84XR30VcQeSAvUIN5AbwuV9XfDiZXCcPSE9Z2FNYL59BMls63MjlMakz6ipmCYA84NR1pK4CYWIphSQSMtAjyHhSH5fElWkYgE+FUtJJQLugGa5+l8aIlL+jcm040=;20:MG9PKJsGZ8Qh+GTkUiL7sFpcAZyOiJHQJO906OKZZ9Ppg6es/hUlE/CI9XIWVlSVHP2jJzXlUgFwJbg30KW8qQePT22cnwLXWlDBeCd4YqsUhtdU6/0ozGkWXDpIxCmoCrE1SILz7KZ3szzTUg0MFFkg4xGQ70SgR0SbZBTTgs/DMR6eC5lghzsj/UqMBhUYz0cyYSgvUSVWW/+z0FR/2m06rG7gy4tyO0oxNBJAdSWwB+q47rcakVLIZetz/k6hnTs7a3Zroy1eNjZa13HDbwAUti5/Lm4S6sk3EbfweRFBmKIr9lhMABbOQ+jWPM6TJ6dzP8518wnKBugMVMVWVOtIL3Ijrt/5agyLIk3NXWxEex5Ts1Eb9TDvVlyt9VmiWSDn3l2rFgzSAMiHUXFT7z/moh10d4FeuCfp1SvJ2NcSZ2yVqQAK6TznAzUbl2ANJACTOm4B++LADAsLGsNwdZiQMjxNt5iYcrI+Srri3rzAXm9JLwZ/R4bz+iefhYUjBUUyMY+dTMF6hDJqwayxamcgG812DbKfT7yVvvryQwYMUclyl+gjSdDoukgmt3lxWrWeXSgqt0L2RJvc0+AvXFPXnd8bxXGOuSmlfgrnOk4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(250305191791016)(22074186197030); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:CY1PR07MB2247;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2247; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2247;4:ZKkOKwS1FboROxL22o4j5Gd18GoJzvrNOzG0HgngFLN9fl2a8lhufwdWQSAWxgBF8Fe+842Rwr6NKwrllbC2zt4GgVbRvKfy2R6y8PThCxJ7L4iwzGTplXxL/moys9ha5xJj+yyI0+kIr+neKlXllleuZqwxPkz0j4UA/CnNoddDBa3PbxrcNkXwWwjeCY8HgUFyIKdoBCNDNe7PRo3JnObwYX0LuYCKvxnmhxtyxH201vWQHLECLppJE1ti4PZawVyZvO/1xae/KMXboB4cGJAE83/9+i7mLVFs0ydJsTeirmU37rCOE0PV+NQsmx7lyLPXJQ9ccWONxZUwcG6x6X8iz8VKd1G3mSuAzk+ZDiuEM1m+XYL0lEh5IYRnUoC2xwuytD48Pg6BKk2iP4xYvcaCxyO9M9bLJUau+uc2nCmzR4jzTofOkg/AFJ4LMcsnHhMWbkqjAeXr/i0Du+o5WQ== X-Forefront-PRVS: 00540983E2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(199003)(189002)(24454002)(23726003)(2906002)(92566002)(9686002)(83506001)(97756001)(3846002)(81166006)(6116002)(106356001)(42186005)(586003)(15975445007)(105586002)(19580395003)(110136002)(189998001)(66066001)(4001350100001)(4326007)(8676002)(7736002)(81156014)(1076002)(50986999)(7846002)(68736007)(101416001)(54356999)(19580405001)(76176999)(46406003)(2950100001)(50466002)(305945005)(77096005)(76506005)(47776003)(33716001)(33656002)(5660300001)(97736004)(18370500001)(2004002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR07MB2247;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: caviumnetworks.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR07MB2247;23:TDPZpj26m0SgPgVyJ4pPJPyS3B6Y72qEO9SVoCPN0?= =?us-ascii?Q?ghHrHHJOOqr1+fVE5oMhnlY7pv/l5l7HQWbR3qAmyerl/T4ExIS6dbkYzA4t?= =?us-ascii?Q?CkDFa3k204YFgbUVV/GSf4fgRhOgRQdSL9t+mX04GpNj4MCegVui4/uhhhBB?= =?us-ascii?Q?ZsOukVp5rwZnXRTzQo1CVO2w60lREewmbHAWXSgHA7evXVvYoCHEns11WWdb?= =?us-ascii?Q?pWpcWouqr+N6ZG/xGD9mRL3BZ2N+9aXAghiW9sl28TlnRSNzGIIDOfA/yuBs?= =?us-ascii?Q?uGR+X6WztlVL+mZRaLT+XqLelKXj7DJ1a4QLDfpGAM6fpCcSLX52FGb9A49C?= =?us-ascii?Q?Y4+qILl3T2aI6WW2GZDS8/AHTRtqldYA9vv8yaiVOILVfDHHffJStal4AKjk?= =?us-ascii?Q?p+q3hOwJ24Obr3KVYef9uH2f0XrRdeLd7XSNVR4O5eWz38EpLGBTisf/dsvU?= =?us-ascii?Q?XLdNlA4M/5q5yTrACJ292rpOn/AS1kMabB3Y5uRSnGXL1w7yfvti6bF2v/Uk?= =?us-ascii?Q?np5hyJOtWJbTIsXL7ALU7IdI9aRUahDy7gdb44D9jzhuAGQ0WZkytv1mm1ay?= =?us-ascii?Q?odRMJ20jH0FcCiR6eX8oojRmfZqzZNHUXBlIsxBmzX9HA6hwCBEFFb5AFRjq?= =?us-ascii?Q?Q5FffGuHXaLvWNIy49kkytDO8pgvIFlbJNjxMW+tPK1UxukNTb8cdKUDk68V?= =?us-ascii?Q?EqkUB3Nnme+++HkUeEcK1rbBZ1yZNnyWAZ4rGgjuWC1lz2RyVg24byOtz3ok?= =?us-ascii?Q?7fUA8DvzX1xcF8ykqgZJwKiso9F0GVHXhURKbaEKxS9e8THJsBwDyoM8xbpq?= =?us-ascii?Q?fY6riBYxMrEwSMVhir2pJQFnLe4TBwUIi8wkgBdeJpDQ2SDtgwvH8vaYaANU?= =?us-ascii?Q?W7GDku47DQ3wD3OvxxonKIIngUOcly36MSpfkGZgF9QBGmSjxd/LYEPejKZK?= =?us-ascii?Q?tLB91uPh21MjTXJfwTDdn/DuaTIWTnH0A/tBrL1L8cJOOtqmDukD1Rp4V/2H?= =?us-ascii?Q?nrK4r+yb72Hy5VLgV+CrNuxIcW2l2jLsDsLUuU6LlEhy36Q/Z0K532XR08Fw?= =?us-ascii?Q?j8PSpRk0t526oUBzfCTNq9KN7m9h8ys88zy09qZUwRye4RJy3ERiXUIJgIpF?= =?us-ascii?Q?Xouxf3zEtMPxnah0SecPYRkEAgCF0Mqhig7ItP7iOovp+p1mfkWQcBBGblku?= =?us-ascii?Q?hKe4z3Jk1d382MFD9BmdyKFxUeu/TN6/ZAE7UoUO3Ip6NeY0hDznwYWsd9Lb?= =?us-ascii?Q?Vr5gYgPtvZQk/oM92ZWZKsujDtICxNhVzalb+Bn?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2247;6:HvJV/CVXEamQmOu9Z5+g3pKViIzlAxSB4Pknwg/xFaT3yaNogvx4z1zbgZ1P1xYMDI/FxKeaoeGzGVfivZpWdg6UjuhyizQrzakk0o4o8j3ucy1t3CfafJvyLlk6agxRnQUf7Zp2UFP4vRlxrkkabYPkA75uJ+fgFgRHNfySiN+jR4OcceI91GlRNsCD0TKJG1cEOxXtQduZLSjZQ3s9Vwo1Zac8zvOWvYAdQ9HL/CwaB6WzNcB2jP7UDrtQqYwPX/BIgHjT1kRgMrd7HOD9YW+ZHTOC/ZEz9j25gwcYCv8=;5:lo665cp2zhE/jd152+PmQYSSsd/rnOPg/WEdfyD7TvMFK5xyv11F8PxhF53yAf/OjD4COIm/D43M9RgI6ia2MnivBgIv8T7Y3rEOp0al4wuLKqDbhsf/feKG5xJU9eJXXovY5VvBMkXvKplfmtqfRg==;24:NCHaySwLIk8iRFc4Pd9KeudclwaQ2JBR/j63MZlAOt5W4CifYCdymX7Qloa9pKtc1KdoNqekeznOEG4gptQEU6fyEKiu1y6LslPDlwvb1bc=;7:Cc9g6XAwK0SD66HpjK3LLsNEwCRQlvxmrEZVbTo+POBjYVSCvmO7fTxL59m5oCuKvIIgUl42kh48C1pCPgNF6Loa1x+k+RKYgKBfTuoxEN6ticCjWCWsnxWMSC5lFqMB73bQE8EJ04EVUwSLEEMVDsN2+i9Xd+G8w22a7H8ZOyb7XZleJhtM6Wn2HtrZA3MdnTMKuiR5zibnUswOL1tD4QI6MUOcTpnN8oXMXMxDXjnOcSdtbCi3DwTiwCaEP1sZ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2016 14:38:39.8263 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2247 X-SW-Source: 2016-09/txt/msg00054.txt.bz2 On Fri, Sep 02, 2016 at 09:58:37PM +0000, Joseph Myers wrote: [...] > diff --git a/sysdeps/s390/fpu/fesetmode.c b/sysdeps/s390/fpu/fesetmode.c > new file mode 100644 > index 0000000..8feb9b6 > --- /dev/null > +++ b/sysdeps/s390/fpu/fesetmode.c > @@ -0,0 +1,38 @@ > +/* Install given floating-point control modes. S/390 version. > + Copyright (C) 2016 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#include > +#include > +#include > + > +#define FPC_STATUS (FPC_FLAGS_MASK | FPC_DXC_MASK) > + > +int > +fesetmode (const femode_t *modep) > +{ > + fpu_control_t fpc; > + > + _FPU_GETCW (fpc); > + if (modep == FE_DFL_ENV) > + fpc = (fpc & FPC_STATUS) | _FPU_DEFAULT; > + else > + fpc = (fpc & FPC_STATUS) | (*modep & ~FPC_STATUS); You do fpc = (fpc & FPC_STATUS) in both branches of condition. So you can save few instruction if move this snippet upper, and also increase readability. Not sure how much gcc-s390 is smart, maybe it can do it for you, but readability is still in case. > + _FPU_SETCW (fpc); > + > + return 0; > +} > > -- > Joseph S. Myers > joseph@codesourcery.com