From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28350 invoked by alias); 22 Sep 2016 14:25:07 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 28070 invoked by uid 89); 22 Sep 2016 14:25:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=1523, 1521, H*RU:sk:NAM03-C, H*RU:sk:mail-co X-HELO: NAM03-CO1-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@caviumnetworks.com; Date: Thu, 22 Sep 2016 14:25:00 -0000 From: Yury Norov To: Adhemerval Zanella CC: Subject: Re: [PATCH 4/4] Consolidate Linux truncate implementations Message-ID: <20160922142442.GA5914@yury-N73SV> References: <1474383714-15187-1-git-send-email-adhemerval.zanella@linaro.org> <1474383714-15187-5-git-send-email-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1474383714-15187-5-git-send-email-adhemerval.zanella@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-ClientProxiedBy: AM4PR02CA0029.eurprd02.prod.outlook.com (10.165.239.167) To SN1PR07MB2254.namprd07.prod.outlook.com (10.164.47.148) X-MS-Office365-Filtering-Correlation-Id: 3f6660df-5845-4913-a1b0-08d3e2f43849 X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2254;2:RXInHbf9UGz0Ywg9A0+nH5ERRElK775s0wZi7P6BhBM5OxwdV4VikXdIoIPs6O/XFCBFT/Z9254PGQq6+W8FP4yCnEWde/PwCTRop+Jv18cocfSMCABPgLEa58nbr7Z6oLRHcGF1b4Qlz9qiKvpZvW0JCugyHSsyPmV5ei3+VGqilQsKuBAal1YQpv20Do1G;3:TgesgQuD+Cn5H6tSTg9HBN45FwNGF/CbxSJJnMfQesKUpEJMKo3YGlkTpjcrxNc4z+szu/KBeyRqXVhbTutrEXIvhgaNLqbKaX6eRd0Ls40eJJKtnn5t69B8avEMay8i X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR07MB2254; X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2254;25:Mly+VCrX8J83guIXA5noTf4KhE7iphFA5VRYUQImqTbSu5ObxTTjLXP4ibsEdaZUXHPawvzoe+fkvY9jeCHUIOhOcjDzjEl/d+A6/ngI7efA1dfPsJU+4e74duTJQTZMtssI8HWXdMVLz2kNzMXLoCDRiR/FPdvg9EvmnIk0BNrG7A0WCu0BzNPWu0ogJ0bMQKlO41djk1rAVnHUb5j78zXk5UhJCo8wPqXf4aofVrvw6RlA0+xcVeUxEaixPCjsTOLFkG7QOSruWkaoJCtzXeJ9JKUKtx3v28pQ8a0+fhGHCpOwpHgJ3vsGZDkGC2uaT+TO1qLYZeoWPRmcVUxfz9gAvF6WJW6f1mw4DlhXnorrRgtJFJPDCHINgQtgB5xS+40wro5o4PsCmScyEtnuKfCoGYgqgvD3o/IylWsu014N50oSnVsnchTFJg3iuk/DxsKjZFJoSmeBW5o39Vygqp4VGOYaq9aRO0AMQbuuFlZ3G2x85DtBOunm9D35cuWHAzejtk+7HYGat/yDIBLah1XGl17Aq3i31uGZWPyF1hi0mmUZP2Cvf4/qVUpflEhHR4w3opJSwOS02wZiKY3vffahfkBt79OiUc3uvqNyyOEKRfr5XsbnYE7sJkSnDwrSIIkiPqhJ5QV3Hx358yYA5OzsyJhS+mlmn7E5/k89PYpVjGSgqN35Tl4mCJMEfMESo2SC4iaYuZV+bCd+hYkKlyd0VCIud9ZdUTIl5udEu3Ao46MhiScLQnmoUm1nBw+vxzkvbr3ZkxCiZhOYE4Om9JTiiyMyhLo5MPKdri9keal5a0d3ognAIsVHRc8qzo52rjC6X+jzi/xPARlUZMpo4g== X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2254;31:yfyFfODJEFyG8TNDNH/J7+Vf0K4TnTW3NJSHioTXnNTlD9p8qHu/fcnN9L3VVKfemsF+psBFkE6BSuGk/Vt0dY6wMGX2/ALaTWY4xAQecwePyEkDlxJU/i1HQyy4AbAu0iO15RQ0+kLmcPvYqL0G4ZRRaG3yelTnfV/pL/3DP1i0t8hb5iKCS78a3kyr8Ews1rAPIBXaleKJcZDmWVW0j/WMA92QqQ/IGU4kqpdUN1U=;20:fH1KpmHlSBWrlDRvUTZoSwG1imYQPCHlMS5LrbQADFzOzIEGhkuDP30ZR3WCT4m6PgaFHoSyUpfhKhGNs1uhSAFR77LoCcVn9b5g4m35Wb85hc4Tzl6ABmd84XCRDWT6spljkjUPQpurWFTPI8zKhvCwVfQpR19NGk9jsCaxD4iE67EAKEB3JP0nPYSoUeixrJbyX37aBPWNPAKO1YyncHKIHkbZbaZKSQ81wGMOCr9fnWhHEWPFp0ySZGJJ6BSX6KFJsw6489AhGEa4QAP3kgLrUlvCyArYtA4ncBzmnFGmtz94AqiW+L7oX52J1cr4SD+EdeufxEy5nhtkmFQykFNouvvEriuaYELUotyefU6jv8KIoStWXEWXMk+wD9jt0nMso5PnQU1KByDkc0CstSiI7HRQnmKeoBo+07w2mu1kPL3en0UpE1BrRwnSvGdaw3ZqHiiC7tAEctraplwAVeGB6rNSRSQSskwfUlJmDdabMZlXPeVuQpnShGZnR+wS/Gwq206MjuBfM1bakYkd1tLb2TC/Nd1KHonSUqKn3Jp5sLC58KS+/UVmKUv3K3DVwYANE+J2faX/agU/3FFDyUjCRsGm+IEQoQlNWtk5Tj4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(250305191791016)(22074186197030); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:SN1PR07MB2254;BCL:0;PCL:0;RULEID:;SRVR:SN1PR07MB2254; X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2254;4:WyYVk44bFy6lX8v5N7F2nYCHJ9lQNCOfM/+Z7sbbfH6LPC5zCeHFHBjBsG1kq1DcrxSyaG6Twr3sVMC+4eOtW4hLIod3VUvSd6/G7V3TXE6q/5QUWowKq1OAf9FUZLny6JqztogSCi3A2g5xWBhkLj4NXX5s88jNVC8GXKvKBdPH4m4G/SI6g3xJosN34u7H+lpolPfObNzTF5OgxKcF+4/TcwRdvyu20905mHAV5zbUZ82OEc51y0goTIkXCjRJfWoYVzyog+T5eN+Nq+qv/qt85hzcZk2P4Yi1I51kci3R66rKTWHUiHLz1+KqbObr7TQKKwQn+FiwK2DG28Wu4WOcS8jIj/fPBHZMFryLxyN14ltwkZj54DDA93cDn6/UbMQrV5U9t7N4R9tTjRsNKj3zHQOttq31Ry1QsLDyQjY+5ZinGg+FAe8SnX4EomTdwGtEwGTqfsLwUbJiJeAs4A== X-Forefront-PRVS: 0073BFEF03 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(24454002)(199003)(189002)(305945005)(7846002)(7736002)(97756001)(33656002)(42186005)(81166006)(81156014)(76506005)(8676002)(105586002)(106356001)(586003)(33716001)(2906002)(46406003)(3846002)(6116002)(23726003)(1076002)(4001350100001)(4326007)(50466002)(189998001)(97736004)(19580395003)(2950100001)(15975445007)(92566002)(77096005)(9686002)(68736007)(47776003)(83506001)(66066001)(101416001)(54356999)(76176999)(5660300001)(110136003)(50986999)(18370500001)(2004002);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR07MB2254;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: caviumnetworks.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN1PR07MB2254;23:xMG3OAfRleQ3krS1cZFkk5YmEupufLKFA0NFjsbOm?= =?us-ascii?Q?/KdP4PhIw8xiPWbxhdPN9G0JNWbcRo9xK9kesrPFuY9wmRXX/ky77fSGf/3V?= =?us-ascii?Q?kUQ/oB9pdWDcIeV7mRC7RzSD3oiPHnpN+EdTKzDWi0QkfTryPtlYIc6ARZUh?= =?us-ascii?Q?8AFGB3kykA5Y9285AJmqXDxpvaRkIEdZPB8RroM3LLLWg67dzE24aqLAtVr5?= =?us-ascii?Q?TGA1uq4GHAHji24akrR0HJDcX2qQJCGSGP0vPHsIWneicawhsZ6QuWJXhFS4?= =?us-ascii?Q?Ulr7AwtpLKozfbn4jkESHZy11TSkRMpnlbQzOeVbPXHoeYX0OY/w0FHggjgO?= =?us-ascii?Q?3KtvqiCezwIya/trjYYNYJgFhjChTeAxV9fABBtze2ZI+2KMh7Fvy9TL8JlY?= =?us-ascii?Q?FvXValOLc2zaCWXuF27BDlTGJXRixIFTN7uvtRu4vN7W/UY5HvN/l62nwXZa?= =?us-ascii?Q?DyQ+vFvcLTIAd1bR/arGAuIlhwT4OMekzdyS3zsanC3t6Chh3zRlp12Kv8iN?= =?us-ascii?Q?YzmQC0w35hZvq/gN4D/7/Lg9d5B30LuK7AohtG+czNnL/VGWcm/PI9uoO+qZ?= =?us-ascii?Q?kV/yW7aXy0Z3+8UynJYOfOmLiWnEU7HQgvvJI8JwQW3xhVPwZRlnF8A8qWOT?= =?us-ascii?Q?3lBn2/U5D4BT4tpzcWv0DNxD1LyTD8g6Ebaga6QAo3d/jRGIsPVC/npK8Tom?= =?us-ascii?Q?+C/WLaOBDaFZUGg5vtg2pIiZRgGAtD2DbVbwMtvp5I8rXtCQY4ygTXEFxdbL?= =?us-ascii?Q?at8Y6g8LENsdJWJClg+DgN7TfzJtjI1MnoUBUqjn3JmJNE6qT/WN6RhPGOak?= =?us-ascii?Q?+mr6Q+zFExV1UA2pdc1fSuROSk9MZukPxkxBwJwK55FKj1WpJr4JLFAnw6BQ?= =?us-ascii?Q?xGA4XsaI6Yn/3mDn6bnLAAy0w3Hvz7V+ug0k8YetJ7kW3AjRv4jjGujR/DbY?= =?us-ascii?Q?QzuuXY8knTC3mL+5CE6zwQDv1gVs7ZrfL1uIcbELXE/3XJ+SKb06QNwpePQw?= =?us-ascii?Q?nJndCAg/SEiwLNR3rlU/kUfERRt32MBIkJcA6V+HZSOo1sZozmg5+1wJK7nM?= =?us-ascii?Q?IKlKqnHlEGsl93F4KbtFMsm04R9zg7ntRaesDufb4eimYdX36s80F9wPNYw8?= =?us-ascii?Q?DzBFhyIj4vvPUGHQ5tESuXrSRshmX1JnKLZ47jM6cAHUTs4viUHtKylDJhmW?= =?us-ascii?Q?TWKlW46y8vUMg8PbE8cRh4aZpU/KdsALQE4VE839NJlM0/QfDJBxHr5UekYU?= =?us-ascii?Q?UMwkE0I5RMuenk4oA4=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2254;6:UOfndYZ7YPiEP1pdg87wj+1Lzbf1gLFvbfgBkvRXHyQP6XuW2bIYRHY7PlzXsKXlEQe69kn1RsqTI/xAG+eSlpQbtC+HrkzsrL8qgQM+LIDSt3MiA8GPVufxshpEh/LyX5zLidegVfEig666Jp6DYtH0i5UR8TVpV2JysJKMCTQ6fqJnWk8HzI75adavnBqf/H+/rmw3qkoDfDnA/ycKuATBvf81N68lGNYVJTP85/g8jXPBNydIUVQOfTJkwlHVXRuFkSbEzO/DNhEY/50ZT3TJ5dIHkTDr0RrtExvsyRU=;5:BvmXhU70sQ4vZgFUxgHQ3GtmSzxj0nJNF6rbpVADjExzg+QnT8H/UyEDKkcg7EDwlFhn7b2yo8FTDJsUctRPQfVfDSPjVh07vfoESQtMFJsamIjQVFHArKa4uOAdYtLpQXboqd+Wapnn4i2Bp0k+6g==;24:dXv16KRqZHp67rqRbwYRy+LL9yzus09Gj2vzzseDMWZVsK6fZlOykflUWh0LftNkNJKQS7Nsm4IiHdb2is7wiYUYchjXUwsNF8Fli591D/o=;7:hG39OysHvb1SHlcA2nvNNCla3/Cfv8IT678bTzrP5qDoeF3dqvE8LpRE7eXRsPfjnPGq9L3lyCX/bx+aGOJPJ5lQrw+g0FBU2ztCtt2Bs8nuKTbPPs0MOw8/P+29bch0w0b3MtL+wYbqmijEkgvoZWQO9udiHGMy/FFFtgHf/v22U6fFFiJUSr7A2brH9A+BfchiQsS9VfYeJULISjgnGyxrU14AzJpeyXw+v3UYJ2mS4KlI6+SMRAB29bhl/yxcboUzYfGJzBKyaiQa+r/BOImvPpb5N2kWLTQvZWPwQzqZo9tg+I19ytJMCdksHBFZ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2016 14:24:52.9215 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR07MB2254 X-SW-Source: 2016-09/txt/msg00457.txt.bz2 On Tue, Sep 20, 2016 at 12:01:54PM -0300, Adhemerval Zanella wrote: > diff --git a/sysdeps/unix/sysv/linux/truncate.c b/sysdeps/unix/sysv/linux/truncate.c > new file mode 100644 > index 0000000..9e71288 > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/truncate.c > @@ -0,0 +1,35 @@ > +/* Copyright (C) 2016 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library. If not, see > + . */ > + > +#include > +#include > +#include > + > +#ifndef __OFF_T_MATCHES_OFF64_T > +/* Truncate PATH to LENGTH bytes. */ > +int > +__truncate (const char *path, off_t length) > +{ > +# ifndef __NR_truncate > + return INLINE_SYSCALL_CALL (truncate64, path, > + __ALIGNMENT_ARG SYSCALL_LL (length)); > +# else > + return INLINE_SYSCALL_CALL (truncate, path, length); > +# endif > +} > +weak_alias (__truncate, truncate) > +#endif > diff --git a/sysdeps/unix/sysv/linux/truncate64.c b/sysdeps/unix/sysv/linux/truncate64.c > index 92a6bc4..0d70da7 100644 > --- a/sysdeps/unix/sysv/linux/truncate64.c > +++ b/sysdeps/unix/sysv/linux/truncate64.c > @@ -15,21 +15,23 @@ > License along with the GNU C Library; if not, see > . */ > > -#include > -#include > -#include > #include > - > #include > -#include > +#include > > -/* Truncate the file referenced by FD to LENGTH bytes. */ > +#ifndef __NR_truncate64 > +# define __NR_truncate64 __NR_truncate > +#endif > + > +/* Truncate PATH to LENGTH bytes. */ > int > -truncate64 (const char *path, off64_t length) > +__truncate64 (const char *path, off64_t length) > { > - unsigned int low = length & 0xffffffff; > - unsigned int high = length >> 32; > - int result = INLINE_SYSCALL (truncate64, 3, path, > - __LONG_LONG_PAIR (high, low)); > - return result; > + return INLINE_SYSCALL_CALL (truncate64, path, > + __ALIGNMENT_ARG SYSCALL_LL64 (length)); > } > +weak_alias (__truncate64, truncate64) > + > +#ifdef __OFF_T_MATCHES_OFF64_T > +weak_alias (__truncate64, truncate); > +#endif It seems you forgot weak_alias (__truncate64, __truncate);