From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94780 invoked by alias); 22 Sep 2016 15:52:02 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 94756 invoked by uid 89); 22 Sep 2016 15:52:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1739, yury, Yury X-HELO: NAM01-SN1-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@caviumnetworks.com; Date: Thu, 22 Sep 2016 15:52:00 -0000 From: Yury Norov To: Adhemerval Zanella CC: Subject: Re: [PATCH 4/4] Consolidate Linux truncate implementations Message-ID: <20160922155131.GA20294@yury-N73SV> References: <1474383714-15187-1-git-send-email-adhemerval.zanella@linaro.org> <1474383714-15187-5-git-send-email-adhemerval.zanella@linaro.org> <20160922142442.GA5914@yury-N73SV> <330498bd-5430-94eb-f033-73236269be13@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <330498bd-5430-94eb-f033-73236269be13@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-ClientProxiedBy: VI1PR0901CA0060.eurprd09.prod.outlook.com (10.167.203.156) To CY1PR07MB2248.namprd07.prod.outlook.com (10.164.112.150) X-MS-Office365-Filtering-Correlation-Id: 8f9f1b5e-5b57-4f3a-7cb7-08d3e3005d41 X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2248;2:J68LUKk2nfHSKlJcr6UhqpRGJ6zPLUGigT4euSZxFWRnudeUdO6szBDJRN/tuqL2IW3j/HpV6531tewhwzdya19/v4rKyDgIeWXzrnr9sr4/N8qD1BW4TqJvHiZRJIpuKoS1azi1yD/EdYHecFFg8/XqBXyswDlhmrA3tQ6nRW7F9jlwDwYY5lYGlXWXv36M;3:81veF83MO5eu4+0uHxCSS8XS8vFdDzRUyDwd9j3nb2Vi6n/K3X4kCOC+/ece3aNhl3OcjQeVVbIM/aBreDk6v3OTwXUPueqwPJNnSXvP5fTn9G+fv6yeMcfbP1nM4rll X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2248; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2248;25:jTa6GfCYgU4wTxx8idIgNiugLO7qriG6Xv3vX9X4QVJvrFoldoQEBRGq88DeiLr3E+tdimOMDceTnQDgDTZzMnyCOO7Iepq4uKCZ7fQnN3QLYJOU4D1D6/kqAoHHFfK2WY8vWtNlWQ08bfzbT5GuY75kHs1k093HrjRJdGXoaNE+pyW1zk75t2X9qNJ5GXjthnaMNn7yhXxk/GcowOqem7u1J+BkJydv9kThPt9tmxN3i33s7XXXesBGfLvNaTh9rg/KF5bSGw9hiP1z/vu5MlHAudsfOzvLYYjRKtM+p1MhvFdsOSVhBsreUcEm3+fFOC5DvYGFkkjAEYyncpi11zeTWUZ+1kRU1s9VC72Gj7eUP1kWv5FeT9FN9ELNIfHlCG8QLmdgx/rC5GVXzxJfMsmvmiiDKh06kuHkjZFe7BmZyE5LzIYPrD9s9xDzz5mpWSgKdvEvSRreVsRNU06OmjdWT3Z7vGGE7NB/1X8HIhsAo0klwh4cieQLaxjD9OtU7VDQ919ClPq9oG33wE476VBON7O4OCjatHgWWsn/gFMK2FhvO05mDPe84hESVdVY5jQlIBI6i75SYFgjGP8E/9RcCt/Q7Z/LIGpDI36ZA1t4xOezqRghAy9DjNWvrXBhcV1WTcEn9mvnSIROWODf65JDnuDdqJ18yd5Sb98IFlbORKJ63UD4YYeINF2rt9QybP4AWoIDlAJN6Epqtcdc76gWRw2Y2wRXTACsEh1xN0pbx0K3UnzCRvUcZURhyuattNuOg+BjMVdpzBMpyjFRNw== X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2248;31:qTVhV05K39NJ2ixVENo5gIV+eNlbZJA9kGYRUd442yYUHtF9TgV1C7gtDsr6N0+uC4XscoOoypeJFN1+AlGfb8OHmEckoIxqrpm9qyC/tBvEnmoYR8e8v8UBKOSOTnEVf3jqZvwbpf6ur2RijOFdu+lc+br36grbwKr8+3g0W1CppklaWvhKxIunJQniWM5D+7V8la8lOk3s39khujMoxa66zmnjRbt96odZTjIg3oQ=;20:qYw1UE+WcmnUiiK6ttetlibqnHO7iJjPwq1B7D0ePdb/OFsE9PI0Dl637yyz5WEKZAAJo+onfKPjqa/Vwxikz6xqXBOmJGYg6YXToTh1Jcq9eCTtg0qd7EDwbvzfycAx0aI7Ch0QgVkiKglRxZZhOMiHNtFZXQdfF/juxOhUeZ9aW7F1j6SwnyorGerEVPEatf2S+M1JWtKHXY08RaxYJeNluUa4ad+dv0Jm5bkb+ng66v0vmIRASxKccNBNqE738Ov6Wm5pCzkSzwhdGbnjCxvFElidTg9sv0fPltHshebu0yEVGraL6drGdZZrde+/AJ7FSIHcPIql5QW9wlpGNht1w/mXG1Hc9qrMGVKDJqsBuDaAHE1uv8pwl7ofB8ieIvBKIgdZCNJ+Q1Lza5p61XO7q2dCiLyZ33rDRLChO6NsIlyPVS8qVnE4fi8gbJaFprP3CybXWQAe9P3kMgAZLK2f+/thzibc/oelsfVmYsCbK31zWj4HnTOBUtPpalMtRqPVnehImaVc4FIPvHzdJoZIjfvHKEO1pKvWl+7N7wO58hMxbEK5JXucYOtAoOKL82q9ptInakmPFxF6ndgl+65rqQudFRLxYvkYrOYNicQ= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:CY1PR07MB2248;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2248; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2248;4:sG71xYChy9PnOyIKANBv0q7DcPSqH+ey/qUvq531Gpkm/IeMjBU+uPJCp5AX8kTiIL2es5yck6mPpcDERAJkBbpshmFUas77IF5ZCPPjt/gXgnlP3vnRr8xucztEMueFyyK0uhY8SS7pU2eT4ej1g62z22b7fhl/nQ0Zh+2U6dUQLrgH9h1Dl4Dn/iqsfXCvRFCuscMvmJQE3rJqO+uE9nLCRxreYKkmd3Fdg1V/jsXbtXH3rNLMf/TLAEPvID+Kq6slgEVFOc3mHRDw6Bg2961RlkC4BNV0UwRqZEP8aBgA0HInKKquAknWH9pv8p5QXKUkHbzCqNjbp0j1J45VpTzAx5Ys29wD4ACDQvLYohBeCkG4Ksbqd6zmuFh5uR5iwuZ6/q/FRC80N9igAQ2ejA== X-Forefront-PRVS: 0073BFEF03 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(979002)(6009001)(6069001)(7916002)(24454002)(199003)(189002)(50986999)(97756001)(33656002)(93886004)(4001350100001)(5660300001)(97736004)(19580395003)(189998001)(66066001)(68736007)(47776003)(77096005)(83506001)(46406003)(33716001)(110136003)(92566002)(2950100001)(50466002)(76506005)(42186005)(106356001)(4326007)(81156014)(81166006)(8676002)(2906002)(54356999)(105586002)(76176999)(9686002)(305945005)(7736002)(7846002)(3846002)(101416001)(6116002)(586003)(23726003)(1076002)(18370500001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR07MB2248;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: caviumnetworks.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR07MB2248;23:tW+MFmwUdI6oa+Qx49ytkQXw7ziPmm2utscuEn5ZL?= =?us-ascii?Q?g4mbix+HbrkBn7pr3fySisSTpIpCYJSbf4Gyw4gwQt6Pu7f2JVQ5M1jYtF2I?= =?us-ascii?Q?EjEN1EduuddbC78O1zFBMt/wLFZralWlmU4A96cHKzWnNWuL0o//dLrXWXbP?= =?us-ascii?Q?CvqUA97KHtvnJvPCJnkIqAthbc6+U0/JbEvIPO8U2ujBcTv0YJHh0fvfyIUt?= =?us-ascii?Q?9V7hQ9XALGk0RsUz02lJPV9Cbe0iE2aadxAYH+vPYAGqW4GC25gVWQ/mxrKm?= =?us-ascii?Q?0rcWSVkFLx5FR9NUYmQkqBjnF9rOwk9OQySc6p/9xfmbhnrWaOA5eY0BGZ0j?= =?us-ascii?Q?LM78OToFcgJoHFvv3FdHmBw860nbtMKZraNyxGwxGDoMbZs4RhlSJhPO6mXN?= =?us-ascii?Q?lCDjs3HD1ICwmwrV686O/bUwRM3L8x8YXE1NrGTndMhMkG+zjPlUo08pygH7?= =?us-ascii?Q?FZsjHzchZrtYOZSs2ZhTOEDqQDsJSKccKmFFyBOP0d6AYxOoKBMuqwmfI3Lw?= =?us-ascii?Q?hwMm39KjvBltw7mJoM4gxGY3RBPzLYqpCwQpSA5pNcbP6AceK+SUNj4GzuWS?= =?us-ascii?Q?6dFt/DvZgWdxs8b3dwRGf/rvRCKkLsYGxvfFxfRIOoulG2B/qSfimVFom5Qw?= =?us-ascii?Q?mDoIqVOUmyS+6K4jPICOSSipUU7LxqQrGE/jOViY8hkRV80S7LOpdisgeo6c?= =?us-ascii?Q?6NBokz2qMLuXMThq526xMhS/HWa78IEwYECr5kAN5PLAMG65yCVmRyKHGyvk?= =?us-ascii?Q?0G3Rri60ZC7Egv5Y0/6gappxLGAyPDPZww5FCwiFsOPduL3W7VUA1eiFEMUV?= =?us-ascii?Q?yY0beYbshFH5SAPheWaYJkLgFzgbR99zPngGJbdIjKjcJh/fYuC1mJahk4m7?= =?us-ascii?Q?+tGzoRYSoobrAbz1Gc4bQOIktDhbMn5fy1zGtf9bO+hOY6dBsAYYkZtEl1s4?= =?us-ascii?Q?mgsp9MChegNVmyXQTY0DvOB0iT64YCLcu49Cn9WjoXRbtLe0WJOUIwtP1ong?= =?us-ascii?Q?wYUzArqjdNWtXSk8rIeO2Y8yfm69lmq6+ntSmJ+oXo9eXeX/GSkUh6u/gnvh?= =?us-ascii?Q?JXkzr3NntbUvWz1bkCgtG9f3gBpOSDRWrjrnQeq1ymjvsQAkAipA60Jl/hWR?= =?us-ascii?Q?tzT7CL8KmT9Lj5qi4A9pLTHrzPgL3sHvmPHXu/PWar72Vk9g9Sm8YHBLZM6u?= =?us-ascii?Q?l6PJxTdm2WSOkIAqkO/XJmUjHCGNTAuFRuBWj0lUDwiT0a/abBdNWmWpYXcU?= =?us-ascii?Q?tCUm+P4Je+siEWmiNfjeB56JIZllHUAMO7O/oN7DBJTHqjY1CJ/Ov0922bPN?= =?us-ascii?Q?Mwsyco47u+C2zNQdaHDos8=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2248;6:Vq5x3UJ+eXGheQKTjJN/VpkXEKD4rp4xzFO9VWslp8yWG1lNRSzajroHSJcTvuEXWqnjrFqzHGRILMyy5y9TmSTmtvPN2cMW7CYrJ7peB3ACYhOoL+/jq/+yhcXxTGO4jL+fbaX+BMF2LjubuJMNDkWpP4rIjfj7oio1fnAKXD4h9Jh01N7n7om5s6Yvja3m7LdEKH1imLj5qToGTsHN2j1rvjr5yg4q7pCST8emwSrc9wB5bFOKo4arREzefviGF/y9ne0qmw1rIzg5BYJ/+ztm2jhYHIIilGszty34+Gk=;5:nTTZsYNVxGwISsP+qaPeGibKsYm2okt59J6CDr4lyY2NlhF2nN5X4ynkTMIw8nPMHkjmhxW9OmgxntTT1z6Obp5KaAcxNc6jQzvAC73v3WDKf8A7+sRWjkDbGa6gG2qjR9KDDcw1QFFcFvJFQOL0VQ==;24:+Z8qAOqZ+7c8y9GZTM+5a20gTmMlJVvbJg4Pxr8zbwH2PgFHdidx4FbWfFIWCXQDSSiXJtt2o9oDGQ+KvvSedmgucDsSlxTI7PnziXjsiz0=;7:nCQzg5ZXZxUCS9EzGB/ztmpn5/wxCLcoHq5eSCY7VTE87Dd3wigc4y7Gk/kghoPNV2Sq2TRZP+uBT+Bo4XRs0+kDDxET4xiVTyL4mpW+j5IoN4w4OqqJCcgAxeIWv1g4lSFUfc0NBpt4iZK3gzFVluJPeCyPx23o7xroXViARKaH40bfqZGjhhY5+iYwxHQcS5R/Aiys6dkTgz+nIKA7owll9NIK7RqyGgzuiB/vZjR9qCxPFbitl2CBy0Ozz7EGNetcJOqH47rFu46jTo1pT7BPuqj0BLzfzj008Q4hUkfx0mNGYIKDFkSLrakHshi6 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2016 15:51:48.8996 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2248 X-SW-Source: 2016-09/txt/msg00459.txt.bz2 On Thu, Sep 22, 2016 at 11:42:11AM -0300, Adhemerval Zanella wrote: > > > On 22/09/2016 11:24, Yury Norov wrote: > >> +/* Truncate PATH to LENGTH bytes. */ > >> int > >> -truncate64 (const char *path, off64_t length) > >> +__truncate64 (const char *path, off64_t length) > >> { > >> - unsigned int low = length & 0xffffffff; > >> - unsigned int high = length >> 32; > >> - int result = INLINE_SYSCALL (truncate64, 3, path, > >> - __LONG_LONG_PAIR (high, low)); > >> - return result; > >> + return INLINE_SYSCALL_CALL (truncate64, path, > >> + __ALIGNMENT_ARG SYSCALL_LL64 (length)); > >> } > >> +weak_alias (__truncate64, truncate64) > >> + > >> +#ifdef __OFF_T_MATCHES_OFF64_T > >> +weak_alias (__truncate64, truncate); > >> +#endif > > > > It seems you forgot weak_alias (__truncate64, __truncate); > > > > I do not think it requires to add __truncate alias since glibc currently > does have internal calls to truncate. Sorry, I was meaning __ftruncate: /home/yury/work/toolchain/build-glibc-aarch64-thunderx-linux-gnu-mabi-ilp32/libc_pic.os: In function `internal_fallocate': /home/yury/work/toolchain/gits/glibc/io/../sysdeps/posix/posix_fallocate.c:64: undefined reference to `__ftruncate' Truncate looks correct. The fix is like this to me: -- diff --git a/sysdeps/unix/sysv/linux/ftruncate64.c b/sysdeps/unix/sysv/linux/ftruncate64.c index 914ce67..4a00db5 100644 --- a/sysdeps/unix/sysv/linux/ftruncate64.c +++ b/sysdeps/unix/sysv/linux/ftruncate64.c @@ -33,5 +33,6 @@ __ftruncate64 (int fd, off64_t length) weak_alias (__ftruncate64, ftruncate64) #ifdef __OFF_T_MATCHES_OFF64_T +weak_alias (__ftruncate64, __ftruncate) weak_alias (__ftruncate64, ftruncate); #endif