From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49558 invoked by alias); 20 Oct 2016 11:23:57 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 49529 invoked by uid 89); 20 Oct 2016 11:23:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*RU:sk:NAM03-C, H*RU:sk:mail-co, HX-HELO:sk:NAM03-C, Hx-spam-relays-external:sk:NAM03-C X-HELO: NAM03-CO1-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@caviumnetworks.com; Date: Thu, 20 Oct 2016 11:23:00 -0000 From: Yury Norov To: Andreas Schwab CC: , , Subject: Re: [PATCH v2] Linux: consolidate rename() Message-ID: <20161020112331.GA13995@yury-N73SV> References: <1476924756-31448-1-git-send-email-ynorov@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-ClientProxiedBy: AM3PR03CA049.eurprd03.prod.outlook.com (10.141.191.177) To BN4PR07MB2243.namprd07.prod.outlook.com (10.164.63.149) X-MS-Office365-Filtering-Correlation-Id: e8aac72a-e209-4e49-62fd-08d3f8db8bb2 X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2243;2:GlMaERn1DYWD5DoYQAsDhW98xuOtkYlgmWXD+7KLH/zDb6rbL59x/UeOb/9n2hpCJhXtxinkYum5o1Q1L0xecg+cDXAe9U9xVo1KS+E2kGpmMUEbNeV/6ZnD3/1R6InbSrLu4dIvTi88Sr1p4uGqqOK/zCW2jr0BH7pEQdBW3Pstydz4BFOCm1ojZwK+G26cNIntazJ9SlpQPlstdUXE/Q==;3:yrgvzM/ksg0ZLKGOs4hmDkCYnUdlzjFYd4wELeoi8DJ7rsnutfm7gc3owPdZ7ujuMOwcZaJ6+iFEfUfUpYd+/Ujhq+iuLn0RJRTWKO7ZxPYr83D+Zs8ORUIbyMSTvlNvfToy2a8Rl7sZ+KGxB2mgXw==;25:+7HfWU42nWpfFjjCc4vVj0yrcpTmqMUsatm1aTs8zImcmkuwrLc8Agw85MMZFgJOjHP6S6fw5eHN/lhbIl98R9I8QR18gaSqlaO9M6CM7Arh5K+GgUpUqsuDO7PUvwtheMmG/vHlArZp//hfXokVTU7tQ9uIsO1miuxn9StE/R7Urb/yjyrlNp/Edc/gbdBzO9aVHAka7/VDruVSWXJ40RitCjAqQDPUOUyAMWlaIaYoK8ipWDEaNci+nd+0jteJsQOBALbr2sILGONBGeOYwNvoZ2J4qOdO8AU+g3bBYnjj0B+W4HyIhrqzyMGbvPiWOX6Gs+C09X1WMcpu4kuBGDXVRF/WaV29pFeSFvcga50M8A/vtCaP27AlTUMGRVyzQyIG0Y3Us2l23ZAcOpXJhNwAUWcWkrwzkTFLNM2oSd0WAKRHPztuXohDNVIp3QYd X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2243; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2243;31:BuMhjzk+gLvf4Vy13E7qKLqBZLi2MN5PEUGUgy+86kpAj5mUCmj0EmusK77gk8UUcVIdCaP44WIcLxhMOUp3Vog/fnPuvbXICqD9CMq3ilTNy4ocimKqxpXV5cbh+VOw4zVEFUoX0oxdOEtafMgdxbDI98u6tC4MS/EIADyq8pyvMAJUy+65OIsAQH7z4g8gr7Gfbe2TW2T61f9TeouyBW5dZsyhHPdfgQ2/YPXfxMQXRffZJS9y0fYAT5wGEpSl;20:/aEUrGtivjdf4tdpXB0UH47KlFKcE3HnyTL37+Zs3wry6c+6lWsgQJ80lDAzuPNCinR091wLTlvk/ng6opsh1KMEMDTe9EorHzBARQhPkcZyAhQI9SvDveCnpdn6VHCOOAiGPe83+HN1+yXmmv7w6yYt2MCDnPQCgCc8nk3XdmN8UvJwHuIuF/13rkBVBhsdrHFB5jaJGKo7s/q5dUb5dttJmqeH4bC/wuahvB+QahZl/UqWf1fVhWSOC4P+K0XkCbXy0DnYyvdAJCRtOH/pTcGcrmW+Sa7lJFdiKVn4L1p8lw5K70SA4LsS556lUAhKOs/yvhgQ67ADGDAalR8KBekWMcA3s4DQiUjV3PyxqzBO28K0NafL8Vc6Wp9/+47uJItqc+ZDJfVJ6gV8S7ShdMlAbpSvEljpKAkD6li/lcn0kDZDdUxcKw1H4k9G+MxmQxl45f+Ch9eQ870TrwK0/CqhZbVqCVHT5nuyyH8JKZpvPURW0b0WcrCrPf22DUjy9n3tkFjVaf2DWlO32A1JHZwH6GJHe9YeYPiBT/W1euKWcPTcVwKCdOL4FdWhUE3Snhb5JeYrJMz3fGUBuYHHgNUDum723ktwG5M44GGSX4g= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(250305191791016)(22074186197030); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:BN4PR07MB2243;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2243; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2243;4:c1Mif4iVRPZN71/sgAj0qVAk49aGgply3+eGZFSFSTtBKTi8ILfDoVNoN8q+kKhw6gvXIPeJqtLzhPyqmyU26iEeIBOe6dyDjh6bcWumU6iNZKDBYgF2vV/EPMeym80BVC8n4PnckZNXkLtXVE/ahp+42bjw4+hPgnKGeaYoHI2GaMmFH4xP0ZrrdxJ2RUbD5IgWdGIaANr3UQb+RYh+CScqsjATQiz5+x4z/ZuOqL/EwDrvX4Xca/7cblOWS4CFDJrejHmWyad9Eie1LP0hgq8lhit/jVooKqf3gAbo80uzefgGMtFh1uWx0vQhG2Ws6n8aGrezz2R8GIFv37YWnkK6yqggH5z70dpoWx59SzFgRegiifVwO1J3rcSODpTblawOjB4+RnEQgogflNt2pCHtNiglhDQa+EQixfAMc9W7wW1qB3x6+vloVr2PE8Ru2h//3DBJeR1HqNEbswjIC0ct/2l1y/VztlJD7caNLfo= X-Forefront-PRVS: 01018CB5B3 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(979002)(6009001)(6069001)(7916002)(189002)(24454002)(199003)(3846002)(6116002)(189998001)(83506001)(81156014)(81166006)(8676002)(77096005)(1076002)(2870700001)(33716001)(4001350100001)(6916009)(2950100002)(47776003)(66066001)(97736004)(6666003)(7736002)(5660300001)(7846002)(110136003)(305945005)(50466002)(2906002)(92566002)(68736007)(101416001)(15975445007)(33656002)(4326007)(42186005)(9686002)(105586002)(586003)(106356001)(54356999)(76176999)(23676002)(50986999)(19580395003)(76506005)(19580405001)(18370500001)(2004002)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR07MB2243;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: caviumnetworks.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjRQUjA3TUIyMjQzOzIzOmpSeUNXNUJZTlJ6UkgrUUVUNVF1WGdlWjVw?= =?utf-8?B?dDFnS0dhNGp0MzVHT0VNZ3BXM1ZjTmN2RDYvdWxsTnIyMzRRMWZDSStkYm9N?= =?utf-8?B?RGU2QkorSUxicnRTK0tBWi9HeU5Qa2RjL2NKUDc3ZlYrOXFkMFFZdjhpNlRH?= =?utf-8?B?QUxoRmM4VEU5eVBoa0lRNjd4QlIrNy9oWGRUVzdZTFNhb2gxVEFJaVgxWEpV?= =?utf-8?B?djM4RUdHSmlMTnJoZW4zNGVpbGlNcStxRG9nTnhQRjkxemxHWlhDajFWd0VD?= =?utf-8?B?Njg3SnhLbFJlSERvcWRqWkg2aEQ0RUtCNjc3c2FhRURJejFjWDdtL05jSTd4?= =?utf-8?B?b0c5TCtCYnNoQ2RGVlgwZDRBMWl5UlFnYWtzRHR5bC9Wb20xYXNqMEh4NFlI?= =?utf-8?B?Q1JxUW0weTdjUUNyL1BIbWM3eno1dUtxdHVnVmg1cERKMkY2K25zclp4WmlX?= =?utf-8?B?TVdVNW9tWmN6M0x6Z1FKOGxnbnplWUJvZHVXZ2k4Ulo4SENYZXlhbmczckts?= =?utf-8?B?Zk1KTXRQdzltR1I3Sm4zRUlmY0lDK0MyYk1iQzdmUEhkcE9HMmdReVVVRE1p?= =?utf-8?B?dFc0WkFiemNwbFMyaXVzcFArK2prUjRTejQ5Y3BQMnRMcnk0M3RENWR4L0l5?= =?utf-8?B?dE5vQWVib3ZSTW1wYXF6NFlLQkR1bHhoZ2I1Tm5yT29NR25BR2lZeHkzV1Vt?= =?utf-8?B?YXNYNEcxdGl2NTdHVU8xSThUczF2Y2xlMUZ6MWh4SGtHMWQzT2Z3djFKV0VY?= =?utf-8?B?K1J0NGtER29EQkczRHlaODJwR1kyeDNpOHVIZ29WSUUwMjR0SGo3OUNnVkN3?= =?utf-8?B?V3VMbkd4MWExcWJES2tlaFY3TkRzNFIwL00yUWk5bDNIM2dMVzlwMTEwUWNF?= =?utf-8?B?QzBLM0NJVmJzZWlWdVpqdkJ0VkJqMjJsc0JIYTBldkVxRE1EU3hpS05HdzZG?= =?utf-8?B?K3VubGk3alhwaGgrdGtqOHJVdzhKTyttb3BHbCt0VGZHTGNvMHVWUEhtQVc4?= =?utf-8?B?Y1FUbnJiMVZXbDV5MnpzN0FHU2ZCOHNLTTAvVEpRUVRUQ3lvZVlFN0x1TFdw?= =?utf-8?B?MlpWZkt2TjJmZE41dUt4ak9Nd3pDcVczdU1Ya05YTWVkc2F2L1NpSEhDekJs?= =?utf-8?B?Nm9IYy9hNHBZTFQwZDJiMW9aN1gwVTJndWYzN2RDUkZhVkxXc2dwYkJFczdx?= =?utf-8?B?RXJxSHlNMnIvYndvcVJlOEJwLzBUdmNXem12MlNFNThMODdOVmtQV1pRSXpy?= =?utf-8?B?eitDMzZzNW84NjVYVEtEVXd5UzN2MzlieS9XWnB0aVM1L2k0bWE3UkREMzZn?= =?utf-8?B?MGh2NjYxbDFOVnpzWnN5dEVqZW81R3Urc1ZEZWxJQXNpY3RvUGFSVHhxSmZK?= =?utf-8?B?UVd1NzJyVEVsRjBJUTFwSHl2dHdxRTJuelljRDBQai8ydFIrbVBIbVFOVnN4?= =?utf-8?B?ZlA4RFdPcDJWa1hWRTFWOHh2VTh1aHNCMk5Vb0dCWTVlUElEYlZtN3RSQk1V?= =?utf-8?B?bmw5VzJ6cDlRd0JRa25YRXpBQU41dXZZY0twQmRLT3VTK0d1czY4MXlhckFT?= =?utf-8?B?NjRuT2tKQ1drbWRBamRTNWNDejRYQmJkRkJnTGhkQ095TGZVdUM2cklVMk5m?= =?utf-8?B?VUptVkFkY0lLejZTbWhvOTd3cDhzU1lGclZzTTJaMU5uUVhFZHV2dDJxdjF0?= =?utf-8?B?M2xWWnpISVd3eHRtN3NkSUlPb0wycDVFeGVJUnFSR3lvVXd1cTlIN2FSdUlH?= =?utf-8?B?emdrT2svMHRBQUZXd0NkRks3eFl1cmxaZkJYc1QvZGx5U0E4b0NiOWl2TFlz?= =?utf-8?B?bmtVWmI5UVBzd3A3ZUtNTk85RnEvS0lWeEpRZGhUdWFyNzRhL1hhOTI1ckdU?= =?utf-8?Q?9YMZ/dI/TJo=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2243;6:l2A4JcIt0GdEtLAR2x5EaK6E5skKx9ZWtbAejwEUGNMsATzYn41n2LOJ60L6UASPgt4qPMQBqjCQDm1XQOCBn+lYYanmo3bFVDaqEX6j2rwggYj419fAjUsUrdGfidkPUYrp1fOzy4lLVfOQgBj336t3JQpWEwIyXMOmtwSkqs0hgH3ZVBddT/3gaYl0O3Q2WzQt4v5TJV4kDx6S8oiozBy40wCCDG/8JhBc/4JYfkebrLVFKpmmpLxvpC357jdXp9ghjB46S8gGGuA5mqwh2fMqRcDa9MdTfAx9mx4dyCpflbkD7rU8qSje52CrW7eV;5:VDsL6yvVOWXmAKq50VWOYYTVcV0hMVvBj3ab9RSxEz2s7Qi7D1IbjXFVVRaD4VQ/kR9rWHnGXswLYAINmhJx3do7iHxWDIThWYT0BWS58aepq7e5IN0Iy2NsBC7jdwoas7HmnlUH8oTs1qBSP5Itlg==;24:AYl33B7mDr3IMy0EymH9BpW1INoq23gxHl/z/FTKwRs0Ga2mZaNTF4qsMc06JWkvV4+ltyoECAhPBcxG3mEV3PEoimjKDBb64PNkfkc3Glk=;7:1WJbDPvNxtiXcBYy/gw+VVJW151JNzpk33Jm3SSZnlrpuvO/3CmM1M9FxCYIU2y6nbvOJR02IMkMiiPOnBdMM27fO5ogaIMKeIsD6LB9/SbF7nEWDlhzqyQinpQ3+RXtuYbL6ZEqD9KcKkXJZZo0L9CX/3RqY8e7lj7tXgXqji/rdKt+49fOxCja6OTefT6VzRqWxFEsyeSDHtfRS6UzfSKDG6bhCVzsoeFqkqmtxfsiixcD3Hp+FcyoWICxhgwoaTJJr2B11c3fb2SiIJTtNFSu+AeY+m2vFOX+jg4oJN57PI2lD6xYirX0agPlwia/gHNOKwCmfWQAFkDuC6v5sqm7PrkAn2bvwONRtRms3ZU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2016 11:23:41.1629 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR07MB2243 X-SW-Source: 2016-10/txt/msg00332.txt.bz2 Hi Andreas, On Thu, Oct 20, 2016 at 09:10:48AM +0200, Andreas Schwab wrote: > On Okt 20 2016, Yury Norov wrote: > > > diff --git a/sysdeps/unix/sysv/linux/rename.c b/sysdeps/unix/sysv/linux/rename.c > > new file mode 100644 > > index 0000000..8e14d7d > > --- /dev/null > > +++ b/sysdeps/unix/sysv/linux/rename.c > > This overrides the unix/syscalls.list entry, thus architectures which > implement the rename syscall no longer use it. Yes. You want me to notice it in commit message? > > @@ -0,0 +1,27 @@ > > +/* rename() implemantation. > > + Copyright (C) 2016 Free Software Foundation, Inc. > > + This file is part of the GNU C Library. > > + Contributed by Chris Metcalf , 2011. > > + > > + The GNU C Library is free software; you can redistribute it and/or > > + modify it under the terms of the GNU Lesser General Public > > + License as published by the Free Software Foundation; either > > + version 2.1 of the License, or (at your option) any later version. > > + > > + The GNU C Library is distributed in the hope that it will be useful, > > + but WITHOUT ANY WARRANTY; without even the implied warranty of > > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > > + Lesser General Public License for more details. > > + > > + You should have received a copy of the GNU Lesser General Public > > + License along with the GNU C Library. If not, see > > + . */ > > + > > +#include > > + > > +/* Rename the file OLD to NEW. */ > > +int > > +rename (const char *old, const char *new) > > +{ > > + return renameat (AT_FDCWD, old, AT_FDCWD, new); > > +} > > ../sysdeps/unix/sysv/linux/rename.c: In function ‘rename’: > ../sysdeps/unix/sysv/linux/rename.c:26:3: error: implicit declaration of function ‘renameat’ [-Werror=implicit-function-declaration] > return renameat (AT_FDCWD, old, AT_FDCWD, new); > ^ Yes. The file should #inclide to fix it. If no other issues, I'll send v3 soon. Yury