From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 900 invoked by alias); 20 Oct 2016 12:53:12 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 884 invoked by uid 89); 20 Oct 2016 12:53:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:sk:NAM03-B, H*RU:sk:NAM03-B, HX-HELO:sk:NAM03-B, H*r:sk:NAM03-B X-HELO: NAM03-BY2-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@caviumnetworks.com; Date: Thu, 20 Oct 2016 12:53:00 -0000 From: Yury Norov To: Andreas Schwab CC: , , Subject: Re: [PATCH v2] Linux: consolidate rename() Message-ID: <20161020125249.GA15529@yury-N73SV> References: <1476924756-31448-1-git-send-email-ynorov@caviumnetworks.com> <20161020112331.GA13995@yury-N73SV> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-ClientProxiedBy: AM5PR0101CA0001.eurprd01.prod.exchangelabs.com (10.169.240.11) To BN4PR07MB2242.namprd07.prod.outlook.com (10.164.63.148) X-MS-Office365-Filtering-Correlation-Id: 098fe59a-5aee-4fa3-2465-08d3f8e804d9 X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2242;2:bxkkHupFgFLETEkA9PEyCFf/aL2xxsxRLUGeu77n5LMhRMhKvdSkvYRJA2yYdkWuTeRjdZXu9WY2OGqqcuvMAPYgPG78DzOIsUmqvW5YCP/xCSThCL6b9Go2QYEi668LacOKElj8HMmMIu7lUmPiA8DjP3cp85HMMxvqaETPujp5pdkMr74pgu3whLQOJ2oYUq879SONAcwRADnnfjsNOA==;3:RLmhN1gawQZoWXMI5MWRBAwFEyMleiDK972YIEFtIDfQlVWOruxNV/pmZY+ZCctP+A3PBMJm10/bkwo2bVsL1rKi0xZpJ8wptU6LMaK4B6dfvn3kJmJ84A49L0ywQuVUun0TPhYdQ3F2a0gvLwnpgQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2242; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2242;25:FT5ndFF2DIDa7M4wGEjWbtGdqHK/I/WEpq9MVMLjIv8Dg4BQd2EvOwXd/2c6SR8U9JEcl8W1PSm5fq6Z5PNpCTcuIP6on8dbGZ1TlAmUhlfT1I7A2Glg1Tx+N5MOLV8kk9o56X5KlYOSqDl+qpT6qRuKu1Kb+5+XVfispImnA1CFQ/R/o8TKBEW7YC0DpfbuxTLfsMrQn7WhS3dTF6bNAJFCnATvILw6iiPa3sDGM7FD0e5bcINPcmKrmk1uLd3xqEuc+QEGLthqyibD1BIU3OeIzDqMlX0mvVNbMk4PaToFrdBR5iBBb0QnvPaghXMqt5t71tZqTUzVLVZco9b8qAOtZo4MwwJRi6EWECsBTsblDA+urfmGuVZ0uby4p4QtvqYNHrH0ONOt91pLD/GMUdj0UCoIzn7RvsYC2SUluFTowlEKG/X1zZaWvha2cBTxaiFd9vM0EX7XhDhFcSoAKlxyIANsMtMWbK9Mji9ykPIdjMx16DZPN5zaDqnkpS5Kujvyb6N3fNYW7Dea0HioBQ4wCS1qFjLpBTdt/4E1prFpXKdaabyGXZafAIlByZgYhsaNP+uqcwbqaSz9wMe689M0rASNEzqZg5bRn8M32yloRxtK8kyoaHAg73IhV7eNmlcKWFtxs2zutbF3beYVIvnsJ0NjIiJXayjWvPjhBFs03zX9LSQ+WXhGpuoYjAThMTFuhGnj+wqT1D0vJsUrGsrvbydvLLCL5SqKrvG32+6IdLssRuLaMMpmuTOFAejJhLVDyK73FOg2+iup02gMGA== X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2242;31:+qgHlC5z4cHODKpCCDbstqSKxDrUc4hhsKJmQJpqgtGIL64QI5Zyy/sT/s1MdRNb6PnW3cbxgGknWM2QQdODxTvjNcHCACMsEha8EQnNJyDwZDEW9ztLy6J0S/zx31t84RO0J1Z+2qgxZPwBzRtc8Wi3CVwx24KSYJUPo4THOVGb/ngnOlSMIcj/P/u/NHdvWoylbDTmf2zlyy0t0YYcvfJweOqnAgidQIcqTEmGdsIA9foI77tz+EuwpI49HiU8lZZF7ctnjFeUjPWoCHmJiw==;20:Pm+cXDImKwOCxrSD7y5YPzZP8z1A40IW+lMyAVUAldgmk/moHvQJkla4ltfNZJYxlc5jw2KkbWTu/Oj0j+5gg2LpFZlR9ZF+/NMdTRAX395Vv7WAr8jQjVvQT5M1PB6/htZTDT1BAdGg/UIRwfUyjFw8NZx1Kgveayo2DeyiyuOGdxYFs7MKImEqcZfYO5GURDz44r+mtsl+NNTy5+oH0LwzW3F6R6xdZQvY3A2Ey6a4fYHg/ZnIeKCwoCIdokj7QOkBobJs/3E1u+dzJFYRMTkGO3hjsZv7vvrEe0gbZST/dH7GvflQhhLALAdVF9RZ7U8dnnUDVWSv1VRiFjRZWf5ykK8Q5CvFWr5zRzhoRCiqsoYpLIHSbMuZYLujpq8UcqRmYYZ6P4biYzB5tpelyiOwq/PqqXJHIfhNMV2YlJlpM3ehR/9vFfr/eek5/oDuN8aP16kdi1rAKh80zDKun/rTrmIptKFAVnr+E1uDu9aVT+fq42KY46HHZwIH05LsHGUTZWVL3+w6v3HS+D0qXhrbdJZQVbS2SWuwyVGx5v6xe/DeVz56ZVdN+AQlyisvoVVokJNSNTo3ft2I3MXjIOseo7t61GTqYHHanEonNaE= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:BN4PR07MB2242;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2242; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2242;4:o5CuSrwm2JBJZXVfZJ/OuF0+nrybjt7LtY/jEjWKjiLkVz7b5iRelWtf3F0pDSW1kpVG/ATL30TQxBoC8kb0Dl0ECT+K9myNjd0Nm1rD7kNegfcjL9/pXeVjsLek9JmP/LvMbYcgLjGtOq6QvNYM9N4Jkj4KVxP33kMon0jMq4mcpgrC4Xy+wMwZjuXk8tE77L4ow+vJA2+JgeyKWmEMZlT9dmMOORUGi2And3voWF4TrGhNVF40bSRFdO1NbUEg0fkqAlqPH39ZvdIitQvnMekLDbCrkRJPZJcSeMyn9oiRrEdVZB1b/YgTAszV4qVygYDzUGBvodkRphjAmsCg/yYixce+t2OSE15WmbtUQ9zpoJo7YljoIVMChq1jStdTUBvWHrT3/0Ihoytb1dOX5A== X-Forefront-PRVS: 01018CB5B3 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(24454002)(199003)(189002)(83506001)(1076002)(93886004)(19580395003)(76506005)(47776003)(7736002)(97756001)(6666003)(2906002)(19580405001)(4326007)(101416001)(50466002)(6916009)(42186005)(81166006)(105586002)(54356999)(8676002)(81156014)(189998001)(2950100002)(66066001)(23726003)(6116002)(4001350100001)(5660300001)(46406003)(106356001)(77096005)(305945005)(9686002)(68736007)(33716001)(97736004)(92566002)(7846002)(110136003)(3846002)(586003)(33656002)(50986999)(76176999)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR07MB2242;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: caviumnetworks.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN4PR07MB2242;23:yG4mZiDCVq2aBnd/CPrW1t9i6w2yobd936NM2kFPj?= =?us-ascii?Q?08T53EAxmAzywX48A7m7IU1TBbACGaIlCg96YlxoIl+DP3Ajxi0CO6TopCEW?= =?us-ascii?Q?xNUKOzUB7Kx5em7b6GQtlFGr8/NsCZeAyIzn5yups7aJbvgipvB6UM0qJjkT?= =?us-ascii?Q?+v0E5KCpYFzV34xCxqOcdKFEbtU94RHxqAl9vegp4DAtvYz9422g4yNj5RNR?= =?us-ascii?Q?HHTO/yLM3ojAga5QjR6evSgvr+qt5bnTokc2mZCW6e1F6gEAksf3jX44g6cc?= =?us-ascii?Q?tsYS6sLdLOcAkRDaHfqZWyiyuZWIUjDTfE3TxEQK5u6wOMlEM4oIn8HzFsEH?= =?us-ascii?Q?SkmsRhDOBJuPr96KJ0O6Q5xqj6U/2niNPqQDR/btxvvJkZ0yEPS6kUAzXtCk?= =?us-ascii?Q?kaIuDe0oMKB4epnIsjAC32gHHEMDxO9HiQ+7hZzWl4k6gPeTDqhZi7sICG6m?= =?us-ascii?Q?mfGkQpItIfEIc4hrud8zVvCgxht3fpDaYgR80N8HoQEx5JqEJV+kdMH4rdRK?= =?us-ascii?Q?nhRIRbt6F8kgVQpphgX9FNdIhOuyYcl0TbBpQIf9pC2HgmxqVhuPz3g0EAtX?= =?us-ascii?Q?DF/s+WyTkvUfDab70XpUdxPSh62cyqeVnLLtfeHa1DewwEMZMyC+jpITvpSH?= =?us-ascii?Q?Uv1hAlkDRDn8IZ21V7XxBCAuDn2NbuoHRR+swdN+j0wkqtJH63YwLsVIelOX?= =?us-ascii?Q?+XNTDWIJwSkNibpi6BnJ8ycTDd1/cqcGQcbkSB+wflJlEHEKjOburIlMkg/r?= =?us-ascii?Q?y2LDkaHwuVV/2yBpV1ACKhPM6CclFB844cQ799O8Xb4Q+Lyng9OJHtlzoBTM?= =?us-ascii?Q?FlzwYIFhufx9IPN1u3jQbRrIs7jNUm5XoiGbAMplUWZRe80wAweZQLe9lHCI?= =?us-ascii?Q?RoeTSUwwp5IEkI4ZSj9TrSpTUtcEFJxTx46jkvL8xhI3WUqZjK1XImAOLFd1?= =?us-ascii?Q?FgkzEpD/FNPqqajekFsjLP+sUcOf5oA4fTwSgn3oVxHjoXuS0ELhWmAjJjxh?= =?us-ascii?Q?DWRtOjajriKFjuaZIPGHtCZTXjssTJ/1wsyURZlYPREQExZ4riA+fSZb5Pnw?= =?us-ascii?Q?B1fvbM1wKFxBYT8HYbXsCbXGzUliCFNfSPI+FqPpZ2Yv/gi1UZ9BkdZ4tjdB?= =?us-ascii?Q?j1RPHlARzbEDv6cJY6ioY8TSxPNXmi/Ttw4cx4w0gkgmJqjedB/PVLFTWIPc?= =?us-ascii?Q?uyQMGGyI4wPHznsAHYyODp4hk+NuneB8rjcdNbNU/xj3hkqou9EZl0clc4Mz?= =?us-ascii?Q?431ZQUnzaz9g+GCFTiDPkJ/l1/kV47hqB67QLm4i29XjPCdz2OfWyOyoiWxQ?= =?us-ascii?B?UT09?= X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2242;6:ajOKavY0oNWz+zrdFW1Cbr+rZ2QOT/Nql7hLYeo9TMOY9F1q4e3Dz8iS79h5xB8xhPBVC0VE42nmYTqq7FLJ9ycoVW2jwsvgr05YimP/v3oHwJjttZdvVjAd4EsjXItzJ7GJKf4jkukVd0eHt7nRAL46Arg9BwLznECZXsW+vhxCnRcuLkfLsBqjDdsNwcMglP06SW91teIqnPLyfF8jN3UICVqZQTvisitj0LFyzfp/nJG7Z1XWsE+bGAe2+m4ad0aKJmCvvpxv2qbdY6ElK5tJ6vI9IlN7f44CdDkEvSmHw2jwJEIBpOdJgCPhQh3w;5:/DugeBIiQ8UXik3/lm8+VXFYTu057UhZVr9suUVBdrTTtBb42ERp3jXyZc0SQnJQCPOXnAHo2ML4OoLF2NAPGf4peoVcQ3vbUH2WDonpYzWggvy5MV1HUR1drLyGaoHeFXPEWrlF2XWGmyh/cjpeWAHTFYhLXYXrosaeiEXseV4=;24:ozD76i2dgeoh/CsOI76V8Z5RY3MKgS8cgtXN0rrI6KtaLxEe2EijInJHTLB8uCQUBCF9tj4v0VFhimYbTzY27kCoXu2PmAGmtGIMaL83bkk=;7:ORT3v0MQOo0IZCBKNiXPyQPSvcBXSSAEFXkDk18Bi7pn6Aw3mxSDi97GqV4f3CzJbKmuShRUaxcS5dbLvtw34Ns1b2K3WYqD4XMdnw5iHefs+SFcW4kbEoAmx2jFivbvA6jVC+7aMvUDsXWO/Y2awLZGeVTTda7IEmguBt4H3YPsNbd7QrU61JT9iA+qufLXfD0tPL3Z/8haF16TrVfoyThRbVFcBP2GDO4EREGmAUOP2lxDpIzJA0uXkq3B03Dsin11C60lBKcR1/A9AKau9qLy5qiukzpgqvyIKhm5NAAiKby2+FeQ/W8tH6anQv4JkPLhnmFxIeWNCzz9ZbfZXLjCfGdeS4lCvJUbqgM8O7A= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2016 12:52:58.4050 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR07MB2242 X-SW-Source: 2016-10/txt/msg00334.txt.bz2 On Thu, Oct 20, 2016 at 02:35:05PM +0200, Andreas Schwab wrote: > On Okt 20 2016, Yury Norov wrote: > > > Hi Andreas, > > > > On Thu, Oct 20, 2016 at 09:10:48AM +0200, Andreas Schwab wrote: > >> On Okt 20 2016, Yury Norov wrote: > >> > >> > diff --git a/sysdeps/unix/sysv/linux/rename.c b/sysdeps/unix/sysv/linux/rename.c > >> > new file mode 100644 > >> > index 0000000..8e14d7d > >> > --- /dev/null > >> > +++ b/sysdeps/unix/sysv/linux/rename.c > >> > >> This overrides the unix/syscalls.list entry, thus architectures which > >> implement the rename syscall no longer use it. > > > > Yes. You want me to notice it in commit message? > > Do all supported kernels implement renameat? Ah, now I understand you. It should be then like #include #include /* Rename the file OLD to NEW. */ int rename (const char *old, const char *new) { #ifdef __NR_rename return INLINE_SYSCALL_CALL (rename, old, new); #else return renameat (AT_FDCWD, old, AT_FDCWD, new); #endif } Is it OK?