From: Yury Norov <ynorov@caviumnetworks.com>
To: <libc-alpha@sourceware.org>
Subject: Re: [PATCH] generic/wordsize-32: don't declare getdents() if not needed
Date: Tue, 25 Oct 2016 20:46:00 -0000 [thread overview]
Message-ID: <20161025204538.GA3526@yury-N73SV> (raw)
In-Reply-To: <1474304204-30677-1-git-send-email-ynorov@caviumnetworks.com>
On Mon, Sep 19, 2016 at 07:56:44PM +0300, Yury Norov wrote:
>
> Modern 32-bit arches has off_t and ino_t types both 64-bit length. It means that
> struct dirent is the same as struct dirent64. So we can avoid useless conversion
> from 64- to 32-bit dirent layout, and simply alias __getdents64() to __getdents().
> The same is true if __USE_FILE_OFFSET64 option is enabled.
>
> Tested with aarch64/ilp32.
>
> 2016-09-19: Yury Norov <ynorov@caviumnetworks.com>
>
> * sysdeps/unix/sysv/linux/bits/dirent.h: enable _DIRENT_MATCHES_DIRENT64
> if __USE_FILE_OFFSET64 is enabled.
> * sysdeps/unix/sysv/linux/generic/getdents64.c: alias __getdents64() to
> __getdents() also if _DIRENT_MATCHES_DIRENT64 is enabled.
> * sysdeps/unix/sysv/linux/generic/wordsize-32/getdents.c: don't declare
> __getdents() if _DIRENT_MATCHES_DIRENT64 is enabled.
>
> Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
Ping?
prev parent reply other threads:[~2016-10-25 20:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 16:57 Yury Norov
2016-10-25 20:46 ` Yury Norov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025204538.GA3526@yury-N73SV \
--to=ynorov@caviumnetworks.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).