From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-74102-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 26627 invoked by alias); 26 Oct 2016 12:56:37 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 26593 invoked by uid 89); 26 Oct 2016 12:56:36 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,RCVD_IN_SEMBACKSCATTER autolearn=no version=3.3.2 spammy=Pushed
X-HELO: mx0a-001b2d01.pphosted.com
Date: Wed, 26 Oct 2016 12:56:00 -0000
From: "Gabriel F. T. Gomes" <gftg@linux.vnet.ibm.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org, joseph@codesourcery.com
Subject: Re: [PATCH] Use read_int in vfscanf
In-Reply-To: <482ccd6e-5d17-c87f-2033-030493118f70@redhat.com>
References: <1474595428-20601-1-git-send-email-gftg@linux.vnet.ibm.com>
	<482ccd6e-5d17-c87f-2033-030493118f70@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-TM-AS-MML: disable
X-Content-Scanned: Fidelis XPS MAILER
x-cbid: 16102612-0024-0000-0000-0000011CBEAE
X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused
x-cbparentid: 16102612-0025-0000-0000-000015D893E6
Message-Id: <20161026105611.55a948c7@keller>
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-26_06:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0
 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam
 adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000
 definitions=main-1610260225
X-SW-Source: 2016-10/txt/msg00462.txt.bz2

On Thu, 6 Oct 2016 14:21:39 +0200
Florian Weimer <fweimer@redhat.com> wrote:

> On 09/23/2016 03:50 AM, Gabriel F. T. Gomes wrote:
>=20
> > +	  argpos =3D read_int ((const UCHAR_T **) &f);=20=20
>=20
> This is a const char * =E2=86=92 const unsigned char * cast in the non-wi=
de case=20
> (and okay), but in the wide case, it goes from const int * to const=20
> unsigned int *, which is not valid.  This is a pre-existing issue in=20
> vfprintf.c, so I don't think it should block inclusion of this cleanup.

Thanks.  Pushed as 726d48ec.