From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26414 invoked by alias); 28 Oct 2016 13:33:03 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 26384 invoked by uid 89); 28 Oct 2016 13:33:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,RCVD_IN_SEMBACKSCATTER autolearn=no version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Date: Fri, 28 Oct 2016 13:33:00 -0000 From: "Gabriel F. T. Gomes" To: Florian Weimer Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] Fix warning caused by unused-result in bug-atexit3-lib.cc In-Reply-To: <6916e095-d2bd-20ee-57d9-0f1509cfb389@redhat.com> References: <1477659653-9022-1-git-send-email-gftg@linux.vnet.ibm.com> <6916e095-d2bd-20ee-57d9-0f1509cfb389@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16102813-0028-0000-0000-0000015EEC61 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16102813-0029-0000-0000-0000145448A2 Message-Id: <20161028113240.2ae7dbef@keller> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-28_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1610280230 X-SW-Source: 2016-10/txt/msg00535.txt.bz2 On Fri, 28 Oct 2016 15:04:13 +0200 Florian Weimer wrote: > On 10/28/2016 03:00 PM, Gabriel F. T. Gomes wrote: > > The test case dlfcn/bug-atexit3-lib.cc calls write and doesn't check the > > result. When building with GCC 6.2 from IBM's branch, this generates a > > warning in 'make check', which is treated as an error. This patch adds a > > return variable to get rid of the warning and of the error. > > You could use write_message from test-skeleton.c instead. it has a > proper unused variable guard. Is it ok to use write_message in c++ code being built as object? Thanks, Gabriel