From: "H.J. Lu" <hongjiu.lu@intel.com>
To: GNU C Library <libc-alpha@sourceware.org>
Subject: [PATCH] Don't use PLT nor GOT in libc.a [BZ #20750]
Date: Fri, 04 Nov 2016 17:47:00 -0000 [thread overview]
Message-ID: <20161104174739.GA5880@intel.com> (raw)
There is no need to use PLT nor GOT in libc.a to branch to a function,
regardless whether libc.a is compiled with PIC or not.
Tested on x86-64. OK for master?
H.J.
---
[BZ #20750]
* sysdeps/x86_64/sysdep.h (JUMPTARGET): Check SHARED instead
of PIC.
---
sysdeps/x86_64/sysdep.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sysdeps/x86_64/sysdep.h b/sysdeps/x86_64/sysdep.h
index 75ac747..fd25c90 100644
--- a/sysdeps/x86_64/sysdep.h
+++ b/sysdeps/x86_64/sysdep.h
@@ -89,13 +89,14 @@ lose: \
END (name)
#undef JUMPTARGET
-#ifdef PIC
+#ifdef SHARED
# ifdef BIND_NOW
# define JUMPTARGET(name) *name##@GOTPCREL(%rip)
# else
# define JUMPTARGET(name) name##@PLT
# endif
#else
+/* For libc.a, we want to branch to target directly. */
# define JUMPTARGET(name) name
#endif
--
2.7.4
next reply other threads:[~2016-11-04 17:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 17:47 H.J. Lu [this message]
2016-11-04 19:03 ` Florian Weimer
2016-11-04 19:25 ` H.J. Lu
2016-11-07 16:03 ` Florian Weimer
2016-11-07 17:14 ` H.J. Lu
2016-11-24 11:58 ` Allan McRae
2016-11-25 8:43 ` Florian Weimer
2016-11-28 17:46 ` H.J. Lu
2016-11-28 18:27 ` Joseph Myers
2016-11-28 21:32 ` H.J. Lu
2016-11-28 17:54 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161104174739.GA5880@intel.com \
--to=hongjiu.lu@intel.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).