From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104673 invoked by alias); 8 Nov 2016 00:41:07 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 104649 invoked by uid 89); 8 Nov 2016 00:41:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,RCVD_IN_SEMBACKSCATTER autolearn=no version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Date: Tue, 08 Nov 2016 00:41:00 -0000 From: "Gabriel F. T. Gomes" To: Florian Weimer Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 2/2] Add write_message_to_stderr and use it instead of write In-Reply-To: <1360b678-e145-a434-fd14-3d1d69b7239b@redhat.com> References: <1477961028-12150-1-git-send-email-gftg@linux.vnet.ibm.com> <1477961028-12150-3-git-send-email-gftg@linux.vnet.ibm.com> <1360b678-e145-a434-fd14-3d1d69b7239b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16110800-0028-0000-0000-000001642AC9 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16110800-0029-0000-0000-0000145C5336 Message-Id: <20161107224051.7c232da7@keller> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-07_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1611080010 X-SW-Source: 2016-11/txt/msg00261.txt.bz2 On Mon, 7 Nov 2016 18:32:28 +0100 Florian Weimer wrote: > On 11/01/2016 01:43 AM, Gabriel F. T. Gomes wrote: > > > > +/* Write a message to standard error. Can be used in signal handlers. */ > > +static void > > +__attribute__ ((unused)) > > +write_message_to_stderr (const char *message) > > +{ > > + ssize_t unused __attribute__ ((unused)); > > + unused = write (STDERR_FILENO, message, strlen (message)); > > +} > > These messages should really go to standard output, so you can adjust > the tests to use plain write_message instead and drop this hunk. Thanks. Pushed with the changes as e0c68519.