From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119081 invoked by alias); 14 Nov 2016 13:45:37 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 118506 invoked by uid 89); 14 Nov 2016 13:45:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=cyril, Cyril, nail, manpage X-HELO: mx2.suse.de Date: Mon, 14 Nov 2016 13:45:00 -0000 From: Cyril Hrubis To: "Michael Kerrisk (man-pages)" Cc: Jeff Layton , Florian Weimer , Mike Frysinger , libc-alpha@sourceware.org, linux-fsdevel@vger.kernel.org, Carlos O'Donell , Yuriy Kolerov Subject: Re: [glibc PATCH] fcntl: put F_OFD_* constants under #ifdef __USE_FILE_OFFSET64 Message-ID: <20161114134510.GD25055@rei.lan> References: <1471464343.3196.125.camel@redhat.com> <20160817203746.GF21655@vapier.lan> <1471467478.3196.143.camel@redhat.com> <20160817213522.GG21655@vapier.lan> <1471470526.3196.153.camel@redhat.com> <8e1a972a-7966-139b-9d75-6d3a847a1be8@redhat.com> <20160823110343.GA4962@rei.suse.cz> <1471952179.13027.3.camel@redhat.com> <20160823113830.GB4962@rei.suse.cz> <8acbfa50-516f-d402-928f-9a391610557d@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8acbfa50-516f-d402-928f-9a391610557d@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-SW-Source: 2016-11/txt/msg00459.txt.bz2 Hi! > >> To be clear, that approach was NAK'ed by Christoph (and I think that's > >> a good thing, actually -- one more nail in the non-LFS coffin). I think > >> what we want merged into glibc is this patch that I sent late on > >> Thursday: > >> > >> [glibc PATCHv2] fcntl: don't define OFD lock constants for 32-bit builds with small file offsets > >> > >> We'll also need your patch to the fcntl(2) manpage as well, but that's > >> a separate problem. > > > > Hmm, the patch for man-pages should be updated as well. We need > > somethign as: > > > > ... > > This lock type is Linux-specific, and available since Linux 3.15. > > On 32bit platform _FILE_OFFSET_BITS must defined to 64 (before including > > any header files) to make these locks available. > > ... > > > > Michael should I send updated patch or will you take care of this? > > I can do it, or you can. At the moment, I'm just holding off until I > see what is accepted into glibc. Ping. Is there any resolve for this? -- Cyril Hrubis chrubis@suse.cz