From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62977 invoked by alias); 14 Nov 2016 15:06:07 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 62960 invoked by uid 89); 14 Nov 2016 15:06:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=unreadable, Hx-languages-length:605 X-HELO: smtp.gentoo.org Date: Mon, 14 Nov 2016 15:06:00 -0000 From: Mike Frysinger To: Joseph Myers Cc: libc-alpha@sourceware.org Subject: Re: Add script to build many glibc configurations Message-ID: <20161114150603.GT21655@vapier.lan> Mail-Followup-To: Joseph Myers , libc-alpha@sourceware.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HxEkdbCoFEDbFH5U" Content-Disposition: inline In-Reply-To: X-SW-Source: 2016-11/txt/msg00464.txt.bz2 --HxEkdbCoFEDbFH5U Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-length: 600 On 11 Nov 2016 15:20, Joseph Myers wrote: > +import os.path this import is unnecessary > +class Context: please no old style classes. all of them should inherit object. class Context(object): > + > + """The global state associated with builds in a given directory.""" don't put a blank line between the class and its docstring. > + os.chmod(self.wrapper, > + (stat.S_IRWXU|stat.S_IRGRP|stat.S_IXGRP| > + stat.S_IROTH|stat.S_IXOTH)) the stat constants are unreadable imo. better to never use them and stick to sane octals like 0644 and such. -mike --HxEkdbCoFEDbFH5U Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYKdLbAAoJEEFjO5/oN/WBvUIQAMAZFQQc2MgoBokJR031Ue7/ VptGvcfGKHiJSZSsU+bAv4Y50TGfk3fswNMU/rEezKekZwMaJ1GJ+5ZucnvuUdZe RAC2gVB+Nmz+hGSjxJmoYmifj5ZgDOBhv2eL8ii+JpXJDGPWnZr5WxF+frK0Joz9 Yu5U36zyXJVKqDrZvZAXuJ4FZ/4Gx1wKBW74g1YpLi08MiD1MooJuDquCAttqkxo ADvTbIs7yc4mk6orl8BisrqT9w2V7jAzjHay5f8eHTLz4EHkvqN6atDBzxSsQdCH 00ABW7H19X4/AXQMcduwM5LJs/8LPxIOn/oStPF0n4DDtQWmDHW9PPJlht8FxNIx rJg0JXxeN/+w3+C3fmeTG+i2bOKMPxZUT+SX3UXCJ5AXpWsHG5xKgVnyaHv8gkbN UD2P371yaVTrl493bfXQuPDLQkje+2gaoQKOdASbbNCnucGHcw3gtDan2o2IfepK XuV8GhFaBv6XhcEk9a/mQihPs/bPMn3RIFziy4WSCV8nkyulNCkzRWxk31frDBtf jwy8sj+2ER4y+nFiLoAIrEVyzFLw1Ao2ure4vEII3qGgX8E3y7TEAqoJnsG9BaHq dy688E7rUJG5sG4/8erRmhs0UqJV1cIrRE8sy/L5v/4087a6CSEidXFwdedZ22fa g2/IMqKuB6+awKdDE41w =8QPv -----END PGP SIGNATURE----- --HxEkdbCoFEDbFH5U--