On 16 Nov 2016 01:39, Joseph Myers wrote: > On Tue, 15 Nov 2016, Mike Frysinger wrote: > > seems like you could just move it into the existing ifdef scope > > rather than duplicating the logic ? fpregs is only used inside > > of an existing if(){...} scope. > > Here is a patch which does that. (To be clear, it has to stay outside the > if (), because pointers into it are used by writev after that if () has > finished, so it needs to be live at that point.) > > Fix SH4 register-dump.h for soft-float. > > This patch fixes SH4 register-dump.h to declare a variable inside the > #ifdef in it is used, to avoid an unused variable error breaking the > build for soft-float. OK -mike