* [PATCH] Add comments to check-c++-types.sh
@ 2016-12-08 16:27 Steve Ellcey
2016-12-27 22:21 ` Steve Ellcey
0 siblings, 1 reply; 2+ messages in thread
From: Steve Ellcey @ 2016-12-08 16:27 UTC (permalink / raw)
To: libc-alpha
I would like to add some comments to scripts/check-c++-types.sh to make
it more obvious what it is doing. Does this text look OK?
Steve Ellcey
sellcey@caviumnetworks.com
2016-12-08 Steve Ellcey <sellcey@caviumnetworks.com>
* scripts/check-c++-types.sh: Add comments.
diff --git a/scripts/check-c++-types.sh b/scripts/check-c++-types.sh
index 489c4f0..f82ffff 100755
--- a/scripts/check-c++-types.sh
+++ b/scripts/check-c++-types.sh
@@ -15,6 +15,14 @@
# You should have received a copy of the GNU Lesser General Public
# License along with the GNU C Library; if not, see
# <http://www.gnu.org/licenses/>.
+
+# This script creates a list of data types where each type is followed
+# by the C++ mangled name for that type. That list is then compared
+# against the list in the c++-types.data file for the platform being
+# checked. Any difference between the two would mean that the C++ ABI
+# had changed and that should not happen even if the change is compatible
+# at the C language level.
+
#
# The list of data types has been created with
# cat <<EOF |
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Add comments to check-c++-types.sh
2016-12-08 16:27 [PATCH] Add comments to check-c++-types.sh Steve Ellcey
@ 2016-12-27 22:21 ` Steve Ellcey
0 siblings, 0 replies; 2+ messages in thread
From: Steve Ellcey @ 2016-12-27 22:21 UTC (permalink / raw)
To: libc-alpha
Since no one objected to my text, I am going to check this in as an
obvious change.
Steve Ellcey
sellcey@caviumnetworks.com
On Thu, 2016-12-08 at 08:27 -0800, Steve Ellcey wrote:
> I would like to add some comments to scripts/check-c++-types.sh to
> make
> it more obvious what it is doing.  Does this text look OK?
>
> Steve Ellcey
> sellcey@caviumnetworks.com
>
>
> 2016-12-08  Steve Ellcey  <sellcey@caviumnetworks.com>
>
> * scripts/check-c++-types.sh: Add comments.
>
>
>
> diff --git a/scripts/check-c++-types.sh b/scripts/check-c++-types.sh
> index 489c4f0..f82ffff 100755
> --- a/scripts/check-c++-types.sh
> +++ b/scripts/check-c++-types.sh
> @@ -15,6 +15,14 @@
> Â # You should have received a copy of the GNU Lesser General Public
> Â # License along with the GNU C Library; if not, see
> Â # <http://www.gnu.org/licenses/>.
> +
> +# This script creates a list of data types where each type is
> followed
> +# by the C++ mangled name for that type.  That list is then compared
> +# against the list in the c++-types.data file for the platform being
> +# checked.  Any difference between the two would mean that the C++
> ABI
> +# had changed and that should not happen even if the change is
> compatible
> +# at the C language level.
> +
> Â #
> Â # The list of data types has been created with
> Â # cat <<EOF |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-27 22:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-08 16:27 [PATCH] Add comments to check-c++-types.sh Steve Ellcey
2016-12-27 22:21 ` Steve Ellcey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).