* Fix alpha termios.h NL2, NL3 namespace (bug 21268)
@ 2017-03-18 0:34 Joseph Myers
2017-03-20 9:09 ` Mike Frysinger
0 siblings, 1 reply; 2+ messages in thread
From: Joseph Myers @ 2017-03-18 0:34 UTC (permalink / raw)
To: libc-alpha
sysdeps/unix/sysv/linux/alpha/bits/termios.h defines NL2 and NL3 for
__USE_MISC || __USE_XOPEN. These should only be defined for
__USE_MISC as they are not part of any standard namespace. This patch
conditions them accordingly, matching the powerpc version of the
header (the only other one in glibc that defines these macros).
Tested (compilation only) with build-many-glibcs.py.
2017-03-18 Joseph Myers <joseph@codesourcery.com>
[BZ #21268]
* sysdeps/unix/sysv/linux/alpha/bits/termios.h (NL2): Define only
if [__USE_MISC]
(NL3): Likewise.
diff --git a/sysdeps/unix/sysv/linux/alpha/bits/termios.h b/sysdeps/unix/sysv/linux/alpha/bits/termios.h
index 9deda15..b560484 100644
--- a/sysdeps/unix/sysv/linux/alpha/bits/termios.h
+++ b/sysdeps/unix/sysv/linux/alpha/bits/termios.h
@@ -93,8 +93,10 @@ struct termios
# define NLDLY 00001400
# define NL0 00000000
# define NL1 00000400
-# define NL2 00001000
-# define NL3 00001400
+# if defined __USE_MISC
+# define NL2 00001000
+# define NL3 00001400
+# endif
# define TABDLY 00006000
# define TAB0 00000000
# define TAB1 00002000
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Fix alpha termios.h NL2, NL3 namespace (bug 21268)
2017-03-18 0:34 Fix alpha termios.h NL2, NL3 namespace (bug 21268) Joseph Myers
@ 2017-03-20 9:09 ` Mike Frysinger
0 siblings, 0 replies; 2+ messages in thread
From: Mike Frysinger @ 2017-03-20 9:09 UTC (permalink / raw)
To: Joseph Myers; +Cc: libc-alpha
[-- Attachment #1: Type: text/plain, Size: 463 bytes --]
On 18 Mar 2017 00:34, Joseph Myers wrote:
> sysdeps/unix/sysv/linux/alpha/bits/termios.h defines NL2 and NL3 for
> __USE_MISC || __USE_XOPEN. These should only be defined for
> __USE_MISC as they are not part of any standard namespace. This patch
> conditions them accordingly, matching the powerpc version of the
> header (the only other one in glibc that defines these macros).
>
> Tested (compilation only) with build-many-glibcs.py.
lgtm
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-20 9:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-18 0:34 Fix alpha termios.h NL2, NL3 namespace (bug 21268) Joseph Myers
2017-03-20 9:09 ` Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).