From: Christoph Hellwig <hch@lst.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Christoph Hellwig <hch@lst.de>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Linux API <linux-api@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
libc-alpha <libc-alpha@sourceware.org>
Subject: Re: RFC: reject unknown open flags
Date: Thu, 30 Mar 2017 18:26:00 -0000 [thread overview]
Message-ID: <20170330182620.GA25251@lst.de> (raw)
In-Reply-To: <CA+55aFyg5sXb2vjW9Wt45asoveV7E1scqmph6Op6ZFYdGNwsEg@mail.gmail.com>
On Thu, Mar 30, 2017 at 11:19:53AM -0700, Linus Torvalds wrote:
> So quite frankly, I'd much rather see that people who really want to
> check would instead just
>
> fd = open(... O_ATOMIC);
> if (fd < 0)
> .. regular error handling ..
>
> /* Did we actually get O_ATOMIC? */
> if (!(O_ATOMIC & fnctl(fd, F_GETFL, NULL)))
> .. warn about lack of O_ATOMIC ..
>
> because I suspect that you will find users that might *want* atomic
> behavior, but in the absence of atomicity guarantees will want to
> still be able to do IO.
That would be nice, but still won't work as we blindly copy f_flags
into F_GETFL, not even masking our internal FMODE_ bits.
next prev parent reply other threads:[~2017-03-30 18:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 16:33 Christoph Hellwig
2017-03-30 16:33 ` [PATCH 2/2] fs: " Christoph Hellwig
2017-03-30 17:03 ` Linus Torvalds
2017-03-30 16:33 ` [PATCH 1/2] fs: add a VALID_OPEN_FLAGS Christoph Hellwig
2017-03-30 17:08 ` RFC: reject unknown open flags Linus Torvalds
2017-03-30 17:22 ` Christoph Hellwig
2017-03-30 18:19 ` Linus Torvalds
2017-03-30 18:26 ` Christoph Hellwig [this message]
2017-03-30 18:45 ` Linus Torvalds
2017-03-30 20:06 ` Boaz Harrosh
2017-03-30 19:02 ` Paul Eggert
2017-03-30 19:14 ` Linus Torvalds
2017-03-30 19:22 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170330182620.GA25251@lst.de \
--to=hch@lst.de \
--cc=libc-alpha@sourceware.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).