From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-78372-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 10709 invoked by alias); 31 Mar 2017 21:21:10 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 10700 invoked by uid 89); 31 Mar 2017 21:21:09 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_NEUTRAL autolearn=ham version=3.3.2 spammy=H*Ad:D*gentoo.org, sk:PTHREAD, H*F:D*fi
X-HELO: emh04.mail.saunalahti.fi
Date: Fri, 31 Mar 2017 21:21:00 -0000
From: Aaro Koskinen <aaro.koskinen@iki.fi>
To: John David Anglin <dave.anglin@bell.net>
Cc: GNU C Library <libc-alpha@sourceware.org>,
	Carlos O'Donell <carlos@redhat.com>,
	Mike Frysinger <vapier@gentoo.org>, Helge Deller <deller@gmx.de>
Subject: Re: [PATCH] hppa: Use generic pthread conditional variable support
Message-ID: <20170331212105.oocvzpfmzyhaas6n@raspberrypi-3.musicnaut.iki.fi>
References: <3278DDA9-61C9-44E2-9130-F625953652FA@bell.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3278DDA9-61C9-44E2-9130-F625953652FA@bell.net>
User-Agent: NeoMutt/20170113 (1.7.2)
X-SW-Source: 2017-03/txt/msg00733.txt.bz2

Hi,

On Sun, Mar 12, 2017 at 10:58:46AM -0400, John David Anglin wrote:
> The attach change switches the hppa target to use the generic pthread
> conditional variable support. We lose compatibility with linuxthreads
> but I don't think that is relevant anymore for the existing distributions.
> 
> The change fixes bug nptl/21016.
> 
> Okay?

[...]

> 2017-03-12  John David Anglin  <danglin@gcc.gnu.org>
> 
> 	[BZ #21016]
> 	* sysdeps/hppa/nptl/bits/pthreadtypes.h: Use generic data structure
> 	for conditional variables.
> 	* sysdeps/unix/sysv/linux/hppa/internaltypes.h (cond_compat_clear):
> 	Remove.
> 	(cond_compat_check_and_clear): Likewise.
> 	* sysdeps/unix/sysv/linux/hppa/pthread.h (PTHREAD_COND_INITIALIZER):
> 	Revise.
> 	* sysdeps/unix/sysv/linux/hppa/pthread_cond_broadcast.c: Delete file.
> 	* sysdeps/unix/sysv/linux/hppa/pthread_cond_destroy.c: Likewise.
> 	* sysdeps/unix/sysv/linux/hppa/pthread_cond_signal.c: Likewise.
> 	* sysdeps/unix/sysv/linux/hppa/pthread_cond_wait.c: Likewise.

Should you delete sysdeps/unix/sysv/linux/hppa/pthread_cond_init.c
as well? That code is calling cond_compat_clear() which is removed by
your changes, and the linking fails.

A.