From: "Gabriel F. T. Gomes" <gftg@linux.vnet.ibm.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH v5] float128: Add wrappers to override ldbl-128 as float128.
Date: Thu, 25 May 2017 14:24:00 -0000 [thread overview]
Message-ID: <20170525111915.1028837d@keller.br.ibm.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1705241629590.29027@digraph.polyomino.org.uk>
On Wed, 24 May 2017 16:32:20 +0000
Joseph Myers <joseph@codesourcery.com> wrote:
> On Fri, 19 May 2017, Gabriel F. T. Gomes wrote:
>
> > +#include <math.h>
> > +#undef HUGE_VALL
>
> > +/* float.h constants. */
> > +#include <float.h>
> > +#undef LDBL_DIG
> > +#undef LDBL_EPSILON
> > +#undef LDBL_MANT_DIG
> > +#undef LDBL_MAX
> > +#undef LDBL_MAX_10_EXP
> > +#undef LDBL_MAX_EXP
> > +#undef LDBL_MIN
> > +#undef LDBL_MIN_10_EXP
> > +#undef LDBL_MIN_EXP
> > +#undef LDBL_TRUE_MIN
> > +#define HUGE_VALL HUGE_VAL_F128
>
> HUGE_VALL is not a float.h constant; it would seem better to redefine it
> immediately after its #undef.
>
> > diff --git a/sysdeps/ieee754/float128/k_rem_pio2f128.c b/sysdeps/ieee754/float128/k_rem_pio2f128.c
> > new file mode 100644
> > index 0000000..5140266
> > --- /dev/null
> > +++ b/sysdeps/ieee754/float128/k_rem_pio2f128.c
> > @@ -0,0 +1,2 @@
> > +#include <float128_private.h>
> > +#include <math/k_rem_pio2l.c>
>
> This file is not needed, and math/k_rem_pio2l.c does not exist, as
> k_rem_pio2 is only built for the types that need it. So remove this file.
>
> OK with those changes.
>
Thanks. Pushed with the changes.
prev parent reply other threads:[~2017-05-25 14:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 16:43 Gabriel F. T. Gomes
2017-05-24 16:32 ` Joseph Myers
2017-05-25 14:24 ` Gabriel F. T. Gomes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170525111915.1028837d@keller.br.ibm.com \
--to=gftg@linux.vnet.ibm.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).