From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-79728-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 4051 invoked by alias); 25 May 2017 14:24:51 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 3870 invoked by uid 89); 25 May 2017 14:24:33 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,URIBL_RED autolearn=ham version=3.3.2 spammy=
X-HELO: mx0a-001b2d01.pphosted.com
Date: Thu, 25 May 2017 14:24:00 -0000
From: "Gabriel F. T. Gomes" <gftg@linux.vnet.ibm.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH v5] float128: Add wrappers to override ldbl-128 as
 float128.
In-Reply-To: <alpine.DEB.2.20.1705241629590.29027@digraph.polyomino.org.uk>
References: <1495212198-9970-1-git-send-email-gftg@linux.vnet.ibm.com>
	<alpine.DEB.2.20.1705241629590.29027@digraph.polyomino.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-TM-AS-MML: disable
x-cbid: 17052514-0028-0000-0000-000001B839CA
X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused
x-cbparentid: 17052514-0029-0000-0000-000014B8A3D8
Message-Id: <20170525111915.1028837d@keller.br.ibm.com>
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-25_09:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0
 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam
 adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000
 definitions=main-1705250273
X-SW-Source: 2017-05/txt/msg00756.txt.bz2

On Wed, 24 May 2017 16:32:20 +0000
Joseph Myers <joseph@codesourcery.com> wrote:

> On Fri, 19 May 2017, Gabriel F. T. Gomes wrote:
> 
> > +#include <math.h>
> > +#undef HUGE_VALL  
> 
> > +/* float.h constants.  */
> > +#include <float.h>
> > +#undef LDBL_DIG
> > +#undef LDBL_EPSILON
> > +#undef LDBL_MANT_DIG
> > +#undef LDBL_MAX
> > +#undef LDBL_MAX_10_EXP
> > +#undef LDBL_MAX_EXP
> > +#undef LDBL_MIN
> > +#undef LDBL_MIN_10_EXP
> > +#undef LDBL_MIN_EXP
> > +#undef LDBL_TRUE_MIN
> > +#define HUGE_VALL HUGE_VAL_F128  
> 
> HUGE_VALL is not a float.h constant; it would seem better to redefine it 
> immediately after its #undef.
> 
> > diff --git a/sysdeps/ieee754/float128/k_rem_pio2f128.c b/sysdeps/ieee754/float128/k_rem_pio2f128.c
> > new file mode 100644
> > index 0000000..5140266
> > --- /dev/null
> > +++ b/sysdeps/ieee754/float128/k_rem_pio2f128.c
> > @@ -0,0 +1,2 @@
> > +#include <float128_private.h>
> > +#include <math/k_rem_pio2l.c>  
> 
> This file is not needed, and math/k_rem_pio2l.c does not exist, as 
> k_rem_pio2 is only built for the types that need it.  So remove this file.
> 
> OK with those changes.
> 

Thanks.  Pushed with the changes.