public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "Gabriel F. T. Gomes" <gftg@linux.vnet.ibm.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH 2/6] float128: Add conversion from float128 to mpn
Date: Thu, 01 Jun 2017 23:52:00 -0000	[thread overview]
Message-ID: <20170601205224.7092b3bc@keller.br.ibm.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1706011315390.6083@digraph.polyomino.org.uk>

On Thu, 1 Jun 2017 13:23:25 +0000
Joseph Myers <joseph@codesourcery.com> wrote:

> On Mon, 29 May 2017, Gabriel F. T. Gomes wrote:
> 
> > I attached a new patch which replaces the definition of MAX and MIN in
> > stdlib/gmp-impl.h with an inclusion of sys/param.h.
> > 
> > Is the attached patch OK for master?  
> 
> That patch is OK.

Thanks.  I've committed it.

> This sounds like an include ordering problem.  float128_private.h 
> redefines lots of names from math_private.h and math.h.  But that doesn't 
> cause problems because it includes those headers first.  So how about 
> making float128_private.h include gmp.h before redefining 
> __mpn_extract_long_double?

Thanks again.  I rewrote this and I'll send again with the other patches
in the series.

  reply	other threads:[~2017-06-01 23:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-26 12:57 [PATCH 0/6] Add string functions and libm tests for _Float128 Gabriel F. T. Gomes
2017-05-26 12:57 ` [PATCH 4/6] float128: Add strtof128, wcstof128, and related functions Gabriel F. T. Gomes
2017-05-26 16:07   ` Joseph Myers
2017-05-26 12:57 ` [PATCH 2/6] float128: Add conversion from float128 to mpn Gabriel F. T. Gomes
2017-05-26 15:35   ` Joseph Myers
2017-05-30  2:31     ` Gabriel F. T. Gomes
2017-06-01 13:23       ` Joseph Myers
2017-06-01 23:52         ` Gabriel F. T. Gomes [this message]
2017-05-26 12:57 ` [PATCH 5/6] float128: Add strfromf128, strtof128, and wcstof128 to the manual Gabriel F. T. Gomes
2017-05-26 13:29   ` Florian Weimer
2017-05-26 16:17   ` Joseph Myers
2017-05-26 12:57 ` [PATCH 6/6] float128: Add test-{float128,ifloat128,float128-finite} Gabriel F. T. Gomes
2017-05-26 16:26   ` Joseph Myers
2017-05-26 12:57 ` [PATCH 1/6] float128: Extend the power of ten tables Gabriel F. T. Gomes
2017-05-26 15:30   ` Joseph Myers
2017-05-26 12:57 ` [PATCH 3/6] float128: Add strfromf128 Gabriel F. T. Gomes
2017-05-26 15:56   ` Joseph Myers
2017-05-30  2:32     ` Gabriel F. T. Gomes
2017-06-02 16:31       ` Joseph Myers
2017-06-02 23:27         ` Gabriel F. T. Gomes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170601205224.7092b3bc@keller.br.ibm.com \
    --to=gftg@linux.vnet.ibm.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).