From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82526 invoked by alias); 1 Jun 2017 23:52:35 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 82510 invoked by uid 89); 1 Jun 2017 23:52:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,URIBL_RED autolearn=no version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Date: Thu, 01 Jun 2017 23:52:00 -0000 From: "Gabriel F. T. Gomes" To: Joseph Myers Cc: Subject: Re: [PATCH 2/6] float128: Add conversion from float128 to mpn In-Reply-To: References: <1495803396-14558-1-git-send-email-gftg@linux.vnet.ibm.com> <1495803396-14558-3-git-send-email-gftg@linux.vnet.ibm.com> <20170529233114.249cee23@keller.br.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable x-cbid: 17060123-0028-0000-0000-000001BCD45A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17060123-0029-0000-0000-000014BDD7CE Message-Id: <20170601205224.7092b3bc@keller.br.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-01_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706010442 X-SW-Source: 2017-06/txt/msg00077.txt.bz2 On Thu, 1 Jun 2017 13:23:25 +0000 Joseph Myers wrote: > On Mon, 29 May 2017, Gabriel F. T. Gomes wrote: > > > I attached a new patch which replaces the definition of MAX and MIN in > > stdlib/gmp-impl.h with an inclusion of sys/param.h. > > > > Is the attached patch OK for master? > > That patch is OK. Thanks. I've committed it. > This sounds like an include ordering problem. float128_private.h > redefines lots of names from math_private.h and math.h. But that doesn't > cause problems because it includes those headers first. So how about > making float128_private.h include gmp.h before redefining > __mpn_extract_long_double? Thanks again. I rewrote this and I'll send again with the other patches in the series.