On Thu, Jul 20, 2017 at 10:32:22AM +0200, Stefan Liebler wrote: > On 07/20/2017 10:06 AM, Carlos O'Donell wrote: > > On 07/20/2017 03:38 AM, Stefan Liebler wrote: > >> Carlos, shall we commit Dimitry's patch before the release? > >> Then we don't have this regression compared to glibc 2.25 release. > > > > I'm OK with Dmitry's patch going in for 2.26 to fix the regression. > Okay. > > > Could you please work with Dmitry to get this committed? > Okay. > Dimitry, I have one small note to your patch: > Can you add a space before the undefs and add the comment like this: > (according to > https://sourceware.org/glibc/wiki/Style_and_Conventions#Nested_C_Preprocessor_Directives) > > #if defined _LINUX_PTRACE_H || defined _S390_PTRACE_H > /* Kludge to stop stuff gdb & strace compiles from getting upset > */ > # undef PTRACE_TRACEME > ... > #endif /* defined _LINUX_PTRACE_H || defined _S390_PTRACE_H */ > > Then the patch is okay. > Can you please commit the patch? OK, committed. -- ldv