From: Jonathan Nieder <jrnieder@gmail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] support_create_temp_directory: Align behavior with create_temp_file
Date: Fri, 17 Nov 2017 17:22:00 -0000 [thread overview]
Message-ID: <20171117172232.wokgzzpfvbdjzf6x@aiede.mtv.corp.google.com> (raw)
In-Reply-To: <20171117145550.8B6324469B999@oldenburg.str.redhat.com>
Florian Weimer wrote:
> create_temp_file automatically supplies the test directory and the
> XXXXXX suffix. support_create_temp_directory required the caller to
> specify them, which was confusing.
>
> 2017-11-17 Florian Weimer <fweimer@redhat.com>
>
> * support/temp_file.c (support_create_temp_directory): Use
> test_dir and do not rely on the presence of the XXXXXX suffix.
> * support/temp_file.h (support_create_temp_directory): Update
> comment.
> * support/tst-xreadlink.c (do_test): Adjust.
Makes sense.
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
next prev parent reply other threads:[~2017-11-17 17:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 14:55 Florian Weimer
2017-11-17 17:22 ` Jonathan Nieder [this message]
2017-11-18 12:38 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171117172232.wokgzzpfvbdjzf6x@aiede.mtv.corp.google.com \
--to=jrnieder@gmail.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).