On Mon, Dec 25, 2017 at 12:09:56PM -0800, Zack Weinberg wrote: > On Mon, Dec 25, 2017 at 11:12 AM, Dmitry V. Levin wrote: > > On Mon, Dec 25, 2017 at 07:19:44PM +0100, Florian Weimer wrote: > >> * Dmitry V. Levin: > >> > >> > * sysdeps/unix/sysv/linux/tst-ttyname.c (do_in_chroot_1): Skip the > >> > test instead of failing in case of an error returned by posix_openpt. > >> > >> I think the test failure is real in this case. I wouldn't it be? > > > > No, /dev/ptmx is intentionally missing in the environment where this test > > failed. > > Why? It's a restricted environment. > > Do you suggest an explicit check for ENOENT? > > If this is absolutely necessary for some reason, then it should be as > narrow as possible, so yes, that would be my suggestion. OK -- ldv