From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49272 invoked by alias); 25 Dec 2017 21:01:03 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 48688 invoked by uid 89); 25 Dec 2017 21:01:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: vmicros1.altlinux.org Date: Mon, 25 Dec 2017 21:01:00 -0000 From: "Dmitry V. Levin" To: libc-alpha@sourceware.org Subject: Re: [PATCH] tst-ttyname: skip the test when /dev/ptmx is not available Message-ID: <20171225210058.GA10404@altlinux.org> Mail-Followup-To: libc-alpha@sourceware.org References: <20171225114806.GB4341@altlinux.org> <87a7y6u0u7.fsf@mid.deneb.enyo.de> <20171225191256.GA8591@altlinux.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fdj2RfSjLxBAspz7" Content-Disposition: inline In-Reply-To: X-SW-Source: 2017-12/txt/msg00895.txt.bz2 --fdj2RfSjLxBAspz7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 809 On Mon, Dec 25, 2017 at 12:09:56PM -0800, Zack Weinberg wrote: > On Mon, Dec 25, 2017 at 11:12 AM, Dmitry V. Levin wrot= e: > > On Mon, Dec 25, 2017 at 07:19:44PM +0100, Florian Weimer wrote: > >> * Dmitry V. Levin: > >> > >> > * sysdeps/unix/sysv/linux/tst-ttyname.c (do_in_chroot_1): Skip the > >> > test instead of failing in case of an error returned by posix_openpt. > >> > >> I think the test failure is real in this case. I wouldn't it be? > > > > No, /dev/ptmx is intentionally missing in the environment where this te= st > > failed. >=20 > Why? It's a restricted environment. > > Do you suggest an explicit check for ENOENT? >=20 > If this is absolutely necessary for some reason, then it should be as > narrow as possible, so yes, that would be my suggestion. OK --=20 ldv --fdj2RfSjLxBAspz7 Content-Type: application/pgp-signature; name="signature.asc" Content-length: 801 -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJaQWcKAAoJEAVFT+BVnCUIGk4P/jCmX+INNRlN9MyGi/WwYuBU Lp2H8vVPIym51wC7OtpLn4laGZeB/sznPu7HOaX7EZM/cdJ0+SW+adAY/KQ0k4dR T42zs4wjBUT3hT3hVsWrTwTZhLLW7jp4Ngemv8SMwvU6+c0ysQNCmLviGD8w4hhf fZEX6bkWHvILq5nU7F5Wk5+OCi/MEBLeuNS0cuZmgBLId2VHd/zjBO7KSRe1rzo4 ZvEIikTGrHQEW5g5w1jiR5GwjQ4OXqsF9ZAySyMA7fMAKcbmQbScPNH9k1usn4p8 re9c2WpjyZhRq3OTK6bnqT5jBWFH4gEO1ZMXNDPeyspA4+HObwncg8f83lJDjFP5 RA6acYw0VQQ+/jm7Eslip6GtzFtzFKE9vK34OkX3zb886U29d2UzuRDmk5rocWBw aRu9Tmx+VR87D6I1unneqj46EF9R6lfpeSo20ac1+seQ61jedaUSSScX3ZZavapb nw5sPdpfD1st7aed1pUpwMslcO2g31C0KuOneq+pz5Euv8/UUfCIlDThVbS33/nd mW4eFII33Zo40iuOCmQ06dX9mCsSE6gFSQT1xNcX6lQrjbVPEe5gi0Q1YvsAe+Z6 eFQCNNO31f1FeUzSdYMBwzEg0nW9D9GGLZzkXEeXR2lPMZ5WtdDWJ5IULKRshyJj meqpChIqh8GhT9uC/N7s =xyx0 -----END PGP SIGNATURE----- --fdj2RfSjLxBAspz7--