Re: [PATCH] tst-ttyname: skip the test when /dev/ptmx is not available

["Dmitry V. Levin" <ldv@altlinux.org>]

[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]

On Fri, Dec 29, 2017 at 02:55:17PM +0100, Florian Weimer wrote:
> * Dmitry V. Levin:
> 
> >> I don't think the glibc test suite is supposed to pass in such an
> >> environment.
> >
> > It used to work perfectly for at least 15 years, and it still works
> > when tst-ttyname is fixed.
> 
> This just reflects that we did not have sufficient test coverage for
> the PTY code.

No doubts about that, but the kernel side of pty interface does not have
to be implemented, so we cannot allow the test to fail just because the
kernel does not provide it.

> > btw, as support_become_root is also unavailable in restricted
> > environments, an alternative fix for tst-ttyname is to skip the test
> > when support_become_root fails.
> 
> But that's unrelated.  And in some environments, support_become_root
> can fail, but the process was initially sufficiently privileged to run
> the test.

I don't think such environments exist in practice but this is
theoretically possible.


-- 
ldv

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]