From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122942 invoked by alias); 7 Jan 2018 21:45:16 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 94120 invoked by uid 89); 7 Jan 2018 21:45:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy= X-HELO: hall.aurel32.net Date: Sun, 07 Jan 2018 21:45:00 -0000 From: Aurelien Jarno To: Joseph Myers , libc-alpha@sourceware.org Subject: Re: [PATCH 0/4] Fix getrlimit/setrlimit/prlimit on Alpha and 32-bit machines Message-ID: <20180107214459.GA7983@aurel32.net> Mail-Followup-To: Joseph Myers , libc-alpha@sourceware.org References: <20180105132429.21118-1-aurelien@aurel32.net> <20180106100044.GA28831@aurel32.net> <20180106110104.GC22048@aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180106110104.GC22048@aurel32.net> User-Agent: Mutt/1.9.2 (2017-12-15) X-SW-Source: 2018-01/txt/msg00227.txt.bz2 On 2018-01-06 12:01, Aurelien Jarno wrote: > On 2018-01-06 11:00, Aurelien Jarno wrote: > > On 2018-01-05 23:55, Joseph Myers wrote: > > > One of these patches breaks the testsuite build for various (but not all) > > > 32-bit configurations. > > > > > > https://sourceware.org/ml/libc-testresults/2018-q1/msg00035.html > > > > > > The failures are all of the form: > > > > > > /scratch/jmyers/glibc-bot/build/glibcs/arm-linux-gnueabi/glibc/io/test-lfs.o: In function `do_prepare': > > > /scratch/jmyers/glibc-bot/build/glibcs/arm-linux-gnueabi/glibc-src/io/test-lfs.c:75: undefined reference to `getrlimit64' > > > collect2: error: ld returned 1 exit status > > > ../Rules:202: recipe for target '/scratch/jmyers/glibc-bot/build/glibcs/arm-linux-gnueabi/glibc/io/test-lfs' failed > > > make[3]: *** [/scratch/jmyers/glibc-bot/build/glibcs/arm-linux-gnueabi/glibc/io/test-lfs] Error 1 > > > > Sorry about that. The issue happens on 32-bit configurations which have > > a minimum version >= 2.2, and thus which don't need the 2GiB limited > > compat getrlimit64. I wrongly moved one case under the #ifdef > > __RLIM_T_MATCHES_RLIM64_T case, while it should have been copied > > instead. > > > > I am currently testing the following patch: > > It worked fine on arm-linux-gnueabihf with no regression. Here is the > full patch. I have now committed it, as I don't want to leave things broken for too long. Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net