From: "Dmitry V. Levin" <ldv@altlinux.org>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH v11 1/5] Implement alternative month names (bug 10871).
Date: Thu, 11 Jan 2018 12:25:00 -0000 [thread overview]
Message-ID: <20180111122535.GA13782@altlinux.org> (raw)
In-Reply-To: <158980540.7020.1515671166647@poczta.nazwa.pl>
[-- Attachment #1: Type: text/plain, Size: 3405 bytes --]
On Thu, Jan 11, 2018 at 12:46:06PM +0100, Rafal Luzynski wrote:
> 11.01.2018 03:16 "Dmitry V. Levin" <ldv@altlinux.org> wrote:
> > On Tue, Jan 09, 2018 at 12:59:21AM +0100, Rafal Luzynski wrote:
> > > [BZ #10871]
> > > * locale/C-time.c: Add alternative month names, define them as the
> > > same as mon explicitly.
> >
> > * locale/C-time.c (_nl_C_LC_TIME): Add alternative month names.
> >
> > I don't understand what do you mean by "define them as the same as mon
> > explicitly", though.
>
> Initially I had an idea to add the alternative month names but
> initialize them all to empty strings ("") and rely on the mechanism
> which falls back to the regular month names if the alternative ones
> are empty. Then this has been changed to initialize them just "January",
> "February", etc. How to name those month names? Regular? Nominative?
> Basic? Non-alternative?
Whatever you like, I'd just use "month names":
* locale/C-time.c (_nl_C_LC_TIME): Update nstrings. Add alternative month
names defined to the same string values as month names.
> > [...]
> > > * locale/programs/ld-time.c: Alternative month names support
> > > added, they are a copy of mon if not specified explicitly.
> >
> > * locale/programs/ld-time.c (struct locale_time_t): Add alt_mon,
> > walt_mon, and alt_mon_defined members.
> > (time_output): Output alt_mon and walt_mon members.
> > (time_read): Read them, initialize alt_mon_defined.
>
> This is OK but shouldn't we mention that alt_mon content is copied
> from mon (and walt_mon from wmon) if not specified explicitly in the
> locale data file?
Feel free to mention whatever you consider appropriate,
my comments were mostly about the ChangeLog style.
> > [...]
> > > * time/strptime_l.c: Alternative month names also recognized.
> >
> > * time/strptime_l.c (alt_month_name): New macro.
> > (__strptime_internal) [_LIBC]: Add ... (whatever is being added).
> > Handle %OB format.
>
> I'm confused. Actually alt_month_name has been added globally
> in the #ifdef _LIBC section so I think this makes sense:
>
> * time/strptime_l.c [_LIBC] (alt_month_name): New macro.
Sure, you must know better, I cannot tell by looking at the patch.
> But I don't understand what do you mean by "(__strptime_internal)
> [_LIBC]: Add ... (whatever is being added)." It's "Handle %OB format"
> what has been added. And it's not really conditional [_LIBC]; the
> difference is that if _LIBC is not defined then %OB format is accepted
> but alternative month names are not checked (because alt_month_name does
> not exist). Is this a copy-paste typo? What else do I miss?
If it's not conditional, than [_LIBC] is not needed.
> > [...]
> > > --- a/locale/langinfo.h
> > > +++ b/locale/langinfo.h
> > > @@ -100,7 +100,8 @@ enum
> > > ABMON_12,
> > > #define ABMON_12 ABMON_12
> > >
> > > - /* Long month names. */
> > > + /* Long month names, in the grammatical form used when the month
> > > + forms part of a complete date. */
> >
> > ... when month name is a part of ...?
>
> Does the question mark mean that you are not sure? Well, this comment
> has been provided by Zack Weinberg who is a native English speaker.
I read this as "month is a part of a part of a complete date" which
is too complex unless your intention is to highlight that month name
is a subpart.
--
ldv
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2018-01-11 12:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 23:54 [PATCH v11 0/5][BZ 10871] Month names in alternative grammatical case Rafal Luzynski
2018-01-08 23:59 ` [PATCH v11 1/5] Implement alternative month names (bug 10871) Rafal Luzynski
2018-01-09 0:14 ` Rafal Luzynski
2018-01-11 4:20 ` Carlos O'Donell
2018-01-11 2:16 ` Dmitry V. Levin
2018-01-11 5:05 ` Carlos O'Donell
2018-01-12 3:44 ` Rafal Luzynski
2018-01-12 4:09 ` Carlos O'Donell
2018-01-11 11:46 ` Rafal Luzynski
2018-01-11 12:25 ` Dmitry V. Levin [this message]
2018-01-11 14:32 ` Zack Weinberg
2018-01-11 15:07 ` Dmitry V. Levin
2018-01-11 15:22 ` Zack Weinberg
2018-01-11 15:44 ` Rafal Luzynski
2018-01-11 22:26 ` Rafal Luzynski
2018-01-09 0:01 ` [PATCH v11 3/5] Abbreviated alternative month names (%Ob) also added " Rafal Luzynski
2018-01-11 5:05 ` Carlos O'Donell
2018-01-11 19:04 ` Rafal Luzynski
2018-01-11 19:14 ` Carlos O'Donell
2018-01-12 4:01 ` Rafal Luzynski
2018-01-09 0:03 ` [PATCH v11 5/5] Documentation to the above changes " Rafal Luzynski
2018-01-11 4:50 ` Carlos O'Donell
2018-01-12 4:21 ` Rafal Luzynski
2018-01-09 0:05 ` [PATCH] pl_PL: Add alternative month names " Rafal Luzynski
2018-01-09 0:20 ` Rafal Luzynski
2018-01-11 4:40 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111122535.GA13782@altlinux.org \
--to=ldv@altlinux.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).