public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH 1/1] rpc: Include missing portmap headers
@ 2018-01-31 11:21 Petr Vorel
  0 siblings, 0 replies; only message in thread
From: Petr Vorel @ 2018-01-31 11:21 UTC (permalink / raw)
  To: libc-alpha; +Cc: Petr Vorel, Cyril Hrubis

man pmap_set (rpc/pmap_clnt.h) and man pmap_unset (rpc/pmap_clnt.h) both
lead to rpc(3) and that manual page explicitly
says 'To take use of these routines, include the header file
<rpc/rpc.h>'.

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Hi,

While compiling a rpc test server[1] we get implicit declaration warning
for pmap_unset(). The question is if the pmap_*.h headers should be
included in rpc.h or not, i.e. if this is a bug in the test or in the
glibc header.
[1] https://github.com/linux-test-project/ltp/blob/master/testcases/network/rpc/basic_tests/rpc01/rpc_server.c

Kind regards,
Petr
---
 sunrpc/rpc/rpc.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sunrpc/rpc/rpc.h b/sunrpc/rpc/rpc.h
index 173a4e31ea..213a3384a1 100644
--- a/sunrpc/rpc/rpc.h
+++ b/sunrpc/rpc/rpc.h
@@ -64,6 +64,10 @@
 /* routines for parsing /etc/rpc */
 #include <rpc/netdb.h>		/* structures and routines to parse /etc/rpc */
 
+/* Portmapper client, server, and protocol headers */
+#include <rpc/pmap_clnt.h>
+#include <rpc/pmap_prot.h>
+
 __BEGIN_DECLS
 
 /* Global variables, protected for multi-threaded applications.  */
-- 
2.16.1

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2018-01-30 15:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-31 11:21 [PATCH 1/1] rpc: Include missing portmap headers Petr Vorel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).