[PATCH] Fix uninitialized variable in assert_perror (bug 22761)

[PATCH] Fix uninitialized variable in assert_perror (bug 22761)

[Andreas Schwab]

I wasn't able to get assert_perror to misbehave in an observable way.

	[BZ #22761]
	* assert/assert-perr.c (__assert_perror_fail): Append %n to format
	string.
---
 assert/assert-perr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/assert/assert-perr.c b/assert/assert-perr.c
index 002a5e8708..4b4fe883fd 100644
--- a/assert/assert-perr.c
+++ b/assert/assert-perr.c
@@ -32,7 +32,7 @@ __assert_perror_fail (int errnum,
   char errbuf[1024];
 
   char *e = __strerror_r (errnum, errbuf, sizeof errbuf);
-  __assert_fail_base (_("%s%s%s:%u: %s%sUnexpected error: %s.\n"),
+  __assert_fail_base (_("%s%s%s:%u: %s%sUnexpected error: %s.\n%n"),
 		      e, file, line, function);
 }
 libc_hidden_def (__assert_perror_fail)
-- 
2.16.1


-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Re: [PATCH] Fix uninitialized variable in assert_perror (bug 22761)

[Florian Weimer]

On 01/31/2018 10:55 AM, Andreas Schwab wrote:
> I wasn't able to get assert_perror to misbehave in an observable way.
> 
> 	[BZ #22761]
> 	* assert/assert-perr.c (__assert_perror_fail): Append %n to format
> 	string.

The patch looks good to me.  I'm not sure if it should go in so shortly 
before the release.

Thanks,
Florian

Re: [PATCH] Fix uninitialized variable in assert_perror (bug 22761)

[Dmitry V. Levin]

[-- Attachment #1: Type: text/plain, Size: 990 bytes --]

On Wed, Jan 31, 2018 at 10:55:44AM +0100, Andreas Schwab wrote:
> I wasn't able to get assert_perror to misbehave in an observable way.
> 
> 	[BZ #22761]
> 	* assert/assert-perr.c (__assert_perror_fail): Append %n to format
> 	string.
> ---
>  assert/assert-perr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/assert/assert-perr.c b/assert/assert-perr.c
> index 002a5e8708..4b4fe883fd 100644
> --- a/assert/assert-perr.c
> +++ b/assert/assert-perr.c
> @@ -32,7 +32,7 @@ __assert_perror_fail (int errnum,
>    char errbuf[1024];
>  
>    char *e = __strerror_r (errnum, errbuf, sizeof errbuf);
> -  __assert_fail_base (_("%s%s%s:%u: %s%sUnexpected error: %s.\n"),
> +  __assert_fail_base (_("%s%s%s:%u: %s%sUnexpected error: %s.\n%n"),
>  		      e, file, line, function);
>  }
>  libc_hidden_def (__assert_perror_fail)

The patch is obviously correct but it breaks translations.
How do we handle this before the release?


-- 
ldv

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]