From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62306 invoked by alias); 1 Feb 2018 13:05:05 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 62292 invoked by uid 89); 1 Feb 2018 13:05:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_NUMSUBJECT,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: vmicros1.altlinux.org Date: Thu, 01 Feb 2018 13:05:00 -0000 From: "Dmitry V. Levin" To: libc-alpha@sourceware.org Subject: Re: [PATCH] stdlib: Fixing test-*atexit*-race tests on ia64 Message-ID: <20180201130456.GC28281@altlinux.org> Mail-Followup-To: libc-alpha@sourceware.org References: <1517488865-1052-1-git-send-email-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HG+GLK89HZ1zG0kk" Content-Disposition: inline In-Reply-To: <1517488865-1052-1-git-send-email-adhemerval.zanella@linaro.org> X-SW-Source: 2018-02/txt/msg00007.txt.bz2 --HG+GLK89HZ1zG0kk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1863 On Thu, Feb 01, 2018 at 10:41:05AM -0200, Adhemerval Zanella wrote: > The tests requires a new thread stack size to a value (0x20000) lower than > architecture minimum (0x3000). Set PTHREAD_STACK_MIN in this case. These tests require a new thread stack size set to a value (0x20000) lower than the architecture minimum (0x30000). Set the stack size to PTHREAD_STACK_MIN in this case. > Checked on ia64-linux-gnu. >=20 > * stdlib/test-atexit-race-common.c (do_test): Check stack size > against PTHREAD_STACK_MIN. > --- > ChangeLog | 5 +++++ > stdlib/test-atexit-race-common.c | 5 ++++- > 2 files changed, 9 insertions(+), 1 deletion(-) >=20 > diff --git a/stdlib/test-atexit-race-common.c b/stdlib/test-atexit-race-c= ommon.c > index 4d7f911..02d459c 100644 > --- a/stdlib/test-atexit-race-common.c > +++ b/stdlib/test-atexit-race-common.c > @@ -34,9 +34,11 @@ > #include > #include > #include > +#include #include > const size_t kNumThreads =3D 1024; > const size_t kNumHandlers =3D 1024; > +const size_t kStacksize =3D 0x20000; const size_t kStacksize =3D 0x20000 < PTHREAD_STACK_MIN ? PTHREAD_STACK_MIN : 0x20000; > static void * > threadfunc (void *unused) > @@ -60,7 +62,8 @@ do_test (void) > /* With default 8MiB Linux stack size, creating 1024 threads can cause > VM exhausiton on 32-bit machines. Reduce stack size of each thread= to > 128KiB for a maximum required VM size of 128MiB. */ > - xpthread_attr_setstacksize (&attr, 128 * 1024); > + size_t ss =3D kStacksize < PTHREAD_STACK_MIN ? PTHREAD_STACK_MIN : kSt= acksize; > + xpthread_attr_setstacksize (&attr, ss); >=20=20 > for (i =3D 0; i < kNumThreads; ++i) { > xpthread_create (&attr, threadfunc, NULL); ... and this hunk won't be needed at all. --=20 ldv --HG+GLK89HZ1zG0kk Content-Type: application/pgp-signature; name="signature.asc" Content-length: 801 -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJacxB4AAoJEAVFT+BVnCUIhbYP/2fxXz5dSplHBMnibMBTAzoB A9VvbEaVafVQu3KJBc1T2fKYvFBR7ppwELicy24IMuzt7JbTvYLo2TfYdWiORxFw KqklUJ6fSUjAIW93skYthS/Po2+ugxQiKtJwKIE/V2Ev+62xQfLUjCMKMr30c6/e 9cjycxpDCfMMBSfhoEQwuX6KMXPtRsfPJlAaQ3RbtBVsgiTQp8/CRZK3opYZMzEI R0G9V48CiV7LYh0stJxMpjhduZB+4MWesTeOd7Jnt8/OBFpm6gFA+ymO/IMwfu31 gWZOVF+lAl08bXRi5IAF4wAto8NAo5T7sVNg3k3A0JWLDgmiQ8KzR/LkJzY43J8E VQ02z3RWzN9yzG+zreeduTbzm3HLOA4h7KylUDwnSEJcIOn1ZdWbKD8sENR6QtSE 8PhPuL/jPt8q6XdpeZmd2NOQIXI9CvLqMoVQDp2RpVBsinOuXY2fzTSeu+gjId1P 05+0TvXRYaybpxpNIVGcrMb5WppERI556IDu0ZsEKL62zaK9s5MHtD6sLFmw50Jh Vs6EK78qv+3GnAVbssqwGAtlBsJo1YZCDX9nsCPEkoGXBVZGQCZYWG4T7lJ16mFG v4adQoltN3VwL4aPDHh/m2ME7QPuU5cfgW8m2waDGhN9wTdEPdff9g467TvJ3uMJ 6DFkPkIkLXkLi2otF44t =nwu7 -----END PGP SIGNATURE----- --HG+GLK89HZ1zG0kk--