* POT-Creation-Date line not making it into the output of gettext ("")?
@ 2018-02-07 15:10 Zack Weinberg
2018-02-07 15:15 ` Andreas Schwab
0 siblings, 1 reply; 6+ messages in thread
From: Zack Weinberg @ 2018-02-07 15:10 UTC (permalink / raw)
To: GNU C Library
Lately, whenever I run the test suite locally, intl/tst-gettext fails
due to the output of gettext ("") not being as expected: the
POT-Creation-Date line is missing. This doesn't happen with the same
patch tested using build-may-glibcs, so I'm pretty sure it's an
environment problem of some sort. Does anyone have any idea what
might be the issue?
Example of the problem (I created tst-gettext.got and tst-gettext.exp
by hand from tst-gettext.out):
$ diff -u8 intl/tst-gettext.{got,exp}
--- intl/tst-gettext.got 2018-02-07 09:56:47.394818710 -0500
+++ intl/tst-gettext.exp 2018-02-07 09:56:48.398808299 -0500
@@ -1,11 +1,12 @@
# test `gettext' with LANGUAGE set
# gettext ("") failed
Project-Id-Version: GNU libc 2.26.9000
+POT-Creation-Date: 2018-01-10 15:00+0000
PO-Revision-Date: 2018-01-10 21:17+0100
Last-Translator: Jochen Hein <jochen@jochen.org>
Language-Team: German <translation-team-de@lists.sourceforge.net>
Language: de
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Bugs: Report translation errors to the Language-Team address.
zw
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: POT-Creation-Date line not making it into the output of gettext ("")?
2018-02-07 15:10 POT-Creation-Date line not making it into the output of gettext ("")? Zack Weinberg
@ 2018-02-07 15:15 ` Andreas Schwab
2018-02-07 15:16 ` Zack Weinberg
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Schwab @ 2018-02-07 15:15 UTC (permalink / raw)
To: Zack Weinberg; +Cc: GNU C Library
This is bug 21508.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: POT-Creation-Date line not making it into the output of gettext ("")?
2018-02-07 15:15 ` Andreas Schwab
@ 2018-02-07 15:16 ` Zack Weinberg
2018-02-07 16:06 ` Aurelien Jarno
0 siblings, 1 reply; 6+ messages in thread
From: Zack Weinberg @ 2018-02-07 15:16 UTC (permalink / raw)
To: Andreas Schwab; +Cc: GNU C Library
On Wed, Feb 7, 2018 at 10:10 AM, Andreas Schwab <schwab@suse.de> wrote:
> This is bug 21508.
Hmm, the patch linked from bugzilla might not be appropriate as-is, if
we want to support both old and new msgfmt.
zw
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: POT-Creation-Date line not making it into the output of gettext ("")?
2018-02-07 15:16 ` Zack Weinberg
@ 2018-02-07 16:06 ` Aurelien Jarno
2018-02-07 17:34 ` Zack Weinberg
0 siblings, 1 reply; 6+ messages in thread
From: Aurelien Jarno @ 2018-02-07 16:06 UTC (permalink / raw)
To: Zack Weinberg; +Cc: Andreas Schwab, GNU C Library
On 2018-02-07 10:13, Zack Weinberg wrote:
> On Wed, Feb 7, 2018 at 10:10 AM, Andreas Schwab <schwab@suse.de> wrote:
> > This is bug 21508.
>
> Hmm, the patch linked from bugzilla might not be appropriate as-is, if
> we want to support both old and new msgfmt.
Why? It creates a new input po file without POT-Creation-Date. The
output pot file will therefore also not have this header, with both old
and new msgfmt.
Aurelien
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: POT-Creation-Date line not making it into the output of gettext ("")?
2018-02-07 16:06 ` Aurelien Jarno
@ 2018-02-07 17:34 ` Zack Weinberg
2018-02-07 23:13 ` Aurelien Jarno
0 siblings, 1 reply; 6+ messages in thread
From: Zack Weinberg @ 2018-02-07 17:34 UTC (permalink / raw)
To: Zack Weinberg, Andreas Schwab, GNU C Library
On Wed, Feb 7, 2018 at 10:44 AM, Aurelien Jarno <aurelien@aurel32.net> wrote:
> On 2018-02-07 10:13, Zack Weinberg wrote:
>> On Wed, Feb 7, 2018 at 10:10 AM, Andreas Schwab <schwab@suse.de> wrote:
>> > This is bug 21508.
>>
>> Hmm, the patch linked from bugzilla might not be appropriate as-is, if
>> we want to support both old and new msgfmt.
>
> Why? It creates a new input po file without POT-Creation-Date. The
> output pot file will therefore also not have this header, with both old
> and new msgfmt.
I'm sorry, I misunderstood what your patch does. I have reread it
carefully and I have only one problem with it: the dependency from
catgets/ $(objpfx)de.msg to $(common-objpfx)intl/tst-gettext-de.po
creates an unenforced requirement for "make check" to process the intl
subdirectory before the catgets subdirectory. We already have too
many of these unenforced subdirectory ordering requirements, and it
doesn't look like catgets->intl is an existing one. Would you please
instead add the logic to strip POT-Creation-Date to xopen-msg.awk,
which appears only to be used to create the test de.msg file?
OK with that change.
zw
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: POT-Creation-Date line not making it into the output of gettext ("")?
2018-02-07 17:34 ` Zack Weinberg
@ 2018-02-07 23:13 ` Aurelien Jarno
0 siblings, 0 replies; 6+ messages in thread
From: Aurelien Jarno @ 2018-02-07 23:13 UTC (permalink / raw)
To: Zack Weinberg; +Cc: Andreas Schwab, GNU C Library
On 2018-02-07 12:16, Zack Weinberg wrote:
> On Wed, Feb 7, 2018 at 10:44 AM, Aurelien Jarno <aurelien@aurel32.net> wrote:
> > On 2018-02-07 10:13, Zack Weinberg wrote:
> >> On Wed, Feb 7, 2018 at 10:10 AM, Andreas Schwab <schwab@suse.de> wrote:
> >> > This is bug 21508.
> >>
> >> Hmm, the patch linked from bugzilla might not be appropriate as-is, if
> >> we want to support both old and new msgfmt.
> >
> > Why? It creates a new input po file without POT-Creation-Date. The
> > output pot file will therefore also not have this header, with both old
> > and new msgfmt.
>
> I'm sorry, I misunderstood what your patch does. I have reread it
> carefully and I have only one problem with it: the dependency from
> catgets/ $(objpfx)de.msg to $(common-objpfx)intl/tst-gettext-de.po
> creates an unenforced requirement for "make check" to process the intl
> subdirectory before the catgets subdirectory. We already have too
> many of these unenforced subdirectory ordering requirements, and it
> doesn't look like catgets->intl is an existing one. Would you please
As far as I understand, we already have this ordering requirement as
catgets/tst-catgets.c includes <intl/msgs.h>, which is generated from
the po file. That's actually the reason why catgets has to be modified
in addition to intl.
> instead add the logic to strip POT-Creation-Date to xopen-msg.awk,
> which appears only to be used to create the test de.msg file?
I can try this way. It only means that the mangling done on intl as
to be kept in sync with catgets.
Aurelien
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-07 21:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-07 15:10 POT-Creation-Date line not making it into the output of gettext ("")? Zack Weinberg
2018-02-07 15:15 ` Andreas Schwab
2018-02-07 15:16 ` Zack Weinberg
2018-02-07 16:06 ` Aurelien Jarno
2018-02-07 17:34 ` Zack Weinberg
2018-02-07 23:13 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).