From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48820 invoked by alias); 26 Feb 2018 12:28:31 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 48799 invoked by uid 89); 26 Feb 2018 12:28:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=H*r:172.16.2, Destroy, novice, HX-Envelope-From:sk:gabriel X-HELO: mo19.mail-out.ovh.net Date: Mon, 26 Feb 2018 13:43:00 -0000 From: "Gabriel F. T. Gomes" To: Adhemerval Zanella CC: Subject: Re: [PATCH v8 1/8] nptl: Add C11 threads thrd_* functions Message-ID: <20180226092817.2fe8d745@keller.br.ibm.com> In-Reply-To: References: <1517591084-11347-1-git-send-email-adhemerval.zanella@linaro.org> <1517591084-11347-2-git-send-email-adhemerval.zanella@linaro.org> <20180208114901.7c12242e@keller> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: EX1.emp.local (172.16.2.1) To EX2.emp.local (172.16.2.2) X-Ovh-Tracer-Id: 18260126166056554185 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtfedriedugdefjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd X-SW-Source: 2018-02/txt/msg00719.txt.bz2 On Fri, 09 Feb 2018, Adhemerval Zanella wrote: >On 08/02/2018 11:49, Gabriel F. T. Gomes wrote: >> On Fri, 02 Feb 2018, Adhemerval Zanella wrote: >> >>> -/* We do not support C11 . */ >>> -#define __STDC_NO_THREADS__ 1 >> >> I don't know if that actually matters, but should you wait until the other >> patches in this series (at least patch 2) are in before removing this >> definition? > >I do not have a strong opinion about when to remove __STDC_NO_THREADS__, since >my idea is first get all patches reviewed and acked before actually commit then. Fair enough. I also reviewed the other patches in this set, and I don't have further comments other than the cosmetic bit below. (Since I'm definitely *not* an expert at threads, I only checked against the standard and it looks good to me. So, please read this review as one from a novice) On patch 4: >+/* Destroy condition variable pointed by __cond and free all of its >+ resources. */ >+extern void cnd_destroy (cnd_t *__COND); ~~~~~~ Only here, the parameter name is in uppercase (and the comment in lowercase). Any special reason to do so?