From: James Clarke <jrtc27@jrtc27.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] powerpc: Fix TLE build for SPE (BZ #22926)
Date: Wed, 07 Mar 2018 19:32:00 -0000 [thread overview]
Message-ID: <20180307193220.GA78933@Jamess-MacBook.local> (raw)
In-Reply-To: <5befba4b-7705-63fa-1be9-851ec2d187ef@linaro.org>
On Wed, Mar 07, 2018 at 01:50:27PM -0300, Adhemerval Zanella wrote:
>
>
> On 06/03/2018 15:37, Adhemerval Zanella wrote:
> >
> >
> > On 05/03/2018 15:17, Adhemerval Zanella wrote:
> >> Some SPE opcodes clashes with some recent PowerISA opcodes and
> >> until recently gas did not complain about it. However binutils
> >> recently changed it and now VLE configured gas does not support to
> >> assembler some instruction that might class with VLE (HTM for
> >> instance). It also does not help that glibc build hardware lock
> >> elision support as default (regardless of assembler support).
> >>
> >> Although runtime will not actually enables TLE on SPE hardware
> >> (since kernel will not advertise it), I see little advantage on
> >> adding HTM support on SPE built glibc. SPE uses an incompatible
> >> ABI which does not allow share the same build with default
> >> powerpc and HTM code slows down SPE without any benefict.
> >>
> >> This patch fixes it by only building HTM when SPE configuration
> >> is not used.
> >>
> >> Checked with a powerpc-linux-gnuspe build. I also did some sniff
> >> tests on a e500 hardware without any issue.
> >
> > I also saw no regression compared to PowerPC (32-bit soft-float) report
> > for 2.27 [1] on a e500 hardware.
> >
> > [1] https://sourceware.org/glibc/wiki/Release/2.27#PowerPC_.2832-bit_soft-float.29
> >
>
> If no one opposes I will commit it this shortly.
Hi Adhemerval,
I just tested this myself (by dropping it into the currently-failing
Debian package) and it built successfully, so please go ahead.
Thanks,
James
prev parent reply other threads:[~2018-03-07 19:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 18:17 Adhemerval Zanella
2018-03-06 18:37 ` Adhemerval Zanella
2018-03-07 16:50 ` Adhemerval Zanella
2018-03-07 19:32 ` James Clarke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307193220.GA78933@Jamess-MacBook.local \
--to=jrtc27@jrtc27.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).