From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-91241-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 123407 invoked by alias); 26 Mar 2018 15:17:37 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 123391 invoked by uid 89); 26 Mar 2018 15:17:36 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=BAYES_00,KAM_ASCII_DIVIDERS,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=HX-Envelope-From:sk:gabriel, H*F:D*br
X-HELO: mo19.mail-out.ovh.net
Date: Mon, 26 Mar 2018 15:17:00 -0000
From: "Gabriel F. T. Gomes" <gabriel@inconstante.eti.br>
To: Zack Weinberg <zackw@panix.com>
CC: <libc-alpha@sourceware.org>
Subject: Re: [PATCH 1/9] Use STRFMON_LDBL_IS_DBL instead of __ldbl_is_dbl.
Message-ID: <20180326121719.7e786945@tereshkova>
In-Reply-To: <20180307193205.4751-2-zackw@panix.com>
References: <20180307193205.4751-1-zackw@panix.com>
 <20180307193205.4751-2-zackw@panix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: EX4.emp.local (172.16.2.4) To EX3.emp.local (172.16.2.3)
X-Ovh-Tracer-Id: 1084241614528106061
X-VR-SPAMSTATE: OK
X-VR-SPAMSCORE: -100
X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtgedrvdeigdekkecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
X-SW-Source: 2018-03/txt/msg00548.txt.bz2

On Wed, 07 Mar 2018, Zack Weinberg wrote:

>	* include/monetary.h (STRFMON_LDBL_IS_DBL): New constant.
>	(__vstrfmon_l): Rename to __vstrfmon_l_internal and add flags
>	argument.

Maybe mention that attribute_hidden was not required, thus removed?

Is this another instance of the 'only needed when called both from inside
and outside of glibc' argument (as pointed out in a previous message [1])?

[1] https://sourceware.org/ml/libc-alpha/2018-03/msg00311.html

>-extern ssize_t __vstrfmon_l (char *s, size_t maxsize, locale_t loc,
>-			     const char *format, va_list ap)
>-     attribute_hidden;

Same comment as above, i.e.: is this another instance of the 'only needed
when called both from inside and outside of glibc' argument?

>+extern ssize_t __vstrfmon_l_internal (char *s, size_t maxsize, locale_t loc,
>+                                      const char *format, va_list ap,
>+                                      unsigned int flags);
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Spaces that could be converted to tabs.


>-  ssize_t res = __vstrfmon_l (s, maxsize, _NL_CURRENT_LOCALE, format, ap);
>+  ssize_t res = __vstrfmon_l_internal (s, maxsize, _NL_CURRENT_LOCALE,
>+                                       format, ap, 0);
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Likewise.

>-__vstrfmon_l (char *s, size_t maxsize, locale_t loc, const char *format,
>-	      va_list ap)
>+__vstrfmon_l_internal (char *s, size_t maxsize, locale_t loc,
>+                       const char *format, va_list ap, unsigned int flags)
  ~~~~~~~~~~~~~~~~
Likewise.

>-  res = __nldbl___vstrfmon (s, maxsize, format, ap);
>+  ret = __vstrfmon_l_internal (s, maxsize, _NL_CURRENT_LOCALE, format, ap,
>+                               STRFMON_LDBL_IS_DBL);
  ~~~~~~~~~~~~~~~~~~~~~~~~
Likewise.

>-  res = __nldbl___vstrfmon_l (s, maxsize, loc, format, ap);
>+  ret = __vstrfmon_l_internal (s, maxsize, loc, format, ap,
>+                               STRFMON_LDBL_IS_DBL);
  ~~~~~~~~~~~~~~~~~~~~~~~~
Likewise.