From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111935 invoked by alias); 3 Apr 2018 21:15:27 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 111673 invoked by uid 89); 3 Apr 2018 21:15:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.1 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_NEUTRAL autolearn=ham version=3.3.2 spammy= X-HELO: hera.aquilenet.fr From: Samuel Thibault To: libc-alpha@sourceware.org Cc: Samuel Thibault Subject: [hurd,commited] hurd: Make __if_nametoindex return ENODEV if ifname is too long Date: Tue, 03 Apr 2018 21:15:00 -0000 Message-Id: <20180403211458.12717-1-samuel.thibault@ens-lyon.org> X-SW-Source: 2018-04/txt/msg00078.txt.bz2 rather than truncating it. * sysdeps/mach/hurd/if_index.c (__if_nametoindex): Return ENODEV if ifname is too long. --- ChangeLog | 4 ++-- sysdeps/mach/hurd/if_index.c | 8 ++++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index dd78bf691a..cc9613239d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -35,8 +35,8 @@ 2018-04-03 Samuel Thibault - * sysdeps/mach/hurd/if_index.c (__if_nametoindex): Always end - ifr.fr_name with a NUL caracter. + * sysdeps/mach/hurd/if_index.c (__if_nametoindex): Return ENODEV if + ifname is too long. 2018-04-03 Wilco Dijkstra diff --git a/sysdeps/mach/hurd/if_index.c b/sysdeps/mach/hurd/if_index.c index 7f647b7036..b56bfc7ecd 100644 --- a/sysdeps/mach/hurd/if_index.c +++ b/sysdeps/mach/hurd/if_index.c @@ -37,9 +37,13 @@ __if_nametoindex (const char *ifname) if (fd < 0) return 0; - strncpy (ifr.ifr_name, ifname, IFNAMSIZ - 1); - ifr.ifr_name[IFNAMESIZ - 1] = '\0'; + if (strlen (ifname) >= IFNAMSIZ) + { + __set_errno (ENODEV); + return 0; + } + strncpy (ifr.ifr_name, ifname, IFNAMESIZ - 1); if (__ioctl (fd, SIOCGIFINDEX, &ifr) < 0) { int saved_errno = errno; -- 2.16.2