From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70777 invoked by alias); 3 Apr 2018 22:03:25 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 70766 invoked by uid 89); 3 Apr 2018 22:03:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.1 required=5.0 tests=BAYES_00,GIT_PATCH_1,SPF_HELO_PASS,SPF_NEUTRAL autolearn=ham version=3.3.2 spammy=Hx-languages-length:478 X-HELO: hera.aquilenet.fr Date: Tue, 03 Apr 2018 22:03:00 -0000 From: Samuel Thibault To: Andreas Schwab Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org Subject: Re: [hurd,commited] hurd: Make __if_nametoindex return ENODEV if ifname is too long Message-ID: <20180403220320.yc77umelgkxnbtsa@var.youpi.perso.aquilenet.fr> Mail-Followup-To: Andreas Schwab , libc-alpha@sourceware.org, bug-hurd@gnu.org References: <20180403211458.12717-1-samuel.thibault@ens-lyon.org> <87sh8c3rvd.fsf@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87sh8c3rvd.fsf@linux-m68k.org> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-04/txt/msg00088.txt.bz2 Andreas Schwab, on mar. 03 avril 2018 23:24:54 +0200, wrote: > On Apr 03 2018, Samuel Thibault wrote: > > + strncpy (ifr.ifr_name, ifname, IFNAMESIZ - 1); > > That leaves ifr.ifr_name[IFNAMESIZ - 1] uninitialized. D'oh... If I wasn't seemingly all alone actually working on patches for the Hurd port, I'd tend to have more time to take care... Thanks, Samuel