From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-91615-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 107955 invoked by alias); 18 Apr 2018 14:03:28 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 107944 invoked by uid 89); 18 Apr 2018 14:03:27 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_NEUTRAL,URIBL_RED autolearn=no version=3.3.2 spammy=mer
X-HELO: hera.aquilenet.fr
Date: Wed, 18 Apr 2018 14:03:00 -0000
From: Samuel Thibault <samuel.thibault@gnu.org>
To: Zack Weinberg <zackw@panix.com>
Cc: Joseph Myers <joseph@codesourcery.com>,
	Florian Weimer <fweimer@redhat.com>,
	Thomas Schwinge <thomas@codesourcery.com>,
	GNU C Library <libc-alpha@sourceware.org>, bug-hurd@gnu.org,
	David Michael <fedora.dm0@gmail.com>
Subject: Re: Upstreaming the glibc Hurd port
Message-ID: <20180418140322.642wjpqax3gjfp6j@var.youpi.perso.aquilenet.fr>
Mail-Followup-To: Zack Weinberg <zackw@panix.com>,
	Joseph Myers <joseph@codesourcery.com>,
	Florian Weimer <fweimer@redhat.com>,
	Thomas Schwinge <thomas@codesourcery.com>,
	GNU C Library <libc-alpha@sourceware.org>, bug-hurd@gnu.org,
	David Michael <fedora.dm0@gmail.com>
References: <20180402001003.3u5n2p5pdmv4hos5@var.youpi.perso.aquilenet.fr>
 <alpine.DEB.2.20.1804021407480.16203@digraph.polyomino.org.uk>
 <20180402155017.iermidp5siqgcixv@var.youpi.perso.aquilenet.fr>
 <20180402161347.e5nx7cdt7pkgx52u@var.youpi.perso.aquilenet.fr>
 <alpine.DEB.2.20.1804030010550.29764@digraph.polyomino.org.uk>
 <20180417225015.56yv5wktzcx75srk@var.youpi.perso.aquilenet.fr>
 <alpine.DEB.2.20.1804172300520.1402@digraph.polyomino.org.uk>
 <20180417230835.pa5a3lvoudjyt4gy@var.youpi.perso.aquilenet.fr>
 <alpine.DEB.2.20.1804181112460.23978@digraph.polyomino.org.uk>
 <CAKCAbMi2iNdK0BZnVAxr_Eg6pkUdKjs55jKMUrcFCoAR2-e=ZA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAKCAbMi2iNdK0BZnVAxr_Eg6pkUdKjs55jKMUrcFCoAR2-e=ZA@mail.gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
X-SW-Source: 2018-04/txt/msg00310.txt.bz2

Zack Weinberg, le mer. 18 avril 2018 09:54:53 -0400, a ecrit:
> On Wed, Apr 18, 2018 at 7:13 AM, Joseph Myers <joseph@codesourcery.com> wrote:
> > On Wed, 18 Apr 2018, Samuel Thibault wrote:
> >
> >> Joseph Myers, le mar. 17 avril 2018 23:02:45 +0000, a ecrit:
> >> > On Wed, 18 Apr 2018, Samuel Thibault wrote:
> >> >
> >> > > The patch below would just introduce bits/types/struct___sched_param.h.
> >> > > and bits/types/struct_sched_param.h for all ports since it's the same.
> >> >
> >> > A bits/types/struct_sched_param.h that does "#define sched_param
> >> > __sched_param" is not appropriate for Linux, because it would change the
> >> > C++ mangling of struct sched_param.
> >>
> >> Oh.
> >>
> >> So that could be as per below?
> >
> > That seems plausible (this is not a review of this patch).
> 
> I have a concern: the types 'struct sched_param' and 'struct
> __sched_param' are not compatible, even if their members are identical
> (6.2.7p1 explicitly requires the tags to be the same for
> compatibility).

Ah, probably that's why bits/sched.h used to define both sched_param and
__sched_param with the __sched_priority field, and #define
sched_priority to __sched_priority.  I can do that, it's fine.

Samuel