public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: libc-alpha@sourceware.org
Cc: Carlos O'Donell <carlos@redhat.com>
Subject: [PATCH 01/23] x86: Add feature_1 to tcbhead_t [BZ #22563]
Date: Tue, 08 May 2018 20:40:00 -0000	[thread overview]
Message-ID: <20180508204021.31845-2-hjl.tools@gmail.com> (raw)
In-Reply-To: <20180508204021.31845-1-hjl.tools@gmail.com>

This will be used by CET run-time control.

	[BZ #22563]
	* nptl/pthread_create.c (__pthread_create_2_1): Use
	THREAD_COPY_ADDITONAL_INFO to copy additonal info if defined.
	* sysdeps/i386/nptl/tcb-offsets.sym (FEATURE_1_OFFSET): New.
	* sysdeps/i386/nptl/tls.h (tcbhead_t): Add feature_1.
	* sysdeps/unix/sysv/linux/x86/pthreaddef.h: New file.
	* sysdeps/x86_64/nptl/tcb-offsets.sym (FEATURE_1_OFFSET): New.
	* sysdeps/x86_64/nptl/tls.h (tcbhead_t): Rename __glibc_unused1
	to feature_1.
---
 nptl/pthread_create.c                    |  5 +++++
 sysdeps/i386/nptl/tcb-offsets.sym        |  1 +
 sysdeps/i386/nptl/tls.h                  |  4 ++++
 sysdeps/unix/sysv/linux/x86/pthreaddef.h | 24 ++++++++++++++++++++++++
 sysdeps/x86_64/nptl/tcb-offsets.sym      |  1 +
 sysdeps/x86_64/nptl/tls.h                |  5 ++++-
 6 files changed, 39 insertions(+), 1 deletion(-)
 create mode 100644 sysdeps/unix/sysv/linux/x86/pthreaddef.h

diff --git a/nptl/pthread_create.c b/nptl/pthread_create.c
index 92c945b12b..16998f4bbd 100644
--- a/nptl/pthread_create.c
+++ b/nptl/pthread_create.c
@@ -712,6 +712,11 @@ __pthread_create_2_1 (pthread_t *newthread, const pthread_attr_t *attr,
   THREAD_COPY_POINTER_GUARD (pd);
 #endif
 
+  /* Copy additonal info.  */
+#ifdef THREAD_COPY_ADDITONAL_INFO
+  THREAD_COPY_ADDITONAL_INFO (pd);
+#endif
+
   /* Verify the sysinfo bits were copied in allocate_stack if needed.  */
 #ifdef NEED_DL_SYSINFO
   CHECK_THREAD_SYSINFO (pd);
diff --git a/sysdeps/i386/nptl/tcb-offsets.sym b/sysdeps/i386/nptl/tcb-offsets.sym
index 695a810386..250f1a6e13 100644
--- a/sysdeps/i386/nptl/tcb-offsets.sym
+++ b/sysdeps/i386/nptl/tcb-offsets.sym
@@ -15,3 +15,4 @@ POINTER_GUARD		offsetof (tcbhead_t, pointer_guard)
 #ifndef __ASSUME_PRIVATE_FUTEX
 PRIVATE_FUTEX		offsetof (tcbhead_t, private_futex)
 #endif
+FEATURE_1_OFFSET	offsetof (tcbhead_t, feature_1)
diff --git a/sysdeps/i386/nptl/tls.h b/sysdeps/i386/nptl/tls.h
index 8ca0924692..c3a0edd253 100644
--- a/sysdeps/i386/nptl/tls.h
+++ b/sysdeps/i386/nptl/tls.h
@@ -50,6 +50,10 @@ typedef struct
   void *__private_tm[4];
   /* GCC split stack support.  */
   void *__private_ss;
+  /* Bit 0: IBT.
+     Bit 1: SHSTK.
+   */
+  unsigned int feature_1;
 } tcbhead_t;
 
 # define TLS_MULTIPLE_THREADS_IN_TCB 1
diff --git a/sysdeps/unix/sysv/linux/x86/pthreaddef.h b/sysdeps/unix/sysv/linux/x86/pthreaddef.h
new file mode 100644
index 0000000000..539f6540d0
--- /dev/null
+++ b/sysdeps/unix/sysv/linux/x86/pthreaddef.h
@@ -0,0 +1,24 @@
+/* Pthread macros.  Linux/x86 version.
+   Copyright (C) 2018 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#include_next <pthreaddef.h>
+
+/* Wee need to copy feature_1 in pthread_create.  */
+#define THREAD_COPY_ADDITONAL_INFO(descr)				\
+  ((descr)->header.feature_1						\
+   = THREAD_GETMEM (THREAD_SELF, header.feature_1))
diff --git a/sysdeps/x86_64/nptl/tcb-offsets.sym b/sysdeps/x86_64/nptl/tcb-offsets.sym
index 8a25c482cb..03b6dba5c3 100644
--- a/sysdeps/x86_64/nptl/tcb-offsets.sym
+++ b/sysdeps/x86_64/nptl/tcb-offsets.sym
@@ -15,6 +15,7 @@ VGETCPU_CACHE_OFFSET	offsetof (tcbhead_t, vgetcpu_cache)
 #ifndef __ASSUME_PRIVATE_FUTEX
 PRIVATE_FUTEX		offsetof (tcbhead_t, private_futex)
 #endif
+FEATURE_1_OFFSET	offsetof (tcbhead_t, feature_1)
 
 -- Not strictly offsets, but these values are also used in the TCB.
 TCB_CANCELSTATE_BITMASK	 CANCELSTATE_BITMASK
diff --git a/sysdeps/x86_64/nptl/tls.h b/sysdeps/x86_64/nptl/tls.h
index 059f9675a0..87cc03ee5e 100644
--- a/sysdeps/x86_64/nptl/tls.h
+++ b/sysdeps/x86_64/nptl/tls.h
@@ -56,7 +56,10 @@ typedef struct
 # else
   int __glibc_reserved1;
 # endif
-  int __glibc_unused1;
+  /* Bit 0: IBT.
+     Bit 1: SHSTK.
+   */
+  unsigned int feature_1;
   /* Reservation of some values for the TM ABI.  */
   void *__private_tm[4];
   /* GCC split stack support.  */
-- 
2.17.0

  parent reply	other threads:[~2018-05-08 20:40 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-08 20:40 [PATCH 00/23] CET: Prepare for CET enabling H.J. Lu
2018-05-08 20:40 ` [PATCH 02/23] x86: Support shadow stack pointer in setjmp/longjmp H.J. Lu
2018-05-08 20:40 ` [PATCH 05/23] x86: Add _CET_ENDBR to functions in dl-tlsdesc.S H.J. Lu
2018-05-08 20:40 ` [PATCH 23/23] x86-64: Add endbr64 to tst-quadmod[12].S H.J. Lu
2018-05-08 20:40 ` [PATCH 10/23] x86-64: Use _CET_NOTRACK in strcpy-sse2-unaligned.S H.J. Lu
2018-05-08 20:40 ` [PATCH 14/23] x86-64: Use _CET_NOTRACK in memcpy-ssse3.S H.J. Lu
2018-05-08 20:40 ` [PATCH 12/23] x86-64: Use _CET_NOTRACK in memcpy-ssse3-back.S H.J. Lu
2018-05-08 20:40 ` [PATCH 17/23] i386: Use _CET_NOTRACK in memcmp-sse4.S H.J. Lu
2018-05-08 20:40 ` [PATCH 08/23] x86: Update vfork to pop shadow stack H.J. Lu
2018-05-08 20:40 ` [PATCH 19/23] i386: Use _CET_NOTRACK in memcpy-ssse3.S H.J. Lu
2018-05-08 20:40 ` H.J. Lu [this message]
2018-05-16 14:28   ` [PATCH 01/23] x86: Add feature_1 to tcbhead_t [BZ #22563] Florian Weimer
2018-05-08 20:40 ` [PATCH 09/23] x86_64: Use _CET_NOTRACK in strcmp.S H.J. Lu
2018-05-08 20:40 ` [PATCH 18/23] i386: Use _CET_NOTRACK in memcpy-ssse3-rep.S H.J. Lu
2018-05-08 20:40 ` [PATCH 06/23] x86-64: Add _CET_ENDBR to STRCMP_SSE42 H.J. Lu
2018-05-08 20:40 ` [PATCH 11/23] x86-64: Use _CET_NOTRACK in strcmp-sse42.S H.J. Lu
2018-05-08 20:40 ` [PATCH 03/23] x86: Support IBT and SHSTK in Intel CET [BZ #21598] H.J. Lu
2018-05-08 21:03   ` Joseph Myers
2018-05-08 21:05   ` Joseph Myers
2018-05-09 21:31     ` H.J. Lu
2018-05-08 20:41 ` [PATCH 21/23] i386: Use _CET_NOTRACK in strcat-sse2.S H.J. Lu
2018-05-08 20:41 ` [PATCH 04/23] x86: Add _CET_ENDBR to functions in crti.S H.J. Lu
2018-05-08 20:41 ` [PATCH 07/23] i386: Add _CET_ENDBR to indirect jump targets in add_n.S/sub_n.S H.J. Lu
2018-05-08 20:41 ` [PATCH 16/23] i386: Use _CET_NOTRACK in memset-sse2.S H.J. Lu
2018-05-08 20:41 ` [PATCH 15/23] i386: Use _CET_NOTRACK in i686/memcmp.S H.J. Lu
2018-05-08 20:41 ` [PATCH 20/23] i386: Use _CET_NOTRACK in strcpy-sse2.S H.J. Lu
2018-05-08 20:41 ` [PATCH 22/23] i386: Use _CET_NOTRACK in memset-sse2-rep.S H.J. Lu
2018-05-08 20:41 ` [PATCH 13/23] x86-64: Use _CET_NOTRACK in memcmp-sse4.S H.J. Lu
2018-05-08 20:58 ` [PATCH 00/23] CET: Prepare for CET enabling Jonathan Nieder
2018-05-08 22:07   ` H.J. Lu
2018-05-08 23:01     ` Jonathan Nieder
2018-05-08 21:01 ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180508204021.31845-2-hjl.tools@gmail.com \
    --to=hjl.tools@gmail.com \
    --cc=carlos@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).